gmane.comp.video.mplayer.devel

Re: [PATCH] DJGPP support

compn — 2013-05-17T14:34:43

this patch was stuck in the moderation queue. people need to review
mplayer-dev-eng once in a while...

-compn

Re: [PATCH] DJGPP support

Diego Biurrun — 2013-05-17T13:07:31

This is quite invasive and ugly due to the rampant ifdeffery.  Many of 
the changes look quite suspicious, especially the parts that touch 
configure.

All new files should be in K&R style (check our uncrustify config) and 
have license headers.  Get rid of all the tabs and the trailing whitespace.

Not reviewing this in any kind of detail before those basic issues are 
fixed.  To be completely honest, I'm not sure if it can be cleaned up 
enough to be acceptable, but if you wish to give it a shot, by all means 
go for it.

Diego

Re: va-api support

Reimar Döffinger — 2013-05-16T18:06:42

Mostly commenting from memory here.
I don't know if the vdpau changes would be an issue.
Well, we either need a maintainer or it must be simple enough that
I feel I can do it.
Without that I think the code would better off where it is, in a fork, but
at least with a maintainer...
If there are massive configure changes someone should ok them as well.
I mention this because I think the current code has its whole own
performance measuring framework (which I really, really dislike by
itself) which adds quite a few non-trivial things to configure.
And while this is no hinder for merging the code, I think it might be
worth pointing out that AMD seems to be moving towards VDPAU, which
would leave Intel the only one with any intention to use VAAPI,
which kind of makes it quite a bit less interesting.
And with VDPAU supported by MESA I am not convinced about even Intel
staying with VAAPI in the long term.

Reimar

Re: va-api support

compn — 2013-05-16T15:29:21

if theres a patch which doesnt mess with vdpau, would reimar merge it?

-compn
_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-eng< at >mplayerhq.hu
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng

Re: va-api support

Dan Oscarsson — 2013-05-16T11:49:50

tor 2013-05-16 klockan 07:09 -0400 skrev compn:



I can't remember what was said then.

I looked at the patch then, and at the vaapi->vdpau plugin used in vlc,
and I would have preferred to create a libvdpau_vaapi.so that aadapted
vaapi to vdpau so we could use current vdpau vo. The most important
thing missing in vaapi is presentation queue handling, but that you can
implement with opengl (which I think is already used with vaaapi) and
some code.

If I remember correctly the patch changed things related to the calling
of vo vdpau, so that may break some things.

   Dan
_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-eng< at >mplayerhq.hu
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng

Re: va-api support

compn — 2013-05-16T11:09:41

so is the api still the only blocker for merging this?

-compn
_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-eng< at >mplayerhq.hu
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng

Re: Patch for build failure with clang, lvvm,etc. on Mac OSX > 10.6

Reimar Döffinger — 2013-05-16T05:46:29

I don't see that in your patch.


Why would that be incorrect? Using -Wl means your passing it to the linker behind the compiler's back.
However in particular -fpie is an option the compiler absolutely must see.


Please provide more details.


We discussed that before, and the only conclusion we could make that the compiler is simply broken, adding -fpie should not undefine PIC.
Do you have any other information?


I see it affect older OS X and gcc in potentially bad ways, the removal especially of -mdynamic-no-pic having a serious bad impact on performance of PPC builds.

Re: Improve bluray chapter support

Reimar Döffinger — 2013-05-16T05:39:07

Are there any left? I thought I had removed them all.
_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-eng< at >mplayerhq.hu
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng

Re: va-api support

Reimar Döffinger — 2013-05-16T05:38:24

Maybe there were multiple occasions, but I am quite convinced it reviewed it once and there it stopped.

Re: va-api support

Xidorn Quan — 2013-05-16T04:46:10



I remember that the patch has been sent long ago, but nobody reviewed it
yet.

The vaapi-enabled mplayer is always maintained at
http://gitorious.org/vaapi/mplayer

Re: [PATCH] Correct bogus #ifs for codec ids (was: [MPlayer-cvslog] r36172 - trunk/libmpdemux/demux_lavf.c)

Carl Eugen Hoyos — 2013-05-15T15:01:22


Whatever the reason is that you want to update 
MPlayer, it applies much more to FFmpeg.

Carl Eugen

Re: va-api support

Carl Eugen Hoyos — 2013-05-15T14:55:32


It appears you forgot to attach your patch.

Carl Eugen

Re: [PATCH] Correct bogus #ifs for codec ids (was: [MPlayer-cvslog] r36172 - trunk/libmpdemux/demux_lavf.c)

Dominik 'Rathann' Mierzejewski — 2013-05-15T14:03:06

Why?

Regards,

va-api support

Igor Gnatenko — 2013-04-27T20:41:57

Hi all!
How is the inclusion of va-api into the master branch mplayer?

Re: Improve bluray chapter support

Olivier Rolland — 2013-04-27T06:17:58

Le 26 avr. 2013 21:53, "Reimar Döffinger" <Reimar.Doeffinger< at >gmx.de> a
écrit :

Good news! Do you still need a patch to remove the ifdef around the
chapters parsing function?
_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-eng< at >mplayerhq.hu
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng

Patch for build failure with clang, lvvm,etc. on Mac OSX > 10.6

Aubin Paul — 2013-03-29T14:00:19

Submitted this via Bugzilla but not sure if that's the right place anymore:
http://bugzilla.mplayerhq.hu/show_bug.cgi?id=2134#c0

Darwin-specific changes to fix compilation on current Mac OS X/Xcode/clang

It is not possible to build Mplayer on Mac OS X > 10.6 due to a few
errors in the build system.  The following changes (all can be
implemented in configure for the darwin/x86_64 target) allow mplayer
to build properly.

1. using -DPIC with YASM to allow ffmpeg to compile properly
2. Using -Wl,-pie to fix linking since -pie -fpie is incorrect under
Darwin's clang
3. --mdynamic-no-pic breaks compilation due to security features in
newer versions of Mac OS X

Clang does support PIC but the configure check breaks due to the
inclusion of -fpie -pie so I added a separate check for clang and
darwin to include the right flags. After that, PIC is successfully
detected and works fine.

Attached a patch which fixes the issue and should not affect any other
platforms.
_______________________________________________
MP

Re: [PATCH] demuxer info codepage

Alexander Kulak — 2013-03-21T06:27:39


Maintainers, what are your opinions about the patch? It seems to be ignored.

[PATCH] DJGPP support

Fabrizio Gennari — 2013-03-10T21:09:43

Hello.
This patch allows compilation of MPlayer for MS-DOS using DJGPP dev 
environment. It applies to latest SVN rev 35946, and is based on one 
made by Khusraw of bttr-software.de forum, who ported SVN rev 34661 
(available at http://omploader.org/vY3A4Mg). Cross-compilation is made 
by adding  --target=i386-DJGPP to configure's parameters.

In order to play sounds, it needs a special version of the WSS library, 
that can be found at http://rayer.g6.cz/download/wss.zip (plus the 
relevant --extra-cflags and --extra-ldflags so configure can detect it).

A patch also needs to be applied to FFmpeg as well, see 
https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2013-March/140219.html

Regards,
Fabrizio
_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-eng< at >mplayerhq.hu
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng

Re: [PATCH] Correct bogus #ifs for codec ids (was: [MPlayer-cvslog] r36172 - trunk/libmpdemux/demux_lavf.c)

Carl Eugen Hoyos — 2013-05-15T08:24:57


This does not sound like a good idea.

Carl Eugen

Re: [PATCH] Correct bogus #ifs for codec ids (was: [MPlayer-cvslog] r36172 - trunk/libmpdemux/demux_lavf.c)

Dominik 'Rathann' Mierzejewski — 2013-05-14T20:09:52

That's what I'm trying to do - build current MPlayer against
FFmpeg-1.0.x. I didn't realize those were added to support Libav.
A comment or at least a few words in the SVN commit log would've
helped.

I'll see what I can do to produce a clean and non-intrusive patch.

Thanks for the explanation.

Regards,

Re: [PATCH] Correct bogus #ifs for codec ids (was: [MPlayer-cvslog] r36172 - trunk/libmpdemux/demux_lavf.c)

Reimar Döffinger — 2013-05-14T20:05:15

(Of course if someone wants to maintain it, I don't mind supporting
older versions as long as it does not get too ugly)