gmane.comp.video.mplayer.devel

[PATCH] use yasm macho in configure

Andrew Wason — 2008-12-01T15:10:34

Anyone object to applying the patch to configure referenced in this thread? http://lists.mplayerhq.hu/pipermail/mplayer-users/2008-November/075150.html It changes yasm obj format from macho32 to macho for Mac. I've been running mplayer with the patch for a week now and seen no issues, without it I have dozens of files that mplayer crashes on. I think the issue is libavcodec/i386/x86inc.asm is conditionally compiled based on __OUTPUT_FORMAT__ for macho64 or macho - and so when macho32 is used it does not match macho and ends up using the %else case. Andrew

Re: [PATCH] Direct3D Much better D3D management

Georgi Petrov — 2008-12-01T10:48:48

Fixed. Index: libvo/vo_direct3d.c =================================================================== --- libvo/vo_direct3d.c (revision 28049) +++ libvo/vo_direct3d.c (working copy) < at >< at > -168,12 +168,12 < at >< at > priv->is_clear_needed = 1; } -/** < at >brief Destroy D3D Context related to the current window. +/** < at >brief Destroy D3D Offscreen and Backbuffer surfaces. */ -static void destroy_d3d_context(void) +static void destroy_d3d_surfaces(void) { - mp_msg(MSGT_VO, MSGL_V, "destroy_d3d_context called\r\n"); - /* Let's destroy the old (if any) D3D Content */ + mp_msg(MSGT_VO, MSGL_V, "destroy_d3d_surfaces called\r\n"); + /* Let's destroy the old (if any) D3D Surfaces */ if (priv->locked_rect.pBits) { IDirect3DSurface9_UnlockRect(priv->d3d_surface); < at >< at > -185,32 +185,68 < at >< at > priv->d3d_surface = NULL; } - if (priv->d3d_device != NULL) { - IDirect3DDevice9_Release(priv->d3d_device); - priv->d3d_device = NULL; + if (priv->d3d_

Re: [PATCH] Direct3D Much better D3D management

Diego Biurrun — 2008-12-01T10:31:49

cosmetics Please keep the spaces after the commas separating function arguments that I added. They make things much more readable. Diego

Re: [PATCH] Direct3D Much better D3D management

Georgi Petrov — 2008-12-01T10:29:20

The final (I think) D3D management patch. Index: libvo/vo_direct3d.c =================================================================== --- libvo/vo_direct3d.c(revision 28049) +++ libvo/vo_direct3d.c(working copy) < at >< at > -168,12 +168,12 < at >< at > priv->is_clear_needed = 1; } -/** < at >brief Destroy D3D Context related to the current window. +/** < at >brief Destroy D3D Offscreen and Backbuffer surfaces. */ -static void destroy_d3d_context(void) +static void destroy_d3d_surfaces(void) { - mp_msg(MSGT_VO, MSGL_V, "destroy_d3d_context called\r\n"); - /* Let's destroy the old (if any) D3D Content */ + mp_msg(MSGT_VO,MSGL_V,"destroy_d3d_surfaces called\r\n"); + /* Let's destroy the old (if any) D3D Surfaces */ if (priv->locked_rect.pBits) { IDirect3DSurface9_UnlockRect(priv->d3d_surface); < at >< at > -185,32 +185,68 < at >< at > priv->d3d_surface = NULL; } - if (priv->d3d_device != NULL) { - IDirect3DDevice9_Release(priv->d3d_device); - priv->d3d

Re: [PATCH] vf_screenshot,output filename corresponding to the played file

Ruslan Savchenko — 2008-12-01T04:42:34

That's how it was originally. But I don't see how storing it in a local var would simplify the code. Do you mean just by changing malloc() to alloca() (but man pages say it's usage is discouraged)? Maybe I don't understand something again.

Re: [PATCH] vf_screenshot,output filenamecorresponding to the played file

Michael Niedermayer — 2008-11-30T22:19:54

_______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng< at >mplayerhq.hu https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng

Re: [PATCH] vf_screenshot,output filenamecorresponding to the played file

Michael Niedermayer — 2008-11-30T22:16:49

_______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng< at >mplayerhq.hu https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng

Re: MNG support for MPlayer

Stefan Schuermans — 2008-11-30T13:59:28

Thank you. And also thanks to everybody for reviewing and commenting. Stefan

Re: MNG support for MPlayer

Diego Biurrun — 2008-11-30T13:23:07

Applied. I reformatted demux_mng.c to fit FFmpeg coding style. Diego

Re: [mplayerosx-devel] [PATCH] vo_macosx: usemmap instead of shmat for MPlayerOSX

Nicolas Plourde — 2008-11-30T12:57:50

_______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng< at >mplayerhq.hu https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng

Re: [PATCH] vf_screenshot,output filename corresponding to the played file

Ruslan Savchenko — 2008-11-30T00:18:03

Updated patches attached. Since Uoti objected the usage of the global filename, only "shot" and user-specified basename are left. I will highly appreciate if someone point me how passing the filename into vf should be implemented.

Re: [PATCH] Report the reason to exitfor?-identify

rvm — 2008-11-29T23:20:41

El Lunes, 24 de Noviembre de 2008 10:51, Reimar Döffinger escribió: So can it be committed then?

Re: pkgconfig's cflags honoring (was: Re:[PATCH]Fix compilation on OpenBSD)

Diego Biurrun — 2008-11-29T10:27:05

Look at how some of the other pkg-config tests are done in configure. Anyway, the whole Theora test in configure looks quite crufty and suspicious. I think it needs to be rewritten. Diego

Re: Direct3D OSD discussion

Jim Hauxwell — 2008-11-28T23:15:12

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Reimar Döffinger wrote: Actually, can we defer as I think some discussion is needed for this? Currently the OSD is rendered at the movie aspect not the display aspect. The fix I have (which seems to work) modifies the x or y texture coordinates to map the movie aspect to the display aspect. OSD is a big patch and has required many goes from me to get the formatting correct etc. I think it would be better to have a small patch to enhance the OSD later. Jim -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkkwe4AACgkQhrNWoHjgI1BYQwCeJQWuta9Ylvu+oqmDK/vTcrXx TlgAn3vkoItlQwpkNRLVokKWmjiUYbSQ =IPYZ -----END PGP SIGNATURE-----

Re: Direct3D OSD discussion

Reimar Döffinger — 2008-11-28T22:52:53

Well, just replacing (float)priv->src_width / priv->src_height with (float)vo_dwidth / vo_dheight should do it I think... If it is no effort for you. But I am not in a hurry... Greetings, Reimar Döffinger

Re: [PATCH] yadif SSE2/SSSE3 optimization

Michael Niedermayer — 2008-11-28T21:56:06

_______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng< at >mplayerhq.hu https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng

Re: [PATCH] vf_screenshot,output filenamecorresponding to the played file

Michael Niedermayer — 2008-11-28T21:47:26

_______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng< at >mplayerhq.hu https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng

pkgconfig's cflags honoring (was: Re: [PATCH] Fixcompilation on OpenBSD)

Andrew Savchenko — 2008-11-28T21:09:51

_______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng< at >mplayerhq.hu https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng

Re: MNG support for MPlayer

Stefan Schuermans — 2008-11-28T21:03:58

Thanks for testing. The improved patch is attached. Greetings, Stefan _______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng< at >mplayerhq.hu https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng

Re: Direct3D OSD discussion

Jim Hauxwell — 2008-11-28T20:29:27

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 I have a fix for the OSD and the display size issue - -aspect etc. It basically adjusts the texture coordinates to maximize the OSD in the viewable area, keeping square pixel ratio for the OSD. Do you want another patch with those other cleanups and this? Jim -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkkwVKcACgkQhrNWoHjgI1BfPACfTytl1fYmXUhK4K2IgO7zzkEn Eo4AnRi9ZDkCdx62iaMJDHPRqBc23XMn =G6Z3 -----END PGP SIGNATURE-----

Re: Direct3D OSD discussion

Reimar Döffinger — 2008-11-28T20:15:12

Argh, that is exactly what I asked you about just a few mails ago. You're supposed to be the maintainer of vo_direct3d, it should be your job to review and test it (and before it gets committed).