gmane.comp.video.ffmpeg.devel

Re: [PATCH 2/2] lavd: add v4l2 outdev.

Stefano Sabatini — 2013-05-19T22:37:20

On date Sunday 2013-05-19 23:39:47 +0200, Clément Bœsch encoded:


Silly name? V4L2Context seems more sensible.



nit++: enc_ctx?



Nit: no trailing "."

Also:

    if (s->fd < 0) {
       ret = AVERROR(errno); 
       av_log(s1, AV_LOG_ERROR, "Unable to open V4L2 device '%s');
       return ret;
    }

since av_log might change errno.



"push"?

Some docs in outdevs.texi with an example may be usefull as well.

LGTM otherwise, thanks.

Re: [PATCH] lavfi/geq: prefer symbolic constants

Clément Bœsch — 2013-05-19T22:27:36

You could use them in getpix as well for the plane == U || plane == V case.

Otherwise LGTM

Re: [PATCH 1/2] lavd/v4l2: move pixel format conversion code in a separate place.

Stefano Sabatini — 2013-05-19T22:25:17

Subject nit: move pixel format ... *to* separate place

On date Sunday 2013-05-19 23:39:46 +0200, Clément Bœsch encoded:

LGTM, thanks.

Re: [PATCH] lavfi/geq: add aliases for RGB options

Clément Bœsch — 2013-05-19T22:23:21

Fine with me.

Re: [PATCH] lavfi/geq: mark timeline support

Clément Bœsch — 2013-05-19T22:22:20

LGTM

[PATCH] lavfi/geq: mark timeline support

Stefano Sabatini — 2013-05-19T22:20:36

---
 libavfilter/vf_geq.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/libavfilter/vf_geq.c b/libavfilter/vf_geq.c
index ba07ac1..8b36f22 100644
--- a/libavfilter/vf_geq.c
+++ b/libavfilter/vf_geq.c
< at >< at > -276,4 +276,5 < at >< at > AVFilter avfilter_vf_geq = {
     .inputs        = geq_inputs,
     .outputs       = geq_outputs,
     .priv_class    = &geq_class,
+    .flags         = AVFILTER_FLAG_SUPPORT_TIMELINE_GENERIC,
 };

Re: [PATCH] doc/filters: add RGB geq example

Clément Bœsch — 2013-05-19T21:58:18

That's a nice one.

nit: why the ':' sticked to the left? (It's not really an English
sentence).

BTW, you have a trailing double quote.

LGTM otherwise

[PATCH 2/2] lavd: add v4l2 outdev.

Clément Bœsch — 2013-05-19T21:39:47

TODO: lavd minor bump
---
 Changelog                |   1 +
 configure                |   1 +
 libavdevice/Makefile     |   1 +
 libavdevice/alldevices.c |   2 +-
 libavdevice/v4l2enc.c    | 108 +++++++++++++++++++++++++++++++++++++++++++++++
 5 files changed, 112 insertions(+), 1 deletion(-)
 create mode 100644 libavdevice/v4l2enc.c

diff --git a/Changelog b/Changelog
index 249e8c3..2ed6c87 100644
--- a/Changelog
+++ b/Changelog
< at >< at > -51,6 +51,7 < at >< at > version <next>:
 - Apple Intermediate Codec decoder
 - Escape 130 video decoder
 - FTP protocol support
+- V4L2 output device
 
 
 version 1.2:
diff --git a/configure b/configure
index 6fe7945..01f14fe 100755
--- a/configure
+++ b/configure
< at >< at > -2079,6 +2079,7 < at >< at > sndio_indev_deps="sndio_h"
 sndio_outdev_deps="sndio_h"
 v4l_indev_deps="linux_videodev_h"
 v4l2_indev_deps_any="linux_videodev2_h sys_videoio_h"
+v4l2_outdev_deps_any="linux_videodev2_h sys_videoio_h"
 vfwcap_indev_deps="capCreateCaptureWindow vfwcap_defines"
 vfwcap_indev_extralibs="-lavicap32"
 x11grab_i

[PATCH 1/2] lavd/v4l2: move pixel format conversioncode in a separate place.

Clément Bœsch — 2013-05-19T21:39:46

This will be shared with the output device.
---
 libavdevice/Makefile      |   2 +-
 libavdevice/v4l2-common.c |  96 ++++++++++++++++++++++++++++++++++
 libavdevice/v4l2-common.h |  62 ++++++++++++++++++++++
 libavdevice/v4l2.c        | 130 ++++------------------------------------------
 4 files changed, 170 insertions(+), 120 deletions(-)
 create mode 100644 libavdevice/v4l2-common.c
 create mode 100644 libavdevice/v4l2-common.h

diff --git a/libavdevice/Makefile b/libavdevice/Makefile
index efffa8b..dfde768 100644
--- a/libavdevice/Makefile
+++ b/libavdevice/Makefile
< at >< at > -32,7 +32,7 < at >< at > OBJS-$(CONFIG_PULSE_INDEV)               += pulse.o
 OBJS-$(CONFIG_SDL_OUTDEV)                += sdl.o
 OBJS-$(CONFIG_SNDIO_INDEV)               += sndio_common.o sndio_dec.o
 OBJS-$(CONFIG_SNDIO_OUTDEV)              += sndio_common.o sndio_enc.o
-OBJS-$(CONFIG_V4L2_INDEV)                += v4l2.o timefilter.o
+OBJS-$(CONFIG_V4L2_INDEV)                += v4l2.o v4l2-common.o timefilter.o
 OBJS-$(CONFIG_V4L_INDEV)

[PATCH] lavfi/geq: prefer symbolic constants

Stefano Sabatini — 2013-05-19T21:32:39

Hopefully enhance readability.
---
 libavfilter/vf_geq.c |   66 ++++++++++++++++++++++++++------------------------
 1 file changed, 34 insertions(+), 32 deletions(-)

diff --git a/libavfilter/vf_geq.c b/libavfilter/vf_geq.c
index def3956..ba07ac1 100644
--- a/libavfilter/vf_geq.c
+++ b/libavfilter/vf_geq.c
< at >< at > -42,24 +42,26 < at >< at > typedef struct {
     int is_rgb;
 } GEQContext;
 
+enum { Y = 0, U, V, A, G, B, R };
+
 #define OFFSET(x) offsetof(GEQContext, x)
 #define FLAGS AV_OPT_FLAG_VIDEO_PARAM|AV_OPT_FLAG_FILTERING_PARAM
 
 static const AVOption geq_options[] = {
-    { "lum_expr",   "set luminance expression",   OFFSET(expr_str[0]), AV_OPT_TYPE_STRING, {.str=NULL}, CHAR_MIN, CHAR_MAX, FLAGS },
-    { "y",          "set luminance expression",   OFFSET(expr_str[0]), AV_OPT_TYPE_STRING, {.str=NULL}, CHAR_MIN, CHAR_MAX, FLAGS },
-    { "cb_expr",    "set chroma blue expression", OFFSET(expr_str[1]), AV_OPT_TYPE_STRING, {.str=NULL}, CHAR_MIN, CHAR_MAX, FLAGS },
-    { "u",          "set chroma blue expression", O

[PATCH] lavfi/geq: add aliases for RGB options

Stefano Sabatini — 2013-05-19T21:25:01

---
 doc/filters.texi     |   19 ++++++++++---------
 libavfilter/vf_geq.c |    8 +++++++-
 2 files changed, 17 insertions(+), 10 deletions(-)

diff --git a/doc/filters.texi b/doc/filters.texi
index 910f876..c8d9979 100644
--- a/doc/filters.texi
+++ b/doc/filters.texi
< at >< at > -4003,27 +4003,28 < at >< at > For more information see:
 The filter accepts the following options:
 
 < at >table < at >option
-< at >item lum_expr
+< at >item lum_expr, y
 Set the luminance expression.
-< at >item cb_expr
+< at >item cb_expr, u
 Set the chrominance blue expression.
-< at >item cr_expr
+< at >item cr_expr, v
 Set the chrominance red expression.
-< at >item alpha_expr
+< at >item alpha_expr, a
 Set the alpha expression.
-< at >item r
+< at >item red_expr, r
 Set the red expression.
-< at >item g
+< at >item green_expr, g
 Set the green expression.
-< at >item b
+< at >item blue_expr, b
 Set the blue expression.
 < at >end table
 
 The colorspace is selected according to the specified expressions. If
 one of the < at >option{lum_expr}, < at >option{cb_expr}, or < at >option{cr_expr}
 expression is specified, the filter will automatic

[PATCH] doc/filters: add RGB geq example

Stefano Sabatini — 2013-05-19T20:56:24

---
 doc/filters.texi |    6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/doc/filters.texi b/doc/filters.texi
index 2cc62de..910f876 100644
--- a/doc/filters.texi
+++ b/doc/filters.texi
< at >< at > -4111,6 +4111,12 < at >< at > Generate a quick emboss effect:
 < at >example
 format=gray,geq=lum_expr='(p(X,Y)+(256-p(X-4,Y-4)))/2'
 < at >end example
+
+< at >item
+Enhance RGB components depending on pixel position:
+< at >example
+geq=r=X/W*r(X\,Y): g=(1-X/W)*g(X\,Y): b=(H-Y)/H*b(X\,Y)"
+< at >end example
 < at >end itemize
 
 < at >section gradfun

[PATCH] doc/filters: extend/fix documentation forthe geq filter

Stefano Sabatini — 2013-05-19T20:56:17

---
 doc/filters.texi |   30 +++++++++++++++++++++---------
 1 file changed, 21 insertions(+), 9 deletions(-)

diff --git a/doc/filters.texi b/doc/filters.texi
index 008699e..2cc62de 100644
--- a/doc/filters.texi
+++ b/doc/filters.texi
< at >< at > -4004,25 +4004,31 < at >< at > The filter accepts the following options:
 
 < at >table < at >option
 < at >item lum_expr
-the luminance expression
+Set the luminance expression.
 < at >item cb_expr
-the chrominance blue expression
+Set the chrominance blue expression.
 < at >item cr_expr
-the chrominance red expression
+Set the chrominance red expression.
 < at >item alpha_expr
-the alpha expression
+Set the alpha expression.
 < at >item r
-the red expression
+Set the red expression.
 < at >item g
-the green expression
+Set the green expression.
 < at >item b
-the blue expression
+Set the blue expression.
 < at >end table
 
+The colorspace is selected according to the specified expressions. If
+one of the < at >option{lum_expr}, < at >option{cb_expr}, or < at >option{cr_expr}
+expression is specified, the filter will automatically select a YCbCr

Re: fate.ffmpeg.org update

Thilo Borgmann — 2013-05-19T20:47:36

Am 18.05.13 12:07, schrieb Michael Niedermayer:

Updated, thanks!

-Thilo

[PATCH]Refuse to mux invalid transport streams

Carl Eugen Hoyos — 2013-05-19T20:21:59

Hi!

FFmpeg currently allows to mux transport streams that cannot be decoded, 
attached patch allows to report an error in such a case.

Please comment, Carl Eugen
diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c
index 0ddae65..ec40390 100644
--- a/libavformat/mpegtsenc.c
+++ b/libavformat/mpegtsenc.c
< at >< at > -519,6 +519,43 < at >< at > static int mpegts_write_header(AVFormatContext *s)
     int *pids;
     int ret;
 
+    for (i = 0; i < s->nb_streams; i++) {
+        st = s->streams[i];
+        if (st->codec->codec_type == AVMEDIA_TYPE_DATA)
+            continue;
+        switch (st->codec->codec_id) {
+        case AV_CODEC_ID_CAVS:
+        case AV_CODEC_ID_DIRAC:
+        case AV_CODEC_ID_H264:
+        case AV_CODEC_ID_MPEG1VIDEO:
+        case AV_CODEC_ID_MPEG2VIDEO:
+        case AV_CODEC_ID_MPEG4:
+        case AV_CODEC_ID_AAC:
+        case AV_CODEC_ID_AAC_LATM:
+        case AV_CODEC_ID_AC3:
+        case AV_CODEC_ID_DTS:
+        case AV_CODEC_ID_EAC3:
+        case AV_CODEC_ID_MP2:
+        cas

Re: [PATCH] cmdutils: show timeline support in -filters listing

Stefano Sabatini — 2013-05-19T18:28:07

On date Sunday 2013-05-19 19:43:38 +0200, Clément Bœsch encoded:

Applied, thanks.

Re: [PATCH] doc/Makefile: install .3 man pages toman3 subdir

Stefano Sabatini — 2013-05-19T18:20:18

On date Sunday 2013-05-19 17:12:44 +0200, Stefano Sabatini encoded:

Applied.

Re: [PATCH] cmdutils: show timeline support in -filters listing

Clément Bœsch — 2013-05-19T17:43:38

Fine with me. We can consider a more relevant captioning when we will need
to print more flags.

Re: [PATCH][RFC] Fix field orderforinterlacedAVDJandAVRN in ntsc mode

Michael Niedermayer — 2013-05-19T16:10:32

patch applied

thanks

[...]

[PATCH] cmdutils: show timeline support in -filterslisting

Stefano Sabatini — 2013-05-19T15:30:57

---
 cmdutils.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/cmdutils.c b/cmdutils.c
index f5cddb1..5426349 100644
--- a/cmdutils.c
+++ b/cmdutils.c
< at >< at > -1454,6 +1454,7 < at >< at > int show_filters(void *optctx, const char *opt, const char *arg)
     const AVFilterPad *pad;
 
     printf("Filters:\n"
+           "  T = Timeline support\n"
            "  A = Audio input/output\n"
            "  V = Video input/output\n"
            "  N = Dynamic number and/or type of input/output\n"
< at >< at > -1477,7 +1478,8 < at >< at > int show_filters(void *optctx, const char *opt, const char *arg)
                                   ( i && (filter->flags & AVFILTER_FLAG_DYNAMIC_OUTPUTS))) ? 'N' : '|';
         }
         *descr_cur = 0;
-        printf("%-16s %-10s %s\n", filter->name, descr, filter->description);
+        printf(" %c %-16s %-10s %s\n", filter->flags & AVFILTER_FLAG_SUPPORT_TIMELINE ? 'T' : '.',
+               filter->name, descr, filter->description);
     }
 #endif
     return 0;

Re: [PATCH] doc/Makefile: install .3 man pages toman3 subdir

Stefano Sabatini — 2013-05-19T15:12:44

On date Saturday 2013-05-18 15:11:00 +0200, Stefano Sabatini encoded:

Ping with a minor fix, will apply soon.