gmane.comp.sysutils.mtools.devel

Buffer overflow in mclasserase.c (mtools 4.0.17)

Linards Ticmanis — 2012-04-25T10:14:49

Hello,

there's a buffer overflow in mclasserase.c as it exists in mtools
4.0.17. The char array "drivel" is written with a two character string
PLUS terminating zero byte, but it only has room for two bytes not
three. Without a fix, mclasserase crashes on (at least) Ubuntu Precise.

The offending line is line 147:

  sprintf( drivel, "%c:", tolower(drive) );

To fix it, please do this change:

--- cut here ---
diff -du mtools-4.0.17/mclasserase.c mtools-4.0.17-fixed/mclasserase.c
--- mtools-4.0.17/mclasserase.c 2009-08-29 17:22:08.000000000 +0200
+++ mtools-4.0.17-fixed/mclasserase.c   2012-04-25 12:03:09.905387247 +0200
< at >< at > -90,7 +90,7 < at >< at >

   char cCardType[12];

-  char drivel[2];              /* Stores the drive letter */
+  char drivel[3];              /* Stores the drive letter */


   int i = 0;
--- cut here ---

Regards,

GNU mtools 4.0.17 released

Alain Knaff — 2011-06-28T23:04:06

Hello,

I am pleased to announce the release of GNU mtools version 4.0.17.

GNU mtools is available for download from
ftp://ftp.gnu.org/gnu/mtools and the mirror sites worldwide (see
http://www.gnu.org/order/ftp.html for the list of those).

The signed sources can be obtained from ftp.gnu.org and its world-wide
mirrors:

  ftp://ftp.gnu.org/gnu/mtools/mtools-4.0.17.tar.gz    (510K)
  ftp://ftp.gnu.org/gnu/mtools/mtools-4.0.17.tar.bz2   (403K)
  ftp://ftp.gnu.org/gnu/mtools/mtools-4.0.17.tar.lz    (341K)

The same directory also contains pre-compiled Debian and RPM packages.

Mtools is a collection of utilities to access MS-DOS disks from GNU
and Unix without mounting them, to change FAT-specific file attributes
(hidden, archive, system), and to format FAT media.

Mtools supports W32 style long file names, FAT32, OS/2 Xdf disks and
2m disks (store up to 1992k on a high density 3 1/2 disk). Mtools also
includes mpartition, a simple partitioning programing. It is also a
convenient tool to work with disk image f

mtools version 4.0.16 minfo strange disk type=" S"for some old floppies

Jörg Jenderek — 2011-05-15T22:14:50

Normally minfo produces infomation like disk type="FAT32   " for new big 
haddiscs, disk type="FAT16   " for small harddiscs and disk 
type="FAT12   " for floppy discs. But i found 4 floppy images 
(CRISBOOT.ima, DRD341BD.IMA, Dos3.3.img, dos-211.dcf) with strange values.

For Digital Research DOS ( version 3.41) bootdisc minfo produces the 
following output:

minfo  b:
device information:
===================
filename="/boot/bootsect.bin"
sectors per track: 18
heads: 2
cylinders: 80

mformat command line: mformat -t 80 -h 2 -s 18 -H 603979776 b:

bootsector information
======================
banner:"DIGITAL "
sector size: 512 bytes
cluster size: 1 sectors
reserved (boot) sectors: 1
fats: 2
max available root directory slots: 224
small size: 2880 sectors
media descriptor byte: 0xf0
sectors per fat: 9
sectors per track: 18
heads: 2
hidden sectors: 603979776
big size: 1107305984 sectors
physical drive id: 0x0
reserved=0x0
dos4=0x70
serial number: 20000100
disk label="           "
disk type="       S"


For CRIS

mtools version 4.0.16 minor errors for small sectorsize (32B)

Jörg Jenderek — 2011-05-07T12:02:25

There seems not to exist a mtools command equivalent for the DOS program
SYS.COM. 

I used the program TDSK ( see http://www.freedos.org/software/?prog=tdsk )
to create a small RAM disk driver by a command like:
TDSK.EXE             160    32    8     1       /F:1  
 It produce an output like:
            .--------------------------+-------------------------¬
            | TURBODSK 2.3 - Drive G:  | Sector size:         32 |
            }--------------------------{ Root entries:         8 |
            | Size:       160 Kbytes   | Sectors/cluster:      1 |
            | Memory:   Extended (XMS) |  4810 clusters (FAT16)  |
            `--------------------------`-------------------------'
Then i copy 4 files to ramdisc and create an image (TDSK-5120x32b.img ) of 
this disc.

Then with mtools ( version 4.0.16) i got for mshowfat 'J:*'
refreshing directory
refreshing directory
refreshing directory
J:/readme.txt <2-186>
refreshing directory
refreshing directory
J:/descript.ion <187-199>
J:/save_x_.bin <200-219

GNU mtools 4.0.16 released

Alain Knaff — 2011-04-16T18:08:46

Hello,

I am pleased to announce the release of GNU mtools version 4.0.16.

GNU mtools is available for download from
ftp://ftp.gnu.org/gnu/mtools and the mirror sites worldwide (see
http://www.gnu.org/order/ftp.html for the list of those).

The signed sources can be obtained from ftp.gnu.org and its world-wide
mirrors:

  ftp://ftp.gnu.org/gnu/mtools/mtools-4.0.16.tar.gz    (506K)
  ftp://ftp.gnu.org/gnu/mtools/mtools-4.0.16.tar.bz2   (399K)
  ftp://ftp.gnu.org/gnu/mtools/mtools-4.0.16.tar.lz    (339K)

The same directory also contains pre-compiled Debian and RPM packages.

Mtools is a collection of utilities to access MS-DOS disks from GNU
and Unix without mounting them, to change FAT-specific file attributes
(hidden, archive, system), and to format FAT media.

Mtools supports W32 style long file names, FAT32, OS/2 Xdf disks and
2m disks (store up to 1992k on a high density 3 1/2 disk). Mtools also
includes mpartition, a simple partitioning programing. It is also a
convenient tool to work with disk image f

Re: mtools command equivalent for the DOS programSYS.COM?

Alain Knaff — 2011-04-04T09:04:38


For this, you might be interested in the "syslinux" tool:

http://syslinux.zytor.com/wiki/index.php/The_Syslinux_Project

Regards,

Alain

mtools command equivalent for the DOS program SYS.COM?

Jörg Jenderek — 2011-04-02T14:13:26

There seems not to exist a mtools command equivalent for the DOS program
SYS.COM. 
Of course this work can be done by the dd program, but it is non 
comfortable and susceptible to faults. 

So it would be nice if the maintainers of the mtools could implement such a
command like "msys [SOURCE] DRIVE:".

This seems not so time consuming because the code to transfer a bootloader 
code (maybe given by -b switch) to the boot sector of a drive could be be 
taken from the "mformat" source.
It would be nice if such an mtools program and the mformat command have an 
an option to switch between different DOS bootloader styles for "PC-DOS",
"MS-DOS", "MS Win9x DOS", "mkdosfs" like the newer FreeDOS SYS version 
offers.
To emulate the DOS SYS program it also should copy a DOS Kernel (like 
IO.SYS,IBMBIO.COM, KERNEL.SYS depending on DOS types) and a command line 
interpreter (like COMMAND.COM, 4DOS.COM). This code can be based on the 
source from the mcopy and mattrib commands.