gmane.comp.php.phptal.general

Re: Variables in i18n:attributes

Kornel Lesiński — 2012-05-17T12:10:31

On Wed, 16 May 2012 17:04:07 +0100, Thomas Tanghus <thomas-hcAcQX/JTd/R7s880joybQ< at >public.gmane.org>  
wrote:


Use:

$translation['foo'] = 'Text ${var}'

or

$translation['foo'] = "Text \${var}"

Re: Variables in i18n:attributes

Thomas Tanghus — 2012-05-16T16:14:59


And then answer was so obvious that I didn't consider it:

<tal:block i18n:name="maxFilesize" tal:content="uploadMaxHumanFilesize" />
<div i18n:attributes="title" title="titleTranslationKey">
</div>

Dang, I have done it so many times. 2 minutes after I push "Send" I figure it 
out :-P

Thanks for the help.

Re: Variables in i18n:attributes

Thomas Tanghus — 2012-05-16T16:04:07

Thanks for the suggestion. That - almost - works. One problem though.

 - We use PHP arrays for translations (don't ask me why), so using the ${var} 
notation gives undefined variable errors. I can hack around that by using 
{var} instead and use a modified PHPTAL_TranslationService::translate() 
method. Grabbed from DummyTranslator in the test dir ;-)

function translate($key, $escape=true) {
    $translations = $this->getTranslations();
        if (array_key_exists($key, $translations)) {
            $v = $translations[$key];
        } else {
            $v = $key;
        }

        if ($escape) $v = htmlspecialchars($v);

        while (preg_match('/\{(.*?)\}/sm', $v, $m)) {
            list($src, $var) = $m;
            if (!isset($this->vars[$var])) return "!*$var* is not defined!";
            $v = str_replace($src, $this->vars[$var], $v);
        }
return $v;
}

and a PHPTAL_TranslationService::setVar method like this:

    public function setVar($key, $value) {
        $this->vars[$key] = $val

Re: Variables in i18n:attributes

Robert Goldsmith — 2012-05-16T12:23:30

Maybe I've missed something but my interpretation of your problem is that you want to add variable content into a translation string for an attribute.

How about something like:

<div i18n:attributes="title" title="titleTranslationKey">
<tal:block i18n:name="maxFilesize" tal:content="uploadMaxHumanFilesize" />
</div>

with a po file (assuming you are using gettext) of:

msgid "titleTranslationKey"
msgstr "Drop photo to upload (max ${maxFilesize} MB)"

I am assuming here that the i18n:name key/value pairs are available for attribute translation in the same way they would be for content translation but I haven't seen why that wouldn't be the case.

Robert
----
Robert Goldsmith
rgoldsmith-ekKPKLigxzH10XsdtD+oqA< at >public.gmane.org




On 16 May 2012, at 12:46, Thomas Tanghus wrote:

Re: Variables in i18n:attributes

Thomas Tanghus — 2012-05-16T11:46:02

I found a way around this, in case anybody is interested. It's kind of a hack though.

I assign an instance of my PHPTAL_TranslationService subclass to the template, which lets me do this:

<div tal:define="tooltip php:i18n->translate('Drop photo to upload') . ' (max ' . uploadMaxHumanFilesize . ')'" 
tal:attributes="title tooltip"></div>

It would be nice to be able to do it more elegantly though.

Variables in i18n:attributes

Thomas Tanghus — 2012-05-12T09:53:17

Hi

I started playing around with phptal this week because I wanted to see if it 
was possible to use as a templating system in ownCloud ( http://owncloud.org 
).
It turned out to be very easy to integrate, and I've only stumbled over one 
problem, and that doesn't have anything to do with the integration.

I have a div where I wan't to translate the title dialog which contains a 
variable assign from my template class with PHPTAL::set().

Using the code below shows ${uploadMaxHumanFilesize} as text.

 <div i18n:attributes="title" title="Drop photo to upload (max 
${uploadMaxHumanFilesize} MB)"></div>

Using:

 <div i18n:name="humansize" i18n:attributes="title" title="Drop photo to 
upload (max ${humansize} MB)">${uploadMaxHumanFilesize}</div>

Gives the error "Unable to find variable 'humansize' in current scope in 
/path/to/template"

as does:

 <div i18n:name="humansize" i18n:attributes="title string:photo to upload (max 
${humansize} MB)">${uploadMaxHumanFilesize}</div>

What is actually worse is that si

Re: Bug when popping context

Pierre-Olivier Vares — 2012-05-11T12:47:11



IMHO :
- separate slot contexts and var contexts seems (for me, but I just skimmed
through the code) risky : I'm afraid it generates other problems.

- metal:fill-slot is somehow incompatible with any other attributes (but, if you
did the modification, that's you encountered the case)

Therefore, if this was my code, I'd rather implement the following behaviour :
Treat automatically
  <tag metal:fill-slot [other_attrs]>
as
  <tal:block metal:fill-slot><tag [other_attrs]>

It can be done via a prefilter (some sort of "built-in" prefilter); or maybe
just changing the priority of fill-slot could be sufficient.

Re: Bug when popping context

Kornel Lesiński — 2012-05-09T19:54:28

On Wed, 09 May 2012 13:32:28 +0100, Pierre-Olivier Vares  
<pov-rrf8xsUWrlzt41TpSn4ztw< at >public.gmane.org> wrote:


Yeah, it's a tricky piece of code. I've been going back and forth on this  
for a while.

I wonder whether stack of contexts for macros should be handled separately  
(pushSlotContext() rather than pushContext())...

Bug when popping context

Pierre-Olivier Vares — 2012-05-09T12:32:28

I got the following recursive structure :

<ul>
  <li metal:use-macro="menu_item">
    <tal:block metal:fill-slot="texte">File</tal:block>
    <tal:block metal:fill-slot="sous-menu">
      <ul>
        <li metal:use-macro="menu_item" tal:define="buggy string:">
          <tal:block metal:fill-slot="texte">Open</tal:block>
</li>
      </ul>
    </tal:block>
  </li>
</ul>

<tal:block metal:define-macro="menu_item">
  <li class="menu_item">
    <a href="#"><tal:block metal:define-slot="texte" /></a>
    <tal:block metal:define-slot="sous-menu" />
  </li>
</tal:block>

Instead of
* File
  * Open

the result is :
* Open
  * Open

If I drop the tal:define="buggy string:", that works.
This behaviour is caused by Context::fillSlot, line 215 :

if ($this->_parentContext) {
  // setting slots in any context (probably violates TAL, but works around bug
with tal:define popping context after fillslot)
  $this->_parentContext->fillSlot($key, $content);
}

As I read the comment, the aim of this code piece is to allow usin

Re: PHP segfaults due Exception in SaxXmlParser

Hisateru Tanaka — 2012-05-01T15:45:30

I know that eAccelerator can't handle try-catch block correctly at least in my experience.
In the other hand, PHPTAL uses its special exception handler if exception is finally
passed to outside. They might relate each other on modern PHP, I guess...

How would below(ugly code) work?

// setup $template here

try {
    echo $template->execute();
    $__dummy = 1;  // Avoiding eAccelerator's bug. 
}
catch(Exception $e) {
    $exception = $e;
}
if(isset($exception)) {
    // echo and exit or...
    $handler = new PHPTAL_ExceptionHandler($template->getEncoding());
    $handler->_defaultExceptionHandler($exception);
}


On 2012/05/01, at 23:09, Daniel Jakob wrote:

Re: PHP segfaults due Exception in SaxXmlParser

Daniel Jakob — 2012-05-01T14:09:02

You're right for versions prior to 1.2.2. But in the current version, it
really leads to a crash of the child process. The crash shows up in the
apache error log.

[Tue May 01 10:05:06 2012] [notice] child pid 24285 exit signal
Segmentation fault (11)
[Tue May 01 10:24:32 2012] [notice] child pid 24252 exit signal
Segmentation fault (11)

Re: PHP segfaults due Exception in SaxXmlParser

2012-05-01T12:43:08

I highly doubt that apache is seg-faulting. If you are getting a 500 that could just mean that your error reporting is off.
Sent via BlackBerry by AT&T

-----Original Message-----
From: Daniel Jakob <jakob< at >sc-networks.com>
Sender: phptal-bounces< at >lists.motion-twin.com
Date: Tue, 01 May 2012 10:36:48 
To: <phptal< at >lists.motion-twin.com>
Reply-To: Template Attribute Language for PHP <phptal< at >lists.motion-twin.com>
Subject: [PHPTAL] PHP segfaults due Exception in SaxXmlParser

Hi list

After upgrading TAL to 1.2.2, I found a little problem which makes TAL
quite unuseable in scenarios, when you are not able to control the given
xhtml source. Maybe, the problem depends on newer php versions and/or
eaccelerator.

SaxXmlParser::parseString() throws a PHPTAL_ParserException which isn't
catched by the try/catch block which leads directly to an apache
segfault.
The only exception which gets catched is the PHPTAL_TemplateException.
The ParserException subclasses the TemplateException but - however -

PHP segfaults due Exception in SaxXmlParser

Daniel Jakob — 2012-05-01T08:36:48

Hi list

After upgrading TAL to 1.2.2, I found a little problem which makes TAL
quite unuseable in scenarios, when you are not able to control the given
xhtml source. Maybe, the problem depends on newer php versions and/or
eaccelerator.

SaxXmlParser::parseString() throws a PHPTAL_ParserException which isn't
catched by the try/catch block which leads directly to an apache
segfault.
The only exception which gets catched is the PHPTAL_TemplateException.
The ParserException subclasses the TemplateException but - however - php
doesn't care about it. This happens every time when I access the script
BUT not the first time. Setting forceReparse to true also 'fixes' the
problem so I assume, the problem is somewhere between the phptal cache
files and the exceptions in php. Maybe, the eaccelerator is involved,
too.
What definitely helps is to explicitly catch PHPTAL_ParserException at
the end of the switch-block (like the TemplateException does).

A sample:

test.xhtml:

<html>
<body>
<span style="" style="">I kill th

Re: Custom namespaces

Kornel Lesiński — 2012-04-16T20:32:18

On Mon, 16 Apr 2012 12:09:39 +0100, Robert Goldsmith  
<rgoldsmith-ekKPKLigxzH10XsdtD+oqA< at >public.gmane.org> wrote:


The singleton isn't most elegant indeed.

I think you can safely execute  
PHPTAL_Dom_Defs::getInstance()->registerNamespace() at any time before  
PHPTAL class compiles the template.

Custom namespaces

Robert Goldsmith — 2012-04-16T11:09:39

Hi all,

I'm looking to add a custom namespace to allow me to do some additional processing on a template. As the processing is something I want to do globally and at template compile time the custom namespace seems like a good option and there seems to be some support for this.

I've looked at the way the namespace code works and I believe I need to:

* Create a new class that extends the PHPTAL_Namespace_Builtin class
* In the constructor of this class register my attributes and the namespace prefix etc.
* Replace the builtin method for createAttributeHandler() so I can load my implementation classes from elsewhere.

This all looks pretty reasonable but now I'm looking at how these namespace classes are initiated and I'm looking at class PHPTAL_Dom_Defs. The comments in this class suggest I can create a subclass and use it to register additional namespaces but then the class is setup as a singleton and I can't see how I'd be able to replace it.

Assuming that all I need to do is call PHPTAL_Dom_Defs's regi

Re: How about Composer?

Anton Andriyevskyy — 2012-04-12T21:21:03

My personal and big Thank to everyone! Very useful thing done here for all
of us.

Regards,
Anton

On Thursday, April 12, 2012, Kornel Lesiński wrote:

Re: How about Composer?

Kornel Lesiński — 2012-04-12T15:11:35

On Wed, 11 Apr 2012 23:56:08 +0100, Marco Pivetta <ocramius-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org>  
wrote:


Added.

Re: How about Composer?

Marco Pivetta — 2012-04-11T22:56:08

Registration on packagist is still up to kornel as he has access to the
administration for the repository. Or at least he should setup the callback
Marco Pivetta

http://twitter.com/Ocramius

http://marco-pivetta.com



On 11 April 2012 15:05, Hisateru Tanaka <tanakahisateru-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org> wrote:

_______________________________________________
PHPTAL mailing list
PHPTAL-CzyLcWPZiU5MT9OEwdum/5owlv4uC7bZ< at >public.gmane.org
http://lists.motion-twin.com/mailman/listinfo/phptal

Re: How about Composer?

Kornel Lesiński — 2012-04-11T22:45:37

On Wed, 11 Apr 2012 14:05:14 +0100, Hisateru Tanaka  
<tanakahisateru-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org> wrote:


Done: http://packagist.org/packages/phptal/phptal

Re: How about Composer?

Hisateru Tanaka — 2012-04-11T13:05:14

I was surprised but happier than that.

Can I merge that pull request? If it's so, who should register to Packagist?


On 2012/04/11, at 20:03, Kornel Lesiński wrote:

Re: How about Composer?

Kornel Lesiński — 2012-04-11T11:03:08

On Tue, 10 Apr 2012 23:49:34 +0100, Hisateru Tanaka  
<tanakahisateru-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org> wrote:


Thanks guys. I've added you as collaborators on GitHub.