gmane.comp.php.phpmyadmin.devel

Re: Refactoring insert-edit

Thilina Buddika Abeyrathna — 2012-05-18T02:49:36



Ok Marc, I'll fix that.

Re: Refactoring insert-edit

Marc Delisle — 2012-05-17T16:31:19

Le 2012-05-16 14:55, Thilina Buddika Abeyrathna a écrit :


Thilina,
still having a bug with this scenario. You fixed the part where the rows
were not displayed for editing, however, now that they are displayed, I
try to change data and click Go.

An INSERT statement is wrongly generated.

Re: Refactoring: Displaying query results

Chanaka Dharmarathna — 2012-05-17T07:45:36

Hi Michal,

Thanks for pointing that.
I'll pass them as parameters.

Regards !

Re: Refactoring: Displaying query results

Michal Čihař — 2012-05-17T07:38:02

Hi

Dne Wed, 16 May 2012 21:33:17 +0530
Chanaka Dharmarathna <pe.chanaka.ck< at >gmail.com> napsal(a):


Please try to avoid using global variables, this one should be passed
as parameter (or it should be attribute of class which embeds
displaying query results).

Re: Refactoring insert-edit

Thilina Buddika Abeyrathna — 2012-05-16T18:55:47

On Wed, May 16, 2012 at 6:20 PM, Thilina Buddika Abeyrathna <
thilinaabeyrathna< at >gmail.com> wrote:

Re: Refactoring: Displaying query results

Chanaka Dharmarathna — 2012-05-16T16:03:17

On Mon, May 14, 2012 at 5:30 PM, Chanaka Dharmarathna <
pe.chanaka.ck< at >gmail.com> wrote:

Hi Michal,

I have introduced two small functions to reduce the code repetition in
PMA_getVerticalTable() function in display_tbl.lib.php file.
Both functions are using the global variable $vertical_display.

Now I'm trying to implement unit tests for those functions.
Since there is global variable, it represent null while run the test.
Is there any way to implement test cases for this kind of functions ?

As well, is it possible to implement tests for functions like
PMA_getTableNavigation() which is return a large string ?
If possible, Can you give me some guidance to implement tests for that kind
of functions.

Please note that above function names used in my repository [0].

[0] : https://github.com/Chanaka/phpmyadmin

Regards !

Re: Table zoom search option is broken

Madhura Jayaratne — 2012-05-16T15:08:38

On Wed, May 16, 2012 at 2:51 PM, Atul Pratap Singh <
atulpratapsingh05< at >gmail.com> wrote:

Re: Refactoring insert-edit

Thilina Buddika Abeyrathna — 2012-05-16T12:50:52



Ok Marc.

Re: Refactoring insert-edit

Marc Delisle — 2012-05-16T12:45:00

Le 2012-05-16 08:37, Thilina Buddika Abeyrathna a écrit :

Ok. Don't forget this bug, when following this scenario:

1. Browse a table
2. Click the checkbox for two rows
3. At the botton, click the With selected...change link

Re: Refactoring insert-edit

Thilina Buddika Abeyrathna — 2012-05-16T12:37:37

On Mon, May 14, 2012 at 10:23 PM, Thilina Buddika Abeyrathna <
thilinaabeyrathna< at >gmail.com> wrote:


Hi Marc,
Now tbl_change.php script is somewhat readable and maintainable. Still
there is a long if condition in this script. but it is not a very complex
control statement . So do I need to implement a function to separate that
if condition too.

Table zoom search option is broken

Atul Pratap Singh — 2012-05-16T09:21:36

Hi Madhura,
The Table zoom search option is broken after function name fixes done in
the commit 60f84a045ec53be94c4cb837d8f70ad210990f7a.
Please fix the function names in tbl_zoom_select.php (line 178).

Regards

Re: GSoC: Refactoring Table search, Db search, Multi-table query

Marc Delisle — 2012-05-15T17:07:44

Le 2012-05-15 09:42, Atul Pratap Singh a écrit :

Thanks Atul, I started to have a look and added my comments directly to
github.

Re: GSoC: Refactoring Table search, Db search, Multi-table query

Atul Pratap Singh — 2012-05-15T13:42:00

On Wed, May 9, 2012 at 2:28 AM, Atul Pratap Singh <
atulpratapsingh05< at >gmail.com> wrote:

Hi Marc,
Sorry for the delay. I have done some refactoring in tbl_select.php. Part
of the script responsible for displaying table search form(which was
earlier done using HTML-PHP mix) has now been converted into functions
displaying HTML. Please checkout [0].

[0]
https://github.com/zixtor/phpmyadmin/commit/36d56fb2ea56e47b3979cfb07ff3ad5a1b4f1b2f

refactoring insert/edit: BLOB upload

Marc Delisle — 2012-05-15T10:53:18

Thilina,

I made an insert test with a table that contains a BLOB; the maximum
size for the upload is not displayed.

Re: Refactoring insert-edit

Thilina Buddika Abeyrathna — 2012-05-14T16:53:20

Re: Refactoring insert-edit

Marc Delisle — 2012-05-14T16:39:27

Le 2012-05-14 08:50, Thilina Buddika Abeyrathna a écrit :

Hi Thilina,
The code generating the actions_panel fieldset would benefit from being
refactored into one or more functions. The reason is that it's difficult
to understand quickly such a long code block.

It could become
$html_output = PMA_getActionsPanel(...);

-----------

By the way, did you consider using a class? Have a look at
libraries/Partition.class.php. Then, the calling script uses this syntax:

$partition_names = PMA_Partition::getPartitionNames($db, $table);

The benefit is that you don't have to bother about function name clashing.

Re: Refactoring insert-edit

Thilina Buddika Abeyrathna — 2012-05-14T12:50:37

Hi Marc,
There are HTML code block from line 438 in the tbl_change.php file(after my
last commit [0]).  It doesn't mix with much PHP tags. It is somewhat
readable.
Do I need to implement several functions to render this HTML block. Can you
give me a suggestion..

[0] -
https://github.com/thilinaa/phpmyadmin/commit/9d6c38daf6a98d915a34391bddb987b116be98c0

Re: Duplicate code in CSS themes

Michal Čihař — 2012-05-14T12:42:57

Hi

Dne Mon, 14 May 2012 13:11:16 +0100
Rouslan Placella <rouslan< at >placella.com> napsal(a):


Well I had some mail backlog so I managed to read your mail just after
sending mine :-).


I think this is really good approach.

Re: Duplicate code in CSS themes

Rouslan Placella — 2012-05-14T12:11:16

I mentioned a few days ago that I'm already working on this, thought I 
didn't get into details, so here's my plan.

I will merge theme_left with theme_right first (we'll only have one 
frame in 4.0). Then split the resulting file into smaller files, e.g.: 
common.css, pmd.css, gis.css, rte.css, etc...
The idea here is to make the css files more managable, right now it 
looks to me like everyone just appends new stuff at the bottom of our 
huge files creating an ever bigger mess out of them.

Then all of the resulting files will be reassembled back into a single 
file by the Theme class at run time and sent to the browser along with a 
cache header.

As far as the code duplication goes, the idea is to make all of the new, 
smaller, css files overridable. So only the default theme will include 
all the css files and if another theme is selected and it, for example, 
only has a common.css file, all the other files will be included from 
the default theme.

I think that this approach will both minimise code du

Re: Refactoring: Displaying query results

Chanaka Dharmarathna — 2012-05-14T12:00:51

Hi Michal,

I'll follow your instructions Marc.

Yes, that is the case. I tried with including around three additional
files, but again the error is due to not including some necessary files.
Is there any easier way to run this unit tests independent from the other
tests ?

As well, I'm going to do some modifications regarding to improve
readability of the code.
For functions which are not too small, I'm going to add one empty line,
just after function declaration and just before the end of the function.

Ex :-
function PMA_setDisplayMode($params)
{

// function body after empty line
----
----
// end of the function body

} // end of the function after empty line

Hope this is more readable. Shall I use this ?

Regards !

Duplicate code in CSS themes

Michal Čihař — 2012-05-14T11:58:57

Hi all

I think it is pretty obvious that all themes will share quite big load
of CSS. Originally I though about extracting these bits to Theme class
methods, but now I think it would make things even harder to maintain.

What I feel would be better to create core CSS file, which would be
always included and theme authors will just override/extend it.

This way, we can make changes in core without breaking older themes too
much - maybe some things will not look 100% intergrated, but at least
the layout won't be broken.

Currently original and pmahomme themes share about 2500 lines, they
differ in 1000/500 (pmahomme/original) lines.