gmane.comp.multimedia.ogg.vorbis.devel

Memory Leak in vorbis_info_clear()

William Ahern — 2012-05-14T19:10:14

I'm having trouble tracking down why it leaks, but below is an example
program which shows--using valgrind--that vorbis_info_clear() leaks memory
if called before vorbis_dsp_clear(), but not if called after
vorbis_dsp_clear(). Just compile and run under valgrind, using the -l switch
to the example program to trigger a leak. Tested under OS X 10.7 and Ubuntu
12.04.

This may be by design, or just, "don't do that". If it is the Wiki page
should probably be edited to mention this. I tried, but it didn't look like
I could make the edit.

My solution is to clear in reverse order of initialization, though I've
rearranged the order of things in the example program to highlight the
immediate issue.

/* compile: cc -Wall -o vbs vbs.c -lvorbisenc -lvorbis */
/* noleak:  valgrind --leak-check=yes ./vbs */
/* leak:    valgrind --leak-check=yes ./vbs -l */
#include <unistd.h> /* getopt(3) */

#include <vorbis/codec.h>
#include <vorbis/vorbisenc.h>


static struct vorbis_info info;
static struct vorbis_dsp_state dsp;
stat

Patch for statically allocated tremor

戴明仁 (mingjen_tai — 2012-04-24T03:39:01

Hi all,

    I checked the mailing list of tremor and found that there was a patch for statically memory allocation. But the link(http://x256.org/~hb/Tremor.patch) seems to be dead since the site was down. Can I get that patch elsewhere? Thanks for your help.

 

 

Best regards,

Jen

 

_______________________________________________
Vorbis-dev mailing list
Vorbis-dev< at >xiph.org
http://lists.xiph.org/mailman/listinfo/vorbis-dev

Re: command line perl tool to create ogg/Vorbispicture comments

Ian Malone — 2012-04-17T22:44:20



We do have two ways of associating images, this is a consequence of
using a FLAC/ID3V2-like block for the images.
http://wiki.xiph.org/VorbisComment#Linked_images added some
restrictions about what was allowed.
The tool creates the block preamble for track art as set out in
http://wiki.xiph.org/VorbisComment#METADATA_BLOCK_PICTURE

I have to admit I hadn't really been following this chapter
discussion. It looks like straight base64 encoding of the images was
suggested, I think it may be best to try and stick with the FLAC block
format, if only so people writing a Ogg comment handler have a single
type of image container to deal with. You may want to disallow links
altogether in the spec for chapter images, the only other thing that
would be required would be explicitly saying the restriction to one of
each picture type doesn't apply to different chapters.

Re: command line perl tool to create ogg/Vorbispicture comments

Silvia Pfeiffer — 2012-04-17T11:36:19

Ah oops! :-)
I somehow only saw the pastebin from the previous email.



Yeah, github is good enough. Don't worry, I was confused.



Are you suggesting we have two ways of associating images with
chapters: URLs and base64 images? If so, we should have two different
vorbiscomment headers for these.



Good stuff!

Cheers,
Silvia.

Re: command line perl tool to create ogg/Vorbispicture comments

Ian Malone — 2012-04-17T10:58:45




Thanks. But what do you mean? This is release fd9c72b011. :)

Actually I've had to go and check whether I had Xiph svn access it's
so long since I used it (I do). I don't know whether this could go
into vorbis-tools or not due to the addition of Perl and requirement
for a couple of Perl modules, it might need to be its own package.
Additionally I'd want to make sure the character encoding-handling
conforms with the spec on the wiki before suggesting it as an official
Xiph tool. With that caveat would be happy to stick a version tag on
it and add it officially somewhere.

Things that would be nice to have in a full package:
Adding linked image handling would need some work and I'd need a bit
of feedback on it. Was never particularly taken with that bit of the
specification due to security implications for remote links and the
fragility of local links, has to be done carefully.

An accompanying extractor/decoder would be useful also and could
probably be done through the Exif library too. Not entirely triv

Re: command line perl tool to create ogg/Vorbispicture comments

Silvia Pfeiffer — 2012-04-17T03:21:00

Nice work! You should put it in the xiph repository or release some other way.

Cheers,
Silvia.

On Tue, Apr 17, 2012 at 10:56 AM, Ian Malone <ibmalone< at >gmail.com> wrote:

command line perl tool to create ogg/Vorbis picturecomments

Ian Malone — 2012-04-17T00:56:00

It turns out I'm crazy...

https://github.com/imalone/oggflacblock
Or direct from (n.b. BSD license):
https://raw.github.com/imalone/oggflacblock/master/oggflacblock.pl

Now handles png and jpeg, the only notable dependency is the Perl
Image::ExifTool module. (Which, I've noticed, can also read Vorbis
comments)

Includes usage info with -h or -help, but interesting things:
./oggflacblock.pl -i sample.png -o sample.tag -write tag -desc "Some
description" -type FileIconSmall

-write tag : produces a file with the "METADATA_BLOCK_PICTURE=" start,
so you can plug it straight into vorbiscomment. This is the default,
so you can do this:
vorbiscomment startfile.ogg newfile.ogg -a -c sample.tag
the other options are block64 (just the block as before) and blockraw
(don't 64bit encode)

-type, can be numeric, or I've come up with some short-names for the
different entries that you can specify instead.

FileIconSmall is restricted to 32x32 png, this is enforced.

Shortcomings:
* Doesn't do the "->" mode.
* Doesn't pro

Re: Enhanced Podcasts with Ogg Vorbis (Chapter Marks)

Georg Holzmann — 2012-04-16T11:06:35

Hallo!

Many thanks for your testfiles, Ian!

I tried all your files now with my player (Cowon iAudio 7, Firmware 
1.18) and they all worked ok.


That's sad ... I don't want to lock players just because of some images 
... :(

LG
Georg

Re: Enhanced Podcasts with Ogg Vorbis (Chapter Marks)

Ian Malone — 2012-04-15T10:39:41

Hi, I'd thought about it, but had problems logging into my webspace
for a while. I've managed to get them up now.

WARNING. IT'S POSSIBLE THESE FILES MAY CAUSE YOUR PLAYER TO FREEZE OR
STOP WORKING.
http://www.imalone.co.uk/ogg_picture/
Actually it'll be faulty programming that's to blame, but anyone
trying these out should be aware this is a risk. My Clip+ and old
iAudio G3 (which eventually succumbed to hardware failure) appeared to
be able to reset themselves when this happened,




The picture used is one of my own DSCN7376, licensed under CC BY-NC-SA
3.0 http://creativecommons.org/licenses/by-nc-sa/3.0/
The audio is Kenny Beltry Hydrate retrieved from
http://www.vorbis.com/music/ licensed under CC BY 1.0
http://creativecommons.org/licenses/by/1.0/

Re: Enhanced Podcasts with Ogg Vorbis (Chapter Marks)

Silvia Pfeiffer — 2012-04-15T01:42:41

Can you post links to the files? I've had private requests for files
so others can test them on other devices, too.
I didn't want to create heaps, since I don't know the range where it
would break, but you seem to have done so already.
So, this would really help test on other devices.

Thanks,
Silvia.

On Sun, Apr 15, 2012 at 9:36 AM, Ian Malone <ibmalone< at >gmail.com> wrote:

Re: Enhanced Podcasts with Ogg Vorbis (Chapter Marks)

Ian Malone — 2012-04-14T23:36:23

Sansa Clip+ 8GB,
Somewhere between a 486K and 635K comment the Clip+ locks up. This
appears to be related to total comment size rather than individual
tags. In the following xxpc refers to the image size, 2x and 3x
indicate multiple METADATA_BLOCK_PICTURE entries.
729K  3x30pcsize - crash *
635K  50pcsize - crash
486K  2x30pcsize - okay
480K  45pcsize - okay

* crash occurs whether or not replaygain is enabled, this is the only
one I've tested that for.

In the case of crashes the player freezes, holding down the down
button is required to turn it off. It then takes longer than normal to
start up again, seems to do a reset to an earlier state. Total file
size was 4.5M (3x30pc), 4.4M (50pc), 4.2M (45pc/2x30pc). I used the
Hydrate-Kenny_Beltrey.ogg file for testing.

Re: Enhanced Podcasts with Ogg Vorbis (Chapter Marks)

Ian Malone — 2012-04-14T22:40:04




Like:
echo -n "METADATA_BLOCK_PICTURE=" | cat - flacblock > flacblock.comment

Re: Enhanced Podcasts with Ogg Vorbis (Chapter Marks)

Ian Malone — 2012-04-14T22:34:12

The more adventurous could also use this:
http://pastebin.com/xXhPyZuQ
It's a very basic Perl-based creator for Base64 FLAC blocks, as used
in METADATA_BLOCK_PICTURE
http://wiki.xiph.org/VorbisComment#METADATA_BLOCK_PICTURE
It will not currently do png files, though that could be added trivially.

I forgot to add usage information, but save it as jpegtoblock.pl, make
it executable and then:
./jpegtoblock.pl  -i DSCN7376.JPG -o flacblock
Will create a base64 encoded block (in flacbloc) from DSCN7376.JPG.
Optional arguments are:
-desc "X"
Add a description string
-type N
The ID3V2 picture type
http://flac.sourceforge.net/format.html#metadata_block_picture

You'll need to add the "METADATA_BLOCK_PICTURE=" which makes it into a
comment file yourself.

I suppose I'd best get around to trying it out myself.

Re: Enhanced Podcasts with Ogg Vorbis (Chapter Marks)

Silvia Pfeiffer — 2012-04-13T09:04:50

For those of you wanting to do experiments, get yourself a file from
http://www.vorbis.com/music/ and run the vorbiscomment program (which
you can get from the vorbis-tools package). Use a base64 encoded image
(I have a command-line tool called "base64") as the value of a field
(e.g. call the field BLOCK_PICTURE) for the vorbiscomment program.
Repeat that until you get a file that your HW player doesn't play any
more.

HTH.

Cheers,
Silvia.

On Fri, Apr 13, 2012 at 3:56 AM, Georg Holzmann <grh< at >mur.at> wrote:

Re: Enhanced Podcasts with Ogg Vorbis (Chapter Marks)

Georg Holzmann — 2012-04-12T17:56:19

Am 2012-04-12 16:08, schrieb Silvia Pfeiffer:

I have also an ogg vorbis hardware player (Cowon iAudio 7), then we have 
n=2 ... ;)

LG
Georg

Re: Enhanced Podcasts with Ogg Vorbis (Chapter Marks)

Silvia Pfeiffer — 2012-04-12T14:08:11

Excellent. See how large you can make the vorbiscomment header before
the player gives up.

Thanks,
Silvia.

Re: Enhanced Podcasts with Ogg Vorbis (Chapter Marks)

Ian Malone — 2012-04-12T14:01:02

2012/4/12 Silvia Pfeiffer <silvia< at >silvia-pfeiffer.de>:
I don't, but I could do some testing on a sample of n=1 over the weekend.

Re: Enhanced Podcasts with Ogg Vorbis (Chapter Marks)

Silvia Pfeiffer — 2012-04-12T08:37:42

I agree we need to have them inline. But because of HW player
restrictions it would make sense to recommend a max image size in
bytes or a max chapter header size. If somebody has that information,
please share.

Cheers,
Silvia.

2012/4/12 Gunter Königsmann <gunter< at >peterpall.de>:

Re: Enhanced Podcasts with Ogg Vorbis (Chapter Marks)

Gunter Königsmann — 2012-04-12T07:26:33

If Hardware players allow for the comment size I have an argument for
embedding images into the stream:
Just providing links would allow to introduce 1-pixel-images with unique
URLs into a vorbis stream to be able to track usage data for your
podcast. Ogg streams that compromise your privacy this way sound like
something that can generate a bad press echo one day.

Kind regards,

   Gunter.

Re: Enhanced Podcasts with Ogg Vorbis (Chapter Marks)

Georg Holzmann — 2012-04-12T06:44:26

Hallo!


You are right.
In the MP4-podcasting world they use one link all the time (which is 
shown by players like instacast), but I don't know why ...


[...]

OK - fine!

Have a nice day!
LG
Georg

Re: Enhanced Podcasts with Ogg Vorbis (Chapter Marks)

Silvia Pfeiffer — 2012-04-11T21:54:34


On 12/04/2012, at 1:34 AM, Georg Holzmann <grh< at >mur.at> wrote:


It doesn't really matter if we specify that or not. What matters is whether an app supports multiple links. If it doesn't then a file with multiple links in a chaptermay just mean that the first ones are replaced and never accessible. What do actual players do?




Well I won't add anything until we have an answer.

Cheers,
Silvia.