http://permalink.gmane.org/gmane.comp.kde.education hourly 1 1901-01-01T00:00+00:00 http://gmane.org/img/gmane-25t.png http://gmane.org http://permalink.gmane.org/gmane.comp.kde.education/7304 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110414/ ----------------------------------------------------------- (Updated May 20, 2013, 3:45 p.m.) Review request for KDE Edu, Aleix Pol Gonzalez and Percy Camilo Triveño Aucahuasi. Changes ------- removed unnecessary includes. Description ------- As we discussed the outline for khipu-specific file , I have implemented this feature. The attached diff contains the feature for save Action in Khipu. I have used qjson for file format. Diffs (updated) ----- CMakeLists.txt f7dc583 src/CMakeLists.txt 0a50c54 src/datastore.h a1276a7 src/datastore.cpp 616e0cc src/mainwindow.h 1f059f8 src/mainwindow.cpp 9d6e010 src/plotseditor.h 47304c6 src/plotseditor.cpp 106cdf5 Diff: http://git.reviewboard.kde.org/r/110414/diff/ Testing ------- Done..! worked perfect for any situtation I have come across. ! Thanks, Punit Mehta ______</pre> Punit Mehta 2013-05-20T15:45:37 http://permalink.gmane.org/gmane.comp.kde.education/7303 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110414/ ----------------------------------------------------------- (Updated May 20, 2013, 3:36 p.m.) Review request for KDE Edu, Aleix Pol Gonzalez and Percy Camilo Triveño Aucahuasi. Changes ------- Removed the static members and used signal/slots to keep track of the added space. Description ------- As we discussed the outline for khipu-specific file , I have implemented this feature. The attached diff contains the feature for save Action in Khipu. I have used qjson for file format. Diffs (updated) ----- CMakeLists.txt f7dc583 src/CMakeLists.txt 0a50c54 src/datastore.h a1276a7 src/datastore.cpp 616e0cc src/mainwindow.h 1f059f8 src/mainwindow.cpp 9d6e010 src/plotseditor.h 47304c6 src/plotseditor.cpp 106cdf5 Diff: http://git.reviewboard.kde.org/r/110414/diff/ Testing ------- Done..! worked perfect for any situtation</pre> Punit Mehta 2013-05-20T15:36:38 http://permalink.gmane.org/gmane.comp.kde.education/7302 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110414/#review32791 ----------------------------------------------------------- src/mainwindow.h &lt;http://git.reviewboard.kde.org/r/110414/#comment24350&gt; indentation src/mainwindow.h &lt;http://git.reviewboard.kde.org/r/110414/#comment24351&gt; better pass a "const QPixmap&amp;". It's how it's usually done in Qt, with non-QObject classes src/plotseditor.h &lt;http://git.reviewboard.kde.org/r/110414/#comment24352&gt; I don't think you really want to expose that. This change is too complex for its purpose. Why don't you add signals for doing this, instead of keeping track of the saved spaces (m_savedSpaces)? It's very likely it will end up breaking eventually. - Aleix Pol Gonzalez On May 18, 2013, 11:19 a.m., Punit Mehta wrote: _______________________________________________ kde-edu mailing list kde-edu&lt; at &gt;mail.kde.org https://mail.kde.org/mail</pre> Aleix Pol Gonzalez 2013-05-19T22:10:50 http://permalink.gmane.org/gmane.comp.kde.education/7301 <pre> Yep, after the (long) weekend. - Christoph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110432/#review32535 ----------------------------------------------------------- On May 14, 2013, 10:31 p.m., Christoph Feck wrote: _______________________________________________ kde-edu mailing list kde-edu&lt; at &gt;mail.kde.org https://mail.kde.org/mailman/listinfo/kde-edu </pre> Christoph Feck 2013-05-19T05:16:49 http://permalink.gmane.org/gmane.comp.kde.education/7300 <pre> So Christoph are you commiting this? - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110432/#review32535 ----------------------------------------------------------- On May 14, 2013, 10:31 p.m., Christoph Feck wrote: _______________________________________________ kde-edu mailing list kde-edu&lt; at &gt;mail.kde.org https://mail.kde.org/mailman/listinfo/kde-edu </pre> Albert Astals Cid 2013-05-18T11:35:27 http://permalink.gmane.org/gmane.comp.kde.education/7299 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110414/ ----------------------------------------------------------- (Updated May 18, 2013, 11:19 a.m.) Review request for KDE Edu, Aleix Pol Gonzalez and Percy Camilo Triveño Aucahuasi. Changes ------- fixed a small bug to consider savedspaces (when goHome is clicked) also. Description ------- As we discussed the outline for khipu-specific file , I have implemented this feature. The attached diff contains the feature for save Action in Khipu. I have used qjson for file format. Diffs (updated) ----- CMakeLists.txt f7dc583 src/CMakeLists.txt 0a50c54 src/datastore.h a1276a7 src/datastore.cpp 616e0cc src/mainwindow.h 1f059f8 src/mainwindow.cpp 9d6e010 src/plotseditor.h 47304c6 src/plotseditor.cpp 106cdf5 Diff: http://git.reviewboard.kde.org/r/110414/diff/ Testing ------- Done..! worked perfect for any situtation I have c</pre> Punit Mehta 2013-05-18T11:19:08 http://permalink.gmane.org/gmane.comp.kde.education/7298 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110414/ ----------------------------------------------------------- (Updated May 15, 2013, 8:37 p.m.) Review request for KDE Edu, Aleix Pol Gonzalez and Percy Camilo Triveño Aucahuasi. Changes ------- Removed unneccesary code portions and reimplemeted mapPlotFixed for Khipu Description ------- As we discussed the outline for khipu-specific file , I have implemented this feature. The attached diff contains the feature for save Action in Khipu. I have used qjson for file format. Diffs (updated) ----- CMakeLists.txt f7dc583 src/CMakeLists.txt 0a50c54 src/datastore.h a1276a7 src/datastore.cpp 616e0cc src/mainwindow.h 1f059f8 src/mainwindow.cpp 9d6e010 src/plotseditor.h 47304c6 src/plotseditor.cpp 106cdf5 Diff: http://git.reviewboard.kde.org/r/110414/diff/ Testing ------- Done..! worked perfect for any situtation I have c</pre> Punit Mehta 2013-05-15T20:37:59 http://permalink.gmane.org/gmane.comp.kde.education/7297 <pre> No problem. I am just happy it's getting done. - Peter ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110432/#review32535 ----------------------------------------------------------- On May 14, 2013, 10:31 p.m., Christoph Feck wrote: _______________________________________________ kde-edu mailing list kde-edu&lt; at &gt;mail.kde.org https://mail.kde.org/mailman/listinfo/kde-edu </pre> Peter Hedlund 2013-05-14T23:40:19 http://permalink.gmane.org/gmane.comp.kde.education/7296 <pre> Oops, I forgot to check if there was already a review request... I did not intend to hijack :) - Christoph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110432/#review32535 ----------------------------------------------------------- On May 14, 2013, 10:31 p.m., Christoph Feck wrote: _______________________________________________ kde-edu mailing list kde-edu&lt; at &gt;mail.kde.org https://mail.kde.org/mailman/listinfo/kde-edu </pre> Christoph Feck 2013-05-14T23:20:03 http://permalink.gmane.org/gmane.comp.kde.education/7295 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110432/#review32535 ----------------------------------------------------------- Ship it! Exactly the change I had in mind. See my comment in https://git.reviewboard.kde.org/r/110379/. Thank you! - Peter Hedlund On May 14, 2013, 10:31 p.m., Christoph Feck wrote: _______________________________________________ kde-edu mailing list kde-edu&lt; at &gt;mail.kde.org https://mail.kde.org/mailman/listinfo/kde-edu </pre> Peter Hedlund 2013-05-14T23:04:23 http://permalink.gmane.org/gmane.comp.kde.education/7294 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110432/ ----------------------------------------------------------- Review request for KDE Edu, Albert Astals Cid, Frederik Gladhorn, Peter Hedlund, and Jeremy Paul Whiting. Description ------- When e.g. KWordQuiz writes a document with images, the XML writer tries to use relative paths. This fails, because the URL of the document to be saved is set _after_ writing the document. Attached patch fixes this issue by changing m_Url before calling the writer. In case of an error, it is set back to the old (previous) value. Somewhat related is the change in the writer. Initially I had the impression the "is URL A relative of URL B" check using "startsWith" string compares was the culprit. Since KUrl offers an own function, I kept this change. This addresses bug 318787. http://bugs.kde.org/show_bug.cgi?id=318787 Diffs ----- keduvocdocument/keduvoc</pre> Christoph Feck 2013-05-14T22:31:12 http://permalink.gmane.org/gmane.comp.kde.education/7293 <pre> Yes, I'm saying that you initialize class attributes in the constructor, not in the declaration. exit(0) is equivalent to a crash. See the methods KAlgebra::saveGraph and KAlgebra::save3DGraph in KAlgebra. It's only that it's better to make sure we only have 1 set of code paths for printing the view state, and I don't you looked at those. No, I'm suggesting to add it to DataStore. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110414/#review32445 ----------------------------------------------------------- On May 13, 2013, 1:55 p.m., Punit Mehta wrote: _______________________________________________ kde-edu mailing list kde-edu&lt; at &gt;mail.kde.org https://mail.kde.org/mailman/listinfo/kde-edu </pre> Aleix Pol Gonzalez 2013-05-14T12:12:58 http://permalink.gmane.org/gmane.comp.kde.education/7292 <pre> Yes.. we need that because I have implemented it in such a way that we need these variables to keep track of the number spaces added and saved.! Ok. I will remove this. I think I have used this to ensure that the application does not crash beacause of the null PlotItem . No problem , I will remove this also .! Aleix , which API you are talking about ? Is it Analitza or some class of Qt ? and is there any problem in the current approach ? OK. I will change this and send you the new diff as it gets ready .! Aleix , I dont get this. You are telling to modify addPlot of analitzaplot ? - Punit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110414/#review32445 ----------------------------------------------------------- On May 13, 2013, 1:55 p.m., Punit Mehta wrote: _______________________________________________ kde-edu mailing list kde-edu&lt; at &gt;mail.kde.org https://mail.kde.org/mailman/</pre> Punit Mehta 2013-05-14T11:45:19 http://permalink.gmane.org/gmane.comp.kde.education/7291 <pre>On Mon, May 13, 2013 at 9:23 PM, Marco Calignano &lt;marco.calignano&lt; at &gt;gmail.com&gt;wrote: Hi Marco, I also don't like having 2 entry ways, but I also think it can be problematic to narrow down the Pairs usage to class-only. Also I guess that the teacher will have to set up different systems at the same time, so it probably makes sense to find out a way to run a prepared session by the teacher. What you are proposing, is to have different games and after 1 level is done, the kid jumps to the next. To do this the teacher can run it with pairs and the game shouldn't have space for much further configuration. Also this could make it possible to specify the number of kids to use the game or other parameters, additionally to the levels list. Do you think this makes sense? Aleix _______________________________________________ kde-edu mailing list kde-edu&lt; at &gt;mail.kde.org https://mail.kde.org/mailman/listinfo/kde-edu </pre> Aleix Pol 2013-05-13T22:40:50 http://permalink.gmane.org/gmane.comp.kde.education/7290 <pre> We currently have no other way than looking for "Untitled". I will however soon update the patch as it does not address a similar issue occurring if the user does "Save As..." in a different folder. - Peter ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110379/#review32459 ----------------------------------------------------------- On May 10, 2013, 1:45 a.m., Peter Hedlund wrote: _______________________________________________ kde-edu mailing list kde-edu&lt; at &gt;mail.kde.org https://mail.kde.org/mailman/listinfo/kde-edu </pre> Peter Hedlund 2013-05-13T22:37:16 http://permalink.gmane.org/gmane.comp.kde.education/7289 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110379/#review32459 ----------------------------------------------------------- This looks a bit fragile, what if i actually name my file "Untitled"? There's no internal way of knowing if the file has been saved? - Albert Astals Cid On May 10, 2013, 1:45 a.m., Peter Hedlund wrote: _______________________________________________ kde-edu mailing list kde-edu&lt; at &gt;mail.kde.org https://mail.kde.org/mailman/listinfo/kde-edu </pre> Albert Astals Cid 2013-05-13T22:16:17 http://permalink.gmane.org/gmane.comp.kde.education/7288 <pre> what do you mean mockups of the cooperative game or of the switching part? Personally I do not like the Idea of two different application. The teacher won't use it at the end That pretty much what I had in mind </pre> Marco Calignano 2013-05-13T19:23:47 http://permalink.gmane.org/gmane.comp.kde.education/7287 <pre>On Mon, May 13, 2013 at 10:38 AM, Marco Calignano &lt;marco.calignano&lt; at &gt;gmail.com Hi Marco! Maybe you can provide some mockups to get it discussed? Technically, I think that the best for this would be to have a different binary called pairs-collaborative that the teachers can call and know what the kids will be playing beforehand. About the switch, I think that we can just add a QML overlay with the name/picture that the kind can click/press and disappears. Aleix _______________________________________________ kde-edu mailing list kde-edu&lt; at &gt;mail.kde.org https://mail.kde.org/mailman/listinfo/kde-edu </pre> Aleix Pol 2013-05-13T14:39:28 http://permalink.gmane.org/gmane.comp.kde.education/7286 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110414/#review32445 ----------------------------------------------------------- src/mainwindow.h &lt;http://git.reviewboard.kde.org/r/110414/#comment24126&gt; You don't initialize members here. = 0 goes to the constructor. Also do we really ned these attributes? src/mainwindow.cpp &lt;http://git.reviewboard.kde.org/r/110414/#comment24125&gt; Unrelated to this patch. Also I'm unsure we want that. src/mainwindow.cpp &lt;http://git.reviewboard.kde.org/r/110414/#comment24124&gt; You should _never_ use exit(0). I'm unsure what you're trying to do anyway. src/mainwindow.cpp &lt;http://git.reviewboard.kde.org/r/110414/#comment24123&gt; We have API for painting the contents of 2D and 3D graphs into an image. Maybe you should use that. src/mainwindow.cpp &lt;http://git.reviewboard.kde.org/r/110414/#comment24121&gt; Use QByteArray, not QSt</pre> Aleix Pol Gonzalez 2013-05-13T14:18:42 http://permalink.gmane.org/gmane.comp.kde.education/7285 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110414/ ----------------------------------------------------------- Review request for KDE Edu, Aleix Pol Gonzalez and Percy Camilo Triveño Aucahuasi. Description ------- As we discussed the outline for khipu-specific file , I have implemented this feature. The attached diff contains the feature for save Action in Khipu. I have used qjson for file format. Diffs ----- CMakeLists.txt f7dc583 src/CMakeLists.txt 0a50c54 src/datastore.h a1276a7 src/datastore.cpp 616e0cc src/mainwindow.h 1f059f8 src/mainwindow.cpp 9d6e010 src/plotseditor.cpp 106cdf5 Diff: http://git.reviewboard.kde.org/r/110414/diff/ Testing ------- Done..! worked perfect for any situtation I have come across. ! Thanks, Punit Mehta _______________________________________________ kde-edu mailing list kde-edu&lt; at &gt;mail.kde.org https://mail.kde.org/mailman/listinfo/kd</pre> Punit Mehta 2013-05-13T13:55:33 http://permalink.gmane.org/gmane.comp.kde.education/7284 <pre> 1) The score is not for each player but only for the group so we need to change the left tab where the players are. 2) We need also a way to tell the kids that they need to switch places. I thought like a popup windows where the avatar and the name appears. 3) Therefore the kids have to have different avatar. 4) I think also we need some kind of confirmation mechanism to select collaborative games. Like a double click or code typing of some kind: this would avoid kids playing at home switching into collaborative mode and have any kind of "problems" 5) we should also give the possibility to same the session game with players scores etc. This make sense since in this kind of mode there will be more than one game. Cheers Marco </pre> Marco Calignano 2013-05-13T08:38:05 Search the mailing list at Gmane query http://search.gmane.org/?group=$group=gmane.comp.kde.education