http://permalink.gmane.org/gmane.comp.kde.devel.quanta hourly 1 1901-01-01T00:00+00:00 http://gmane.org/img/gmane-25t.png http://gmane.org http://permalink.gmane.org/gmane.comp.kde.devel.quanta/9041 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104595/#review13232 ----------------------------------------------------------- looks good, but please adapt to moved repositories. (now kdev-xdebug and kdev-executebrowser repositories) plugins/executebrowser/browserappjob.cpp &lt;http://git.reviewboard.kde.org/r/104595/#comment10355&gt; makes absolutely sense, but please commit separately. plugins/executebrowser/iexecutebrowserplugin.h &lt;http://git.reviewboard.kde.org/r/104595/#comment10354&gt; hm, I don't like this overriding of url, the url is *the* thing of the launch - and you can override it. what about a QMap&lt;QString, QString&gt; queryItems parameter? (or just QString?) - Niko Sams On April 13, 2012, 11:29 p.m., Dominik Schmidt wrote: _______________________________________________ quanta-devel mailing list quanta-devel&lt; at &gt;kde.org https://mail.kde.org/mailman/listinfo/quanta-devel </pre> Niko Sams 2012-05-01T17:34:42 http://permalink.gmane.org/gmane.comp.kde.devel.quanta/9040 <pre> Sure. How about .. "// if you provide a valid url as second parameter that one is opened instead of the url stored in the launch configuration // e.g. this is used in xdebug plugin to add additional GET parameters to the configured url" ? I'll check, sounds reasonable. Good hint! It doesn't do that so far, but it perfectly makes sense: a) the settings are already stored in an executebrowserplugin instance b) you'd need to implement fallback code in the xdebug plugin which is already inside the EBP c) if not for this, what is the EBP good for then? ;) - Dominik ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104595/#review12488 ----------------------------------------------------------- On April 13, 2012, 11:29 p.m., Dominik Schmidt wrote: _______________________________________________ quanta-devel mailing list quanta-devel&lt; at &gt;kde.org https://mail.kde.org/mailman/listinfo/quanta-devel </pre> Dominik Schmidt 2012-04-17T00:01:48 http://permalink.gmane.org/gmane.comp.kde.devel.quanta/9039 <pre> yeah just add the X-KDevelop-Required thingy to the *.desktop file of this plugin yeah ok - Milian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104595/#review12488 ----------------------------------------------------------- On April 13, 2012, 11:29 p.m., Dominik Schmidt wrote: _______________________________________________ quanta-devel mailing list quanta-devel&lt; at &gt;kde.org https://mail.kde.org/mailman/listinfo/quanta-devel </pre> Milian Wolff 2012-04-17T12:42:43 http://permalink.gmane.org/gmane.comp.kde.devel.quanta/9038 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104595/#review12488 ----------------------------------------------------------- debuggers/xdebug/debugjob.cpp &lt;http://git.reviewboard.kde.org/r/104595/#comment9799&gt; this is unstable, it will crash as soon as the executebrowserplugin is disabled, or is that a requirement of the xdebug plugin? hm would make sense - just make sure that this is so in the *.desktop file please plugins/executebrowser/browserappjob.cpp &lt;http://git.reviewboard.kde.org/r/104595/#comment9802&gt; is it ok to emit the result directly? or should one wait for the "started" signal (that should exist afaik)? that would also allow one to properly handle error cases, i.e. if. m_browser points to a non-existing browser-app or if something else goes wrong, or? plugins/executebrowser/iexecutebrowserplugin.h &lt;http://git.reviewboard.kde.org/r/104595/#comment9801&gt; I don't unde</pre> Milian Wolff 2012-04-15T20:46:57 http://permalink.gmane.org/gmane.comp.kde.devel.quanta/9029 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103388/#review9220 ----------------------------------------------------------- Uhm sorry, but when I download the diff it is still not in the "format-patch" format. Just look at the downloaded file, it directly starts with the patch and gives no information about you, nor any commit message or such. please try again - Milian Wolff On Dec. 15, 2011, 1:08 a.m., Florian Zumkeller-Quast wrote: _______________________________________________ quanta-devel mailing list quanta-devel&lt; at &gt;kde.org https://mail.kde.org/mailman/listinfo/quanta-devel </pre> Milian Wolff 2011-12-23T20:17:48 http://permalink.gmane.org/gmane.comp.kde.devel.quanta/9028 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103388/#review9219 ----------------------------------------------------------- Uhm sorry, but when I download the diff it is still not in the "format-patch" format. Just look at the downloaded file, it directly starts with the patch and gives no information about you, nor any commit message or such. please try again - Milian Wolff On Dec. 15, 2011, 1:08 a.m., Florian Zumkeller-Quast wrote: _______________________________________________ quanta-devel mailing list quanta-devel&lt; at &gt;kde.org https://mail.kde.org/mailman/listinfo/quanta-devel </pre> Milian Wolff 2011-12-23T20:17:42 http://permalink.gmane.org/gmane.comp.kde.devel.quanta/9027 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103386/#review9218 ----------------------------------------------------------- Uhm sorry, but when I download the diff it is still not in the "format-patch" format. Just look at the downloaded file, it directly starts with the patch and gives no information about you, nor any commit message or such. please try again - Milian Wolff On Dec. 15, 2011, 1:07 a.m., Florian Zumkeller-Quast wrote: _______________________________________________ quanta-devel mailing list quanta-devel&lt; at &gt;kde.org https://mail.kde.org/mailman/listinfo/quanta-devel </pre> Milian Wolff 2011-12-23T20:17:29 http://permalink.gmane.org/gmane.comp.kde.devel.quanta/9026 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103388/ ----------------------------------------------------------- (Updated Dec. 15, 2011, 1:08 a.m.) Review request for KDevelop and Quanta. Changes ------- Patch created by git format-patch as requested Description ------- Added some more php example code to show the impact of the formatter if applied Diffs (updated) ----- plugins/phpformatter/formatterplugin.cpp f1ca6fd Diff: http://git.reviewboard.kde.org/r/103388/diff/diff Testing ------- Thanks, Florian Zumkeller-Quast _______________________________________________ quanta-devel mailing list quanta-devel&lt; at &gt;kde.org https://mail.kde.org/mailman/listinfo/quanta-devel </pre> Florian Zumkeller-Quast 2011-12-15T01:08:52 http://permalink.gmane.org/gmane.comp.kde.devel.quanta/9025 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103386/ ----------------------------------------------------------- (Updated Dec. 15, 2011, 1:07 a.m.) Review request for KDevelop and Quanta. Changes ------- Patch created by git format-patch as requested Description ------- Since the last changes of ISourceFormatter from KDevPlatform Quanta was broken and did not compile. This patch fixes the compiling issues by changing phpformatterplugin and xmlformatterplugin to the new interface of ISourceFormatter. During the testing it looked to me that there are two different options storing the indentation value for a formatter: "INDENT" and "indent_size". Because only the latter contained a non-zero value, i changed the behaviour to use the latter one. Diffs (updated) ----- languages/xml/formatter/formatterplugin.h dbe183a languages/xml/formatter/formatterplugin.cpp 4e62a1e plugins/phpformatt</pre> Florian Zumkeller-Quast 2011-12-15T01:07:55 http://permalink.gmane.org/gmane.comp.kde.devel.quanta/9024 <pre> as I said on irc: please send the patch as created by "git format-patch" thanks </pre> Milian Wolff 2011-12-13T17:55:39 http://permalink.gmane.org/gmane.comp.kde.devel.quanta/9023 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103386/#review8907 ----------------------------------------------------------- Ship it! Ship It! - Milian Wolff On Dec. 11, 2011, 7:09 p.m., Florian Zumkeller-Quast wrote: _______________________________________________ quanta-devel mailing list quanta-devel&lt; at &gt;kde.org https://mail.kde.org/mailman/listinfo/quanta-devel </pre> Milian Wolff 2011-12-13T11:43:53 http://permalink.gmane.org/gmane.comp.kde.devel.quanta/9022 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103388/#review8906 ----------------------------------------------------------- Ship it! Ship It! - Milian Wolff On Dec. 11, 2011, 6:11 p.m., Florian Zumkeller-Quast wrote: _______________________________________________ quanta-devel mailing list quanta-devel&lt; at &gt;kde.org https://mail.kde.org/mailman/listinfo/quanta-devel </pre> Milian Wolff 2011-12-13T11:43:38 http://permalink.gmane.org/gmane.comp.kde.devel.quanta/9018 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103106/ ----------------------------------------------------------- (Updated Nov. 10, 2011, 3:42 p.m.) Review request for KDevelop and Quanta. Changes ------- The patch created by git format-patch. I fixed the style issues. Description ------- Some changes on the Interface of ISourceFormatter from the kdevplatform project broke compiling of quanta. This Patch fixes the interface of the SourceFormatter derived classes and some calls to these methods with the new KUrl parameter inserted. Diffs ----- languages/xml/formatter/formatterplugin.h e8799f1 languages/xml/formatter/formatterplugin.cpp 4b04725 languages/xml/formatter/sgmlformatter.cpp 4a99d79 languages/xml/language/completion/sgmlcodecompletionmodel.cpp 803760f plugins/phpformatter/formatterplugin.h 8b462bc plugins/phpformatter/formatterplugin.cpp 761d635 Diff: http://git.</pre> Florian Zumkeller-Quast 2011-11-10T15:42:26 http://permalink.gmane.org/gmane.comp.kde.devel.quanta/9017 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103106/ ----------------------------------------------------------- Review request for KDevelop and Quanta. Description ------- Some changes on the Interface of ISourceFormatter from the kdevplatform project broke compiling of quanta. This Patch fixes the interface of the SourceFormatter derived classes and some calls to these methods with the new KUrl parameter inserted. Diffs ----- languages/xml/formatter/formatterplugin.h e8799f1 languages/xml/formatter/formatterplugin.cpp 4b04725 languages/xml/formatter/sgmlformatter.cpp 4a99d79 languages/xml/language/completion/sgmlcodecompletionmodel.cpp 803760f plugins/phpformatter/formatterplugin.h 8b462bc plugins/phpformatter/formatterplugin.cpp 761d635 Diff: http://git.reviewboard.kde.org/r/103106/diff/diff Testing ------- Quanta compiles fine with that patch. Thanks, Florian Zumkel</pre> Florian Zumkeller-Quast 2011-11-10T12:05:26 http://permalink.gmane.org/gmane.comp.kde.devel.quanta/9015 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103106/#review8100 ----------------------------------------------------------- Ship it! commit is fine besides a few style issues, put the &amp;,* always adjacent to the typename for consistency please. if you have commit rights, please fix this before pushing. otherwise send me this patch as created by "git format-patch" - if possible with the style issue fixed. otherwise I'll do that. thanks languages/xml/formatter/formatterplugin.cpp &lt;http://git.reviewboard.kde.org/r/103106/#comment6962&gt; please put the &amp; adjacent to the typename for consistency languages/xml/formatter/formatterplugin.cpp &lt;http://git.reviewboard.kde.org/r/103106/#comment6963&gt; also here, &amp; adjacent to the typename please plugins/phpformatter/formatterplugin.h &lt;http://git.reviewboard.kde.org/r/103106/#comment6964&gt; again, please &amp; adjacent to typename plugins/php</pre> Milian Wolff 2011-11-10T14:18:22 http://permalink.gmane.org/gmane.comp.kde.devel.quanta/9014 <pre>Hi, see this (over a year old) blog post from milian: http://milianw.de/blog/quanta-gsoc-midterm-evaluation since then not much happened. Unfortunaetly development stalled. but feel free to join the team and continue hacking! If you need more information just ask here or on kdevelop-devel :D Niko On Fri, Nov 4, 2011 at 15:19, Dan Holliday &lt;dan&lt; at &gt;etrixs.co.uk&gt; wrote: </pre> Niko Sams 2011-11-04T14:31:48 http://permalink.gmane.org/gmane.comp.kde.devel.quanta/9013 <pre>Hi,  I've just joined as I'm keen to work on quanta for it's next release. Not sure if I'm being a little slow, but could someone tell me where the latest repository of code is kept so that I can start looking into it please.   Cheers Guys. _______________________________________________ quanta-devel mailing list quanta-devel&lt; at &gt;kde.org https://mail.kde.org/mailman/listinfo/quanta-devel </pre> Dan Holliday 2011-11-04T14:19:04 http://permalink.gmane.org/gmane.comp.kde.devel.quanta/9012 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102456/#review6097 ----------------------------------------------------------- Ship it! looks good to me - Milian On Aug. 27, 2011, 1:48 p.m., Florian Zumkeller-Quast wrote: _______________________________________________ quanta-devel mailing list quanta-devel&lt; at &gt;kde.org https://mail.kde.org/mailman/listinfo/quanta-devel </pre> Milian Wolff 2011-08-28T12:54:55 http://permalink.gmane.org/gmane.comp.kde.devel.quanta/9010 <pre>Robert Marmorstein, 26.03.2011: Hi there. Thanks. I was still trying to push to gitorious which is why this fix among others was not available yet. Now I know the reason ;-) I'll take care to set this up. Please send any further patches to this list in the meantime - or - just commit them if you are confident. I can also post- review them. Bye </pre> Milian Wolff 2011-03-27T21:51:22 http://permalink.gmane.org/gmane.comp.kde.devel.quanta/9009 <pre>Hello all, I just pushed a one line patch that removes an include that was never useful (included file was empty) and causes compilation to break against latest kdevplatform (which removed the empty file). I couldn't find any way to review the patch, so I just went ahead and pushed. Please let me know if this is not acceptable and I will revert it. It would be nice if quanta were on reviewboard, but unless I'm blind, there doesn't seem to be an entry for it in the repository list. Thanks, Robert ---------------------------------------------------------------- This message was sent using IMP, the Internet Messaging Program. </pre> Robert Marmorstein 2011-03-26T07:03:57 http://permalink.gmane.org/gmane.comp.kde.devel.quanta/9008 <pre>Paulo Moura Guedes, 22.01.2011: no, Quanta 4 will build on top of KDevelop/KDevplatform. Anyways, since I have no time right now and noone else is spending time on it, it's more or less sleeping right now sadly... Bye </pre> Milian Wolff 2011-01-22T16:12:25 Search the mailing list at Gmane query http://search.gmane.org/?group=$group=gmane.comp.kde.devel.quanta