http://permalink.gmane.org/gmane.comp.kde.devel.kwin hourly 1 1901-01-01T00:00+00:00 http://gmane.org/img/gmane-25t.png http://gmane.org http://permalink.gmane.org/gmane.comp.kde.devel.kwin/41883 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110610/#review33032 ----------------------------------------------------------- Pixel copying was not what I had in mind and it should not be required. -&gt; I'll play on it this evening. - Thomas Lübking On May 23, 2013, 10:51 a.m., Martin Gräßlin wrote: _______________________________________________ kwin mailing list kwin&lt; at &gt;kde.org https://mail.kde.org/mailman/listinfo/kwin </pre> Thomas Lübking 2013-05-23T12:17:05 http://permalink.gmane.org/gmane.comp.kde.devel.kwin/41882 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110610/ ----------------------------------------------------------- Review request for kwin, Thomas Lübking and Ralf Jung. Description ------- The OpenGLBackend gains support for buffer age extensions. A backend can indicate that it supports buffer age and set the age of the current back buffer once it swapped buffers. If the backend supports buffer age it tracks the damage of the last two frames to support double and triple buffered setups. This means n-buffering is not supported. The SceneOpenGL makes use of the buffer age implementation if present. In extendPaintRegion the region is extended to the displayRegion if the current buffer age is 0 which indicates that a full repaint is needed. If the buffer has a supported age (2 or 3) the Scene copies back the previously damaged areas similar to the CopyFrontBuffer strategy. Just instead of co</pre> Martin Gräßlin 2013-05-23T10:51:21 http://permalink.gmane.org/gmane.comp.kde.devel.kwin/41881 <pre> oh that's fine - I'm seriously considering using colibri as a new reference stress test application - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110577/#review33011 ----------------------------------------------------------- On May 21, 2013, 2:59 p.m., Martin Gräßlin wrote: _______________________________________________ kwin mailing list kwin&lt; at &gt;kde.org https://mail.kde.org/mailman/listinfo/kwin </pre> Martin Gräßlin 2013-05-23T09:01:00 http://permalink.gmane.org/gmane.comp.kde.devel.kwin/41880 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110577/#review33011 ----------------------------------------------------------- Can't comment on the code, but I confirm it fixes the bug for me. Thanks a lot, Martin! (Sorry for being evil :)) - Aurélien Gâteau On May 21, 2013, 2:59 p.m., Martin Gräßlin wrote: _______________________________________________ kwin mailing list kwin&lt; at &gt;kde.org https://mail.kde.org/mailman/listinfo/kwin </pre> Aurélien Gâteau 2013-05-23T08:36:53 http://permalink.gmane.org/gmane.comp.kde.devel.kwin/41879 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110606/ ----------------------------------------------------------- Review request for kwin and Fredrik Höglund. Description ------- Use textureOffset in Lanczos Shader 1.40 variant According to Ian Romanick using textureOffset should be much faster on Sandy- and Ivybridge [1]. [1] https://bugs.freedesktop.org/show_bug.cgi?id=61554#c2 Diffs ----- kwin/lanczosfilter.h 12a844ee8cdbf7ac821bac2f464ef008498060ff kwin/lanczosfilter.cpp 4917d592a97f47187f7e2cebece62c03575b6b03 kwin/shaders/1.40/lanczos-fragment.glsl 0852ea10280136e5b8940d3a4335ae856e7642c1 Diff: http://git.reviewboard.kde.org/r/110606/diff/ Testing ------- Tested with both 1.10 and 1.40 on an IvyBridge with Mesa 9.2. Thanks, Martin Gräßlin _______________________________________________ kwin mailing list kwin&lt; at &gt;kde.org https://mail.kde.org/mailman/listinfo/kwin </pre> Martin Gräßlin 2013-05-23T08:36:15 http://permalink.gmane.org/gmane.comp.kde.devel.kwin/41878 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110574/ ----------------------------------------------------------- (Updated May 23, 2013, 7:49 a.m.) Status ------ This change has been marked as submitted. Review request for kwin. Description ------- GLSL 1.40 shader for lookingglass effect Diffs ----- kwin/effects/lookingglass/CMakeLists.txt 45a4d19f86c9331195a6a0f60f1d67778d3d312a kwin/effects/lookingglass/data/1.10/lookingglass.frag PRE-CREATION kwin/effects/lookingglass/data/1.40/lookingglass.frag PRE-CREATION kwin/effects/lookingglass/data/lookingglass.frag 48edfb93dbb9176fb9d51b4c2dad9f9c2b86e0c2 kwin/effects/lookingglass/lookingglass.cpp c5e77e6cfd3b1707ecc917a4eb990eccf5d1b996 Diff: http://git.reviewboard.kde.org/r/110574/diff/ Testing ------- Thanks, Martin Gräßlin _______________________________________________ kwin mailing list kwin&lt; at &gt;kde.org https://mail.kde.</pre> Commit Hook 2013-05-23T07:49:31 http://permalink.gmane.org/gmane.comp.kde.devel.kwin/41877 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110570/ ----------------------------------------------------------- (Updated May 23, 2013, 7:49 a.m.) Status ------ This change has been marked as submitted. Review request for kwin. Description ------- Use generic fragment shader for Cylinder and Sphere Shaders were broken. Issue mentioned in the TODO seems to no longer be present (at least not on the system I used for testing). Diffs ----- kwin/effects/cube/CMakeLists.txt d30612a617ceaa0ebefb961493aee5749e9cc3d2 kwin/effects/cube/cube.cpp 02fb4a4f5e57b2ecfdd07125213308be5e324519 kwin/effects/cube/data/cylinder.frag d7594c317d635afbf1387c6d3155b37eca98ab35 Diff: http://git.reviewboard.kde.org/r/110570/diff/ Testing ------- Thanks, Martin Gräßlin _______________________________________________ kwin mailing list kwin&lt; at &gt;kde.org https://mail.kde.org/mailman/listinfo/kwin </pre> Commit Hook 2013-05-23T07:49:29 http://permalink.gmane.org/gmane.comp.kde.devel.kwin/41876 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110571/#review33007 ----------------------------------------------------------- This review has been submitted with commit e0e46d7525107cca47d403e76362633c4c582f7e by Martin Gräßlin to branch master. - Commit Hook On May 21, 2013, 8:20 a.m., Martin Gräßlin wrote: _______________________________________________ kwin mailing list kwin&lt; at &gt;kde.org https://mail.kde.org/mailman/listinfo/kwin </pre> Commit Hook 2013-05-23T07:49:21 http://permalink.gmane.org/gmane.comp.kde.devel.kwin/41875 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110574/#review33008 ----------------------------------------------------------- This review has been submitted with commit 71d3ce0ec20853af550cccbc7ccb1c82ab0984d2 by Martin Gräßlin to branch master. - Commit Hook On May 21, 2013, 8:56 a.m., Martin Gräßlin wrote: _______________________________________________ kwin mailing list kwin&lt; at &gt;kde.org https://mail.kde.org/mailman/listinfo/kwin </pre> Commit Hook 2013-05-23T07:49:22 http://permalink.gmane.org/gmane.comp.kde.devel.kwin/41874 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110570/#review33006 ----------------------------------------------------------- This review has been submitted with commit f0db8c4a3228cbb17bcc39c92fcd4be23433856c by Martin Gräßlin to branch master. - Commit Hook On May 21, 2013, 6:45 a.m., Martin Gräßlin wrote: _______________________________________________ kwin mailing list kwin&lt; at &gt;kde.org https://mail.kde.org/mailman/listinfo/kwin </pre> Commit Hook 2013-05-23T07:49:18 http://permalink.gmane.org/gmane.comp.kde.devel.kwin/41873 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110572/#review33005 ----------------------------------------------------------- This review has been submitted with commit ea1501e54e97dc8b9d67c0427c9ab8b5580b6f60 by Martin Gräßlin to branch master. - Commit Hook On May 21, 2013, 8:34 a.m., Martin Gräßlin wrote: _______________________________________________ kwin mailing list kwin&lt; at &gt;kde.org https://mail.kde.org/mailman/listinfo/kwin </pre> Commit Hook 2013-05-23T07:49:15 http://permalink.gmane.org/gmane.comp.kde.devel.kwin/41872 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110573/ ----------------------------------------------------------- (Updated May 23, 2013, 7:36 a.m.) Status ------ This change has been marked as submitted. Review request for kwin. Description ------- GLSL 1.40 shader for invert effect Diffs ----- kwin/effects/invert/CMakeLists.txt 878a68ea39281f3f2474bbdea3b662dd359bb37c kwin/effects/invert/data/1.10/invert.frag PRE-CREATION kwin/effects/invert/data/1.40/invert.frag PRE-CREATION kwin/effects/invert/data/invert.frag 3cf809db529bd300f05230407fe017ba94fcb161 kwin/effects/invert/invert.cpp 487abbd8c40c516996c4c07150a5d00845ba3503 Diff: http://git.reviewboard.kde.org/r/110573/diff/ Testing ------- Thanks, Martin Gräßlin _______________________________________________ kwin mailing list kwin&lt; at &gt;kde.org https://mail.kde.org/mailman/listinfo/kwin </pre> Commit Hook 2013-05-23T07:36:25 http://permalink.gmane.org/gmane.comp.kde.devel.kwin/41871 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110573/#review33004 ----------------------------------------------------------- This review has been submitted with commit ab49f653a15ce67ebd36b2b798761e81c560c5c4 by Martin Gräßlin to branch master. - Commit Hook On May 21, 2013, 8:40 a.m., Martin Gräßlin wrote: _______________________________________________ kwin mailing list kwin&lt; at &gt;kde.org https://mail.kde.org/mailman/listinfo/kwin </pre> Commit Hook 2013-05-23T07:36:24 http://permalink.gmane.org/gmane.comp.kde.devel.kwin/41870 <pre> yeah we did, I'll remove it in another commit (before the moving around of the shaders). - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110573/#review32995 ----------------------------------------------------------- On May 21, 2013, 10:40 a.m., Martin Gräßlin wrote: _______________________________________________ kwin mailing list kwin&lt; at &gt;kde.org https://mail.kde.org/mailman/listinfo/kwin </pre> Martin Gräßlin 2013-05-23T07:12:34 http://permalink.gmane.org/gmane.comp.kde.devel.kwin/41869 <pre> thanks for the hint. Commit embargo and I'm looking forward to the merge conflict fun ;-) Btw. maybe merge in the optimization branch to expose it to more testing? - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110578/#review32976 ----------------------------------------------------------- On May 22, 2013, 4:13 p.m., Martin Gräßlin wrote: _______________________________________________ kwin mailing list kwin&lt; at &gt;kde.org https://mail.kde.org/mailman/listinfo/kwin </pre> Martin Gräßlin 2013-05-23T07:09:39 http://permalink.gmane.org/gmane.comp.kde.devel.kwin/41868 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110590/ ----------------------------------------------------------- (Updated May 23, 2013, 7:07 a.m.) Status ------ This change has been marked as submitted. Review request for kwin and Fredrik Höglund. Description ------- Use GLSL 1.40 shaders as GLSL 300 es shaders In case OpenGL ES 3 is provided by the driver we can use the GLSL 1.40 shaders as GLSL 300 ES shaders. The #version declarative is rewritten in such a case. Diffs ----- kwin/libkwineffects/kwinglutils.cpp 02a8b3611956218163a5241de177b9f9316ef2f1 Diff: http://git.reviewboard.kde.org/r/110590/diff/ Testing ------- Thanks, Martin Gräßlin _______________________________________________ kwin mailing list kwin&lt; at &gt;kde.org https://mail.kde.org/mailman/listinfo/kwin </pre> Commit Hook 2013-05-23T07:07:36 http://permalink.gmane.org/gmane.comp.kde.devel.kwin/41867 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110590/#review33001 ----------------------------------------------------------- This review has been submitted with commit 17d43fa42d1a9e5a32105f0043f8d61e73455a21 by Martin Gräßlin to branch master. - Commit Hook On May 22, 2013, 7:57 a.m., Martin Gräßlin wrote: _______________________________________________ kwin mailing list kwin&lt; at &gt;kde.org https://mail.kde.org/mailman/listinfo/kwin </pre> Commit Hook 2013-05-23T07:07:33 http://permalink.gmane.org/gmane.comp.kde.devel.kwin/41866 <pre> yeah, except the blur shader: "noperspective" seems to not be part of GLSL 300 ES - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110590/#review32974 ----------------------------------------------------------- On May 22, 2013, 9:57 a.m., Martin Gräßlin wrote: _______________________________________________ kwin mailing list kwin&lt; at &gt;kde.org https://mail.kde.org/mailman/listinfo/kwin </pre> Martin Gräßlin 2013-05-23T07:01:47 http://permalink.gmane.org/gmane.comp.kde.devel.kwin/41865 <pre> Expanding a bit on that thought, getting the size in the vertex shader, and passing it to the fragment shader in a varying with a flat interpolation qualifier is probably faster than using textureSize() in the fragment shader. I would measure it though. - Fredrik ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110574/#review32998 ----------------------------------------------------------- On May 21, 2013, 8:56 a.m., Martin Gräßlin wrote: _______________________________________________ kwin mailing list kwin&lt; at &gt;kde.org https://mail.kde.org/mailman/listinfo/kwin </pre> Fredrik Höglund 2013-05-22T22:40:06 http://permalink.gmane.org/gmane.comp.kde.devel.kwin/41864 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110574/#review32998 ----------------------------------------------------------- Ship it! kwin/effects/lookingglass/data/1.40/lookingglass.frag &lt;http://git.reviewboard.kde.org/r/110574/#comment24426&gt; GLSL 1.40 has a textureSize(). Using a uniform might be faster though. - Fredrik Höglund On May 21, 2013, 8:56 a.m., Martin Gräßlin wrote: _______________________________________________ kwin mailing list kwin&lt; at &gt;kde.org https://mail.kde.org/mailman/listinfo/kwin </pre> Fredrik Höglund 2013-05-22T22:30:09 http://permalink.gmane.org/gmane.comp.kde.devel.kwin/41863 <pre> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110571/#review32996 ----------------------------------------------------------- Ship it! Ship It! - Fredrik Höglund On May 21, 2013, 8:20 a.m., Martin Gräßlin wrote: _______________________________________________ kwin mailing list kwin&lt; at &gt;kde.org https://mail.kde.org/mailman/listinfo/kwin </pre> Fredrik Höglund 2013-05-22T22:13:06 Search the mailing list at Gmane query http://search.gmane.org/?group=$group=gmane.comp.kde.devel.kwin