<?xml version="1.0" encoding="UTF-8"?>
<rdf:RDF xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#" xmlns="http://purl.org/rss/1.0/" xmlns:taxo="http://purl.org/rss/1.0/modules/taxonomy/" xmlns:dc="http://purl.org/dc/elements/1.1/" xmlns:syn="http://purl.org/rss/1.0/modules/syndication/" xmlns:admin="http://webns.net/mvcb/">
  <channel rdf:about="http://permalink.gmane.org/gmane.comp.kde.devel.koffice">
    <title>gmane.comp.kde.devel.koffice</title>
    <link>http://permalink.gmane.org/gmane.comp.kde.devel.koffice</link>
    <description/>
    <syn:updatePeriod>hourly</syn:updatePeriod>
    <syn:updateFrequency>1</syn:updateFrequency>
    <syn:updateBase>1901-01-01T00:00+00:00</syn:updateBase>
    <items>
      <rdf:Seq>
        <rdf:li rdf:resource="http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23533"/>
        <rdf:li rdf:resource="http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23532"/>
        <rdf:li rdf:resource="http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23531"/>
        <rdf:li rdf:resource="http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23530"/>
        <rdf:li rdf:resource="http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23529"/>
        <rdf:li rdf:resource="http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23528"/>
        <rdf:li rdf:resource="http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23527"/>
        <rdf:li rdf:resource="http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23526"/>
        <rdf:li rdf:resource="http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23525"/>
        <rdf:li rdf:resource="http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23524"/>
        <rdf:li rdf:resource="http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23523"/>
        <rdf:li rdf:resource="http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23517"/>
        <rdf:li rdf:resource="http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23515"/>
        <rdf:li rdf:resource="http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23514"/>
        <rdf:li rdf:resource="http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23513"/>
        <rdf:li rdf:resource="http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23512"/>
        <rdf:li rdf:resource="http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23511"/>
        <rdf:li rdf:resource="http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23510"/>
        <rdf:li rdf:resource="http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23509"/>
        <rdf:li rdf:resource="http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23508"/>
      </rdf:Seq>
    </items>
    <image rdf:resource="http://gmane.org/img/gmane-25t.png"/>
    <textinput rdf:resource=""/>
  </channel>
  <image rdf:about="http://gmane.org/img/gmane-25t.png">
    <title>Gmane</title>
    <url>http://gmane.org/img/gmane-25t.png</url>
    <link>http://gmane.org</link>
  </image>
  <item rdf:about="http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23533">
    <title>Re: Review Request 104341: Removed unused code from kword/part/KWApplicationConfig.cpp</title>
    <link>http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23533</link>
    <description>&lt;pre&gt;
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104341/
-----------------------------------------------------------

(Updated April 5, 2013, 8:03 p.m.)


Status
------

This change has been marked as submitted.


Review request for KOffice and Robert Mathias Marmorstein.


Description
-------

Removed unused code from kword/part/KWApplicationConfig.cpp
Undo variable with related code and comments.
Spelling variable with related code and comments.


Diffs
-----

  kword/part/KWApplicationConfig.cpp 00e2bcb 

Diff: http://git.reviewboard.kde.org/r/104341/diff/


Testing
-------

built, installed, and runs


Thanks,

Chris Smith

_______________________________________________
koffice-devel mailing list
koffice-devel&amp;lt; at &amp;gt;kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
&lt;/pre&gt;</description>
    <dc:creator>Commit Hook</dc:creator>
    <dc:date>2013-04-05T20:03:22</dc:date>
  </item>
  <item rdf:about="http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23532">
    <title>Re: Review Request 104341: Removed unused code from kword/part/KWApplicationConfig.cpp</title>
    <link>http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23532</link>
    <description>&lt;pre&gt;
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104341/#review30516
-----------------------------------------------------------


This review has been submitted with commit 0060d473c1171476c5d7c11e9c2b0ff89b0c80e0 by Albert Astals Cid on behalf of Chris Smith to branch master.

- Commit Hook


On March 18, 2012, 10:41 p.m., Chris Smith wrote:

_______________________________________________
koffice-devel mailing list
koffice-devel&amp;lt; at &amp;gt;kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
&lt;/pre&gt;</description>
    <dc:creator>Commit Hook</dc:creator>
    <dc:date>2013-04-05T20:03:18</dc:date>
  </item>
  <item rdf:about="http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23531">
    <title>Re: Review Request 104252: Removed unused code from "kword/part/KWApplicationConfig.cpp" getting rid of make warnings.</title>
    <link>http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23531</link>
    <description>&lt;pre&gt;
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104252/
-----------------------------------------------------------

(Updated April 5, 2013, 8:03 p.m.)


Status
------

This change has been discarded.


Review request for KOffice.


Description
-------

Removed unused code from "kword/part/KWApplicationConfig.cpp" getting rid of make warnings.


Diffs
-----

  kword/part/KWApplicationConfig.cpp 00e2bcb 

Diff: http://git.reviewboard.kde.org/r/104252/diff/


Testing
-------


Thanks,

Chris Smith

_______________________________________________
koffice-devel mailing list
koffice-devel&amp;lt; at &amp;gt;kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
&lt;/pre&gt;</description>
    <dc:creator>Albert Astals Cid</dc:creator>
    <dc:date>2013-04-05T20:03:19</dc:date>
  </item>
  <item rdf:about="http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23530">
    <title>Re: Review Request 104252: Removed unused code from "kword/part/KWApplicationConfig.cpp" getting rid of make warnings.</title>
    <link>http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23530</link>
    <description>&lt;pre&gt;
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104252/#review26897
-----------------------------------------------------------


I see this has a ship it but marked as uncommited. Was it commited and you forgot to close the request or is still uncommited?

- Albert Astals Cid


On March 13, 2012, 4:21 a.m., Chris Smith wrote:

_______________________________________________
koffice-devel mailing list
koffice-devel&amp;lt; at &amp;gt;kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
&lt;/pre&gt;</description>
    <dc:creator>Albert Astals Cid</dc:creator>
    <dc:date>2013-02-07T21:25:31</dc:date>
  </item>
  <item rdf:about="http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23529">
    <title>Re: Review Request 104341: Removed unused code from kword/part/KWApplicationConfig.cpp</title>
    <link>http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23529</link>
    <description>&lt;pre&gt;
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104341/#review26892
-----------------------------------------------------------


I see this has a ship it but marked as uncommited. Was it commited and you forgot to close the request or is still uncommited?

- Albert Astals Cid


On March 18, 2012, 10:41 p.m., Chris Smith wrote:

_______________________________________________
koffice-devel mailing list
koffice-devel&amp;lt; at &amp;gt;kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
&lt;/pre&gt;</description>
    <dc:creator>Albert Astals Cid</dc:creator>
    <dc:date>2013-02-07T21:23:00</dc:date>
  </item>
  <item rdf:about="http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23528">
    <title>koffice website defaced?</title>
    <link>http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23528</link>
    <description>&lt;pre&gt;Hi.

on http://www.koffice.org all I see is a dummy
I like white empty spaces
written on the page.

It seems to me all *.koffice.org (also the wiki) have been defaced.

Is the situation known to you?

&lt;/pre&gt;</description>
    <dc:creator>Vito De Tullio</dc:creator>
    <dc:date>2013-01-14T16:40:32</dc:date>
  </item>
  <item rdf:about="http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23527">
    <title>[Bug 50382] kio_thumbnail requests user input when previewing CSV files</title>
    <link>http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23527</link>
    <description>&lt;pre&gt;https://bugs.kde.org/show_bug.cgi?id=50382

Mark Fraser &amp;lt;mfraz74+kde&amp;lt; at &amp;gt;gmail.com&amp;gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mfraz74+kde&amp;lt; at &amp;gt;gmail.com

--- Comment #6 from Mark Fraser &amp;lt;mfraz74+kde&amp;lt; at &amp;gt;gmail.com&amp;gt; ---
I'm running Kubuntu 12.10 with KDE 4.10 Beta 2 and this bug has returned. Every
time I open a directory containing CSV files, the kio_thumbnailer window opens.

&lt;/pre&gt;</description>
    <dc:creator>Mark Fraser</dc:creator>
    <dc:date>2012-12-15T19:04:34</dc:date>
  </item>
  <item rdf:about="http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23526">
    <title>[Bug 50382] kio_thumbnail requests user input when previewing CSV files</title>
    <link>http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23526</link>
    <description>&lt;pre&gt;https://bugs.kde.org/show_bug.cgi?id=50382

Jarosław Staniek &amp;lt;staniek&amp;lt; at &amp;gt;kde.org&amp;gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|koffice-devel&amp;lt; at &amp;gt;kde.org       |staniek&amp;lt; at &amp;gt;kde.org

&lt;/pre&gt;</description>
    <dc:creator>Jarosław Staniek </dc:creator>
    <dc:date>2012-12-15T20:00:20</dc:date>
  </item>
  <item rdf:about="http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23525">
    <title>[Bug 50382] kio_thumbnail requests user input when previewing CSV files</title>
    <link>http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23525</link>
    <description>&lt;pre&gt;https://bugs.kde.org/show_bug.cgi?id=50382

Friedrich W. H. Kossebau &amp;lt;kossebau&amp;lt; at &amp;gt;kde.org&amp;gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
   Version Fixed In|                            |2.6
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/call
                   |                            |igra/464bae929e639ead7ad1bb
                   |                            |942b5b7df33537f69b

--- Comment #9 from Friedrich W. H. Kossebau &amp;lt;kossebau&amp;lt; at &amp;gt;kde.org&amp;gt; ---
Git commit 464bae929e639ead7ad1bb942b5b7df33537f69b by Friedrich W. H.
Kossebau.
Committed on 15/12/2012 at 20:57.
Pushed by kossebau into branch 'calligra/2.6'.

Remove non-ODS mimetypes from thumbnail file for OpenDocument Spreadsheets

FIXED-IN: 2.6

M  +1    -1    tools/thumbnail/sheets_ods_thumbnail.desktop

http://commits.kde.or&lt;/pre&gt;</description>
    <dc:creator>Friedrich W. H. Kossebau</dc:creator>
    <dc:date>2012-12-15T19:58:19</dc:date>
  </item>
  <item rdf:about="http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23524">
    <title>[Bug 50382] kio_thumbnail requests user input when previewing CSV files</title>
    <link>http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23524</link>
    <description>&lt;pre&gt;https://bugs.kde.org/show_bug.cgi?id=50382

--- Comment #8 from Friedrich W. H. Kossebau &amp;lt;kossebau&amp;lt; at &amp;gt;kde.org&amp;gt; ---
Git commit e70e5a3e8eadfd881579c86480eb21d677ecea6f by Friedrich W. H.
Kossebau.
Committed on 15/12/2012 at 20:56.
Pushed by kossebau into branch 'master'.

Remove non-ODS mimetypes from thumbnail file for OpenDocument Spreadsheets

M  +1    -1    tools/thumbnail/sheets_ods_thumbnail.desktop

http://commits.kde.org/calligra/e70e5a3e8eadfd881579c86480eb21d677ecea6f

&lt;/pre&gt;</description>
    <dc:creator>Friedrich W. H. Kossebau</dc:creator>
    <dc:date>2012-12-15T19:56:56</dc:date>
  </item>
  <item rdf:about="http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23523">
    <title>[Bug 50382] kio_thumbnail requests user input when previewing CSV files</title>
    <link>http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23523</link>
    <description>&lt;pre&gt;https://bugs.kde.org/show_bug.cgi?id=50382

Christoph Feck &amp;lt;christoph&amp;lt; at &amp;gt;maxiom.de&amp;gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
          Component|thumbnail                   |general
         Resolution|FIXED                       |---
           Assignee|malte&amp;lt; at &amp;gt;kde.org               |calligra-tables-bugs-null&amp;lt; at &amp;gt;k
                   |                            |de.org
            Product|kio                         |calligrasheets

--- Comment #7 from Christoph Feck &amp;lt;christoph&amp;lt; at &amp;gt;maxiom.de&amp;gt; ---
CSV importer is from calligra.

&lt;/pre&gt;</description>
    <dc:creator>Christoph Feck</dc:creator>
    <dc:date>2012-12-15T19:23:20</dc:date>
  </item>
  <item rdf:about="http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23517">
    <title>Can we expect another KOffice 2.3.x release?</title>
    <link>http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23517</link>
    <description>&lt;pre&gt;Hi, can we expect another KOffice 2.3.x release?

If not i'd like to remove it from the translations "stable" folder so our 
translators has less work.

Cheers,
  Albert
&lt;/pre&gt;</description>
    <dc:creator>Albert Astals Cid</dc:creator>
    <dc:date>2012-09-06T21:24:38</dc:date>
  </item>
  <item rdf:about="http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23515">
    <title>Please update http://kde.org/applications/office/</title>
    <link>http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23515</link>
    <description>&lt;pre&gt;Hi,

the Office page on kde.org has KSpread, KWord, KPlato, Kivio, Kexi, KPresenter, 
no Calligra Sheets, Words, Stage etc.

KSpread, KWord, KPlato, Kivio, Kexi, KPresenter development pages have wrong 
links to http://websvn.kde.org/trunk/koffice/ and more wrong infos.

Broken or dead handbook links to docs.kde.org are fixed by me, but I did not 
touch the other outdated infos.

Pages are generated from *json in trunk/www/sites/www/applications/apps/

Thanks.

&lt;/pre&gt;</description>
    <dc:creator>Burkhard Lück</dc:creator>
    <dc:date>2012-05-06T13:06:35</dc:date>
  </item>
  <item rdf:about="http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23514">
    <title>Re: Review Request: Removed unused code from kword/part/KWApplicationConfig.cpp</title>
    <link>http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23514</link>
    <description>&lt;pre&gt;
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104341/#review11647
-----------------------------------------------------------

Ship it!


simple, yet useful. I approve! :)
Thanks!

- Thomas Zander


On March 18, 2012, 10:41 p.m., Chris Smith wrote:

_______________________________________________
koffice-devel mailing list
koffice-devel&amp;lt; at &amp;gt;kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
&lt;/pre&gt;</description>
    <dc:creator>Thomas Zander</dc:creator>
    <dc:date>2012-03-20T08:06:14</dc:date>
  </item>
  <item rdf:about="http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23513">
    <title>Review Request: Removed unused code from kword/part/KWApplicationConfig.cpp</title>
    <link>http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23513</link>
    <description>&lt;pre&gt;
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104341/
-----------------------------------------------------------

Review request for KOffice and Robert Mathias Marmorstein.


Description
-------

Removed unused code from kword/part/KWApplicationConfig.cpp
Undo variable with related code and comments.
Spelling variable with related code and comments.


Diffs
-----

  kword/part/KWApplicationConfig.cpp 00e2bcb 

Diff: http://git.reviewboard.kde.org/r/104341/diff/


Testing
-------

built, installed, and runs


Thanks,

Chris Smith

_______________________________________________
koffice-devel mailing list
koffice-devel&amp;lt; at &amp;gt;kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
&lt;/pre&gt;</description>
    <dc:creator>Chris Smith</dc:creator>
    <dc:date>2012-03-18T22:41:53</dc:date>
  </item>
  <item rdf:about="http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23512">
    <title>Re: Review Request: Revert a commit that breaks TestDocumentLayout</title>
    <link>http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23512</link>
    <description>&lt;pre&gt;


Sounds good.  I'll push it, then.


- Robert Mathias


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104272/#review11500
-----------------------------------------------------------


On March 17, 2012, 1:08 a.m., Robert Mathias Marmorstein wrote:

_______________________________________________
koffice-devel mailing list
koffice-devel&amp;lt; at &amp;gt;kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
&lt;/pre&gt;</description>
    <dc:creator>Robert Mathias Marmorstein</dc:creator>
    <dc:date>2012-03-18T04:59:14</dc:date>
  </item>
  <item rdf:about="http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23511">
    <title>Re: Review Request: Revert a commit that breaks TestDocumentLayout</title>
    <link>http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23511</link>
    <description>&lt;pre&gt;
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104272/#review11500
-----------------------------------------------------------

Ship it!


The change had to do with a right-to-left layout where +1 would not go to the visible right, but to the left.

If this fixes the unit test, then please commit.  I'll make a note to find the case where the old code broke for and add a unit test for that one too, so a solution can be found for all items :)

- Thomas Zander


On March 17, 2012, 1:08 a.m., Robert Mathias Marmorstein wrote:

_______________________________________________
koffice-devel mailing list
koffice-devel&amp;lt; at &amp;gt;kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
&lt;/pre&gt;</description>
    <dc:creator>Thomas Zander</dc:creator>
    <dc:date>2012-03-17T09:13:16</dc:date>
  </item>
  <item rdf:about="http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23510">
    <title>Re: Review Request: Revert a commit that breaks TestDocumentLayout</title>
    <link>http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23510</link>
    <description>&lt;pre&gt;
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104272/
-----------------------------------------------------------

(Updated March 17, 2012, 1:08 a.m.)


Review request for KOffice and Thomas Zander.


Description
-------

This one-line change seems to have broken the kword-frames-TestDocumentLayout unit test.  I don't know whether the behaviour of Qt has changed or if the cursorToX function simply doesn't work as expected, but the test passes after reverting this change.


Diffs
-----

  kword/part/frames/KWTextDocumentLayout.cpp fc5173d 

Diff: http://git.reviewboard.kde.org/r/104272/diff/


Testing
-------

Everything builds, compiles, runs, and passes the same unit tests (plus one more!) if we revert the change.  However, it's possible that it's the test that's wrong.  I don't understand the layout algorithm well enough to know for sure.


Thanks,

Robert Mathias Marmorstein

_______________________&lt;/pre&gt;</description>
    <dc:creator>Robert Mathias Marmorstein</dc:creator>
    <dc:date>2012-03-17T01:08:20</dc:date>
  </item>
  <item rdf:about="http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23509">
    <title>Review Request: Revert a commit that breaks TestDocumentLayout</title>
    <link>http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23509</link>
    <description>&lt;pre&gt;
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104272/
-----------------------------------------------------------

Review request for KOffice.


Description
-------

This one-line change seems to have broken the kword-frames-TestDocumentLayout unit test.  I don't know whether the behaviour of Qt has changed or if the cursorToX function simply doesn't work as expected, but the test passes after reverting this change.


Diffs
-----

  kword/part/frames/KWTextDocumentLayout.cpp fc5173d 

Diff: http://git.reviewboard.kde.org/r/104272/diff/


Testing
-------

Everything builds, compiles, runs, and passes the same unit tests (plus one more!) if we revert the change.  However, it's possible that it's the test that's wrong.  I don't understand the layout algorithm well enough to know for sure.


Thanks,

Robert Mathias Marmorstein

_______________________________________________
koffice-devel mailing list
koff&lt;/pre&gt;</description>
    <dc:creator>Robert Mathias Marmorstein</dc:creator>
    <dc:date>2012-03-14T18:09:06</dc:date>
  </item>
  <item rdf:about="http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23508">
    <title>Re: Review Request: Add parentheses around instatiation of object to avoid ambiguity</title>
    <link>http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23508</link>
    <description>&lt;pre&gt;
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104262/#review11370
-----------------------------------------------------------

Ship it!


Can't imagine that having any negative side effects, so if it fixes the problem, then ship it :)

- Thomas Zander


On March 13, 2012, 6:53 p.m., Robert Mathias Marmorstein wrote:

_______________________________________________
koffice-devel mailing list
koffice-devel&amp;lt; at &amp;gt;kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
&lt;/pre&gt;</description>
    <dc:creator>Thomas Zander</dc:creator>
    <dc:date>2012-03-13T19:14:18</dc:date>
  </item>
  <item rdf:about="http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23507">
    <title>Re: Review Request: Change dynamic_cast in KoPAOdfSaveHelper constructor</title>
    <link>http://permalink.gmane.org/gmane.comp.kde.devel.koffice/23507</link>
    <description>&lt;pre&gt;
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104263/#review11369
-----------------------------------------------------------

Ship it!


The change looks correct. 

The change made by me some time ago (2nd christmas day 2011) where there used to be a KoPAPageBase seems to me a likely cause of this bug, apologies for not finding the unit test regression, and thanks for the fix!

- Thomas Zander


On March 13, 2012, 6:59 p.m., Robert Mathias Marmorstein wrote:

_______________________________________________
koffice-devel mailing list
koffice-devel&amp;lt; at &amp;gt;kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
&lt;/pre&gt;</description>
    <dc:creator>Thomas Zander</dc:creator>
    <dc:date>2012-03-13T19:12:35</dc:date>
  </item>
  <textinput rdf:about="http://search.gmane.org/?group=$group=gmane.comp.kde.devel.koffice">
    <title>Search Engine</title>
    <description>Search the mailing list at Gmane</description>
    <name>query</name>
    <link>http://search.gmane.org/?group=$group=gmane.comp.kde.devel.koffice</link>
  </textinput>
</rdf:RDF>
