gmane.comp.kde.devel.core

Review Request: Do not restore previously empty location bar URL

Dawit Alemayehu — 2012-05-18T07:54:17

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104982/
-----------------------------------------------------------

Review request for KDE Base Apps and David Faure.


Description
-------

The attached patch fixes the issue reported in the aforementioned bug report. Specifically, it stops Konqueror from restoring the location bar to the previous URL if 

a.) It was empty as in a newly created tab.
b.) The user typed in a new URL that cannot be handled by Konqueror. The URL was launched with another application.


This addresses bug 270723.
    http://bugs.kde.org/show_bug.cgi?id=270723


Diffs
-----

  konqueror/src/konqview.cpp bfeb20b 

Diff: http://git.reviewboard.kde.org/r/104982/diff/


Testing
-------

Tested the following three scenarios:

1.) Open a new tab in Konqueror and type-in a URL it cannot handle.
2.) Open a new tab, browse to any location, and then type-in a URL Konqueror cannot handle.

Review Request: Remove additional directories from shortcuts scheme export path

Burkhard Lück — 2012-05-18T07:11:55

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104981/
-----------------------------------------------------------

Review request for kdelibs.


Description
-------

The Configure Shortcuts dialog has an Action to export a scheme 
(Details->More Actions->Export Scheme)

Using this action the user is asked for a export location and has to select a directory.
Then the current scheme 'schemename' in application 'appname' is exported to a file 
named appnameschemenameshortcuts.rc.

But this file is not saved in the selected directory as Joe User would expect, but in 
shortcuts/share/apps/appname/ below the selected folder.

This patch removes the additional directories shortcuts/share/apps/appname/ from 
the export path to make it easier for the user to find the scheme file and move/copy 
it via command line (there is no GUI to import a scheme).


Diffs
-----

  kdeui/dialogs/kshortcutschemeseditor.cpp 34a

Re: Review Request: KJS: improve regex flag scanning

Commit Hook — 2012-05-17T22:00:23

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104974/#review13944
-----------------------------------------------------------


This review has been submitted with commit e2f5d87a29f4a06b3056bc6e89f61b2a0df9124e by Rolf Eike Beer to branch KDE/4.8.

- Commit Hook


On May 17, 2012, 5:17 p.m., Rolf Eike Beer wrote:

Re: Review Request: Define tooltips for kdeui standard actions

Commit Hook — 2012-05-17T21:08:52

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104934/#review13940
-----------------------------------------------------------


This review has been submitted with commit 9cfafa78940e7db68f05957ca701e58f770cbda2 by Aurélien Gâteau to branch KDE/4.8.

- Commit Hook


On May 14, 2012, 8:36 p.m., Aurélien Gâteau wrote:

Re: [Nepomuk] Nepomuk - Moving out of kde-runtime

Sebastian Trüg — 2012-05-17T20:13:16

Do you think we will do that change for 4.10?
If we wait until K5 we can break as much as we like...

Re: Nepomuk - Moving out of kde-runtime

Sune Vuorela — 2012-05-17T19:59:07

Great. thanks.

hugs and kisses

/Sune

Re: Nepomuk - Moving out of kde-runtime

Sebastian Trüg — 2012-05-17T19:44:07

I think we can manage BC. The only thing that would be hard are the DBus
interfaces. But since nepomuk-core contains client libs which are
supposed to be used instead of the dbus interfaces...

On 05/17/2012 09:19 PM, Sune Vuorela wrote:

Re: Nepomuk - Moving out of kde-runtime

Sune Vuorela — 2012-05-17T19:19:50

NACK.

this is a completely no go.

/Sune

Review Request: KJS: improve regex flag scanning

Rolf Eike Beer — 2012-05-17T17:17:07

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104974/
-----------------------------------------------------------

Review request for kdelibs.


Description
-------

Only scan the list of flags once, and only if there is a list at all.

It also fixes the S15.10.4.1_A5_T1 and S15.10.4.1_A5_T1 tests of ECMA test262:
a regex flag may be given only once.

I also checked Firefox behaviour, it also throws a syntax error in this case.


Diffs
-----

  kjs/regexp_object.cpp a6b6974 

Diff: http://git.reviewboard.kde.org/r/104974/diff/


Testing
-------

Run ECMA testsuite. These 2 tests now pass, no other changes.


Thanks,

Rolf Eike Beer

Re: Nepomuk - Moving out of kde-runtime

Albert Astals Cid — 2012-05-17T16:50:25

El Dijous, 17 de maig de 2012, a les 19:31:14, Vishesh Handa va escriure:

That's not a problem.

Albert

Re: Review Request: Added option for disabling the offer to save website passwords in Konqueror

Dawit Alemayehu — 2012-05-17T15:15:27



< at >Martin: Great. Thanks for the patch.


- Dawit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104631/#review12934
-----------------------------------------------------------


On April 26, 2012, 3:48 a.m., Dawit Alemayehu wrote:

Re: Review Request: Use the focus proxy, if present, as parent of KonqPopupMenu

Dawit Alemayehu — 2012-05-17T15:09:20



This is an upstream QtWebKit issue. I cannot duplicate the problem with the current trunk version.


- Dawit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104890/#review13602
-----------------------------------------------------------


On May 9, 2012, 7:13 a.m., Dawit Alemayehu wrote:

Re: Nepomuk - Moving out of kde-runtime

Vishesh Handa — 2012-05-17T14:35:03

Forgot to add the correct kde-packagers email.

On Thu, May 17, 2012 at 7:31 PM, Vishesh Handa <me< at >vhanda.in> wrote:

Nepomuk - Moving out of kde-runtime

Vishesh Handa — 2012-05-17T14:01:14

Hey

I just thought everyone should know what's going on with Nepomuk.

As per 4.9, we are going to have 3 repositories -

* nepomuk-core [1]
* nepomuk-kde-kio [2]
* nepomuk-kde-config [3]

kde-runtime/nepomuk will be removed. Kdelibs will not be touched. All the
headers are being installed under nepomuk2, and the source code is now
under a Nepomuk2 namespace. This has been done to avoid clashes between
nepomuk-core and kdelibs. The library names have also changed.

For a detailed discussion as to why this is being done, please read [4].

< at >Packagers: We will not be maintaining binary compatibility in
nepomuk-core. At least not for KDE 4.10. We still need to break a lot of
things.

< at >Release-team: Would it be possible to get an extension for the hard
freeze? We're almost ready with the repositories. We just need to go about
removing kde-runtime/nepomuk, and moving some of the repositories out of
trueg's scratch repositories.

< at >Translators: You probably want to preserve the translations in
kde-runtime/nepomuk.

Review Request: Plasma::RunnerManager: only dequeue our ThreadWeaver jobs

Aurélien Gâteau — 2012-05-17T13:18:11

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104973/
-----------------------------------------------------------

Review request for kdelibs.


Description
-------

When RunnerManager::reset() is called, all ThreadWeaver jobs are dequeued, including jobs from other parts of the code. This patch changes this to only dequeue the jobs created by this instance of RunnerManager.


Diffs
-----

  plasma/runnermanager.cpp 49569a3 

Diff: http://git.reviewboard.kde.org/r/104973/diff/


Testing
-------

I have more than one RunnerManager working at once in a project. Without the patch, only one manager return results.


Thanks,

Aurélien Gâteau

Re: KDELibsNightly.cmake

Andreas Pakulat — 2012-05-17T11:30:24

Hi,

I think this techbase article is pretty much up-to-date. I guess the
KDElibsNighly.cmake file should simply be deleted.
http://techbase.kde.org/Development/CMake/DashboardBuilds

On Thu, May 17, 2012 at 9:59 AM, Rolf Eike Beer <kde< at >opensource.sf-tec.de>wrote:

KDELibsNightly.cmake

Rolf Eike Beer — 2012-05-17T07:59:40

I wanted to run a (single) nightly build of kdelibs to see how the coverage 
changes when the ECMAtest is used. There is a KDELibsNightly.cmake file in the 
root directory of kdelibs, but that still talks about svn. Changing that may 
be easy, but the KDECTestNightly.cmake referenced in there that should be in 
KDESDK can't be found at the mentioned place. I know that Volker is running a 
nightly build so there must be some sort of script for this. Can the one in 
the repository please be updated to be in a useful state?

Greetings,

Eike

Re: [Nepomuk] The Nepomuk Situation

Sebastian Trüg — 2012-05-17T07:13:49


On 05/16/2012 10:40 PM, Stephen Kelly wrote:

that is fine.

Moving "scheck" from kdesdk to tags/unmaintained/4/scheck ?

Friedrich W. H. Kossebau — 2012-05-17T02:39:10

Hi,

in preparation of the migration of kdesk to git I found that scheck in 
kdesdk is currently excluded from the build, because it has been never 
completely ported to Qt4/KDE4. And it seems noone has missed it for 4 years, 
perhaps accel conflicts & Co. are no longer a big problem?

Thus I will move kdesdk/scheck to tags/unmaintained/4/scheck next 
Sunday, May 20th, in the European evening, unless anyone objects.

Also blogged for a new maintainer of scheck, perhaps somebody likes to pick 
the scheck style up: http://frinring.wordpress.com/2012/05/17/maintainer-
wanted-port-the-scheck-style-to-qt4/

Any way, being in unmaintained soon does not prevent it to become migrated to 
a git repo later as well, if ported.

Cheers
Friedrich

Re: Review Request: Define tooltips for kdeui standard actions

Aurélien Gâteau — 2012-05-16T21:53:43

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104934/#review13901
-----------------------------------------------------------


Time is running: soft-message-freeze is tomorrow. I am going to commit this tomorrow evening, unless someone objects.

- Aurélien Gâteau


On May 14, 2012, 8:36 p.m., Aurélien Gâteau wrote:

Re: [Nepomuk] The Nepomuk Situation

Stephen Kelly — 2012-05-16T20:40:44


Just so there's no surprises later: all nepomuk stuff in kdelibs was removed 
from frameworks a long time ago when we were told that the continuation of 
nepomuk would be in the nepomuk-core and other repos.

Thanks,

Steve.