gmane.comp.java.openjdk.swing.devel

Re: Fwd: RFR: 8011346: build-infra: While Constructing Javadoc information, JSpinner.java error: package sun.util.locale.provider does not exist

Naoto Sato — 2013-05-15T18:25:26

Looks good to me.

Naoto

On 5/15/13 5:12 AM, Erik Joelsson wrote:

Re: Fwd: RFR: 8011346: build-infra: While Constructing Javadoc information, JSpinner.java error: package sun.util.locale.provider does not exist

Erik Joelsson — 2013-05-15T12:12:50

Re: Request for review: NPE when using Nimbus with a TableCellRenderer returning null.

Clemens Eisserer — 2013-05-10T22:01:14

Hi Alexander,


Sorry for the lag - I have been on vacation.
I'll prepare something tomorrow.

Regards, Clemens

Java/Swing Opportunity in Orange County, California

Kelly Farmer — 2013-05-10T17:45:37

I have a 3 month Java/Swing contract opportunity available in Irvine, CA. This position is open for immediate start. If you or someone you know may be interested, please contact me as soon as possible for more information on the company and position.

Thank you!

Kelly Farmer, Recruiting Assistant
CONEXiS, Inc.
www.conexis.net<http://www.conexis.net/>
E-mail: kfarmer-1LGcTE8OM3XR7s880joybQ< at >public.gmane.org<mailto:kfarmer-1LGcTE8OM3XR7s880joybQ< at >public.gmane.org>
Office: 949-360-1880 x1112





[cid:image001.jpg-IDsZHK4RJGR4vE3z8cWZmDRmByFHzeGd< at >public.gmane.org]<http://www.conexis.net/>

Re: [PATCH] 7168064: SwingUtilities.sharedOwnerFrame multiplies window close event

Anthony Petrov — 2013-05-08T12:29:32

Hi,

This indeed looks like a bug in AWT. I'm BCC'ing swing-dev< at >, and CC'ing 
awt-dev< at > instead (please subscribe to this mailing list before posting 
to it).

Here's a question: why do we consider this issue affects child windows 
only? If you call dispose() on a regular window several times in a row, 
you'll receive that many WINDOW_CLOSED events. Isn't it the real bug 
here actually?

Note that simply guarding a call to dispose()/disposeImpl() with a check 
is not the best option because it changes the behavior. If user code 
overrides certain methods, they may be stopped being called after your 
fix, and this may break that code.

Since the DisposeAction is executed synchronously anyway, perhaps it 
should set a flag based on which the doDispose() method would decide to 
send this event or not. What do you think? Also, have you run existing 
jtreg tests (in jdk/test/java/awt/) to verify that this fix doesn't 
introduce a regression?

PS. I can't find the bug filed by you in our bug database. I'll file a

Fwd: RFR: 8011346: build-infra: While Constructing Javadoc information, JSpinner.java error: package sun.util.locale.provider does not exist

Erik Joelsson — 2013-05-08T12:05:12

[PATCH] 7168064: SwingUtilities.sharedOwnerFrame multiplies window close event

Jose Luis Martin — 2013-05-06T08:28:03

Hello, 

I reported this issue one year ago but seems that it has been removed
from the public bug database and is still not fixed so I try now to
speak directly with you to see if this really is a bug or not.

The problem that I see is that a child window already disposed is
re-disposed when the owner frame is disposed, multiplying the
WINDOW_CLOSED events.

I guess that it could be fixed by testing if the child window is
displayable before disposing it in the Window dispose action. (May be
better in the dispose method itself).

I attach patch over last jdk8 repository and a test case for the issue.

Thanks, 

Best Regards.

Re: [8] Review request for 8012004: JINTERNALFRAME NOT BEING FINALIZED AFTER CLOSING

alexander potochkin — 2013-04-29T06:18:06

Looks good

Thanks
alexp

On 22.04.2013 14:48, mikhail cherkasov wrote:

Re: [8] Review request for 7011777 JDK 6 parses html text with script tags within comments differently from previous releases

Alexander Scherbatiy — 2013-04-26T14:47:48

   The fix looks good for me.

   Thanks,
   Alexandr.

On 4/25/2013 1:11 PM, Dmitry Markov wrote:

Re: [8] Review request for 8012004: JINTERNALFRAME NOT BEING FINALIZED AFTER CLOSING

Alexander Scherbatiy — 2013-04-26T10:31:29

   The fix looks good for me.

   Thanks,
   Alexandr.

On 4/23/2013 1:48 AM, mikhail cherkasov wrote:

Re: Request for review: NPE when using Nimbus with a TableCellRenderer returning null.

Alexander Scherbatiy — 2013-04-26T10:25:57

   Hello Clemens,

   Could you send a code snippet from your application that reproduces 
the NPE?
   I think we should investigate first why the JTable.prepareRenderer() 
returns null in this case.

   Thanks,
   Alexandr.

On 4/18/2013 9:37 AM, Miguel Muñoz wrote:

Re: [8] Review request for 7011777 JDK 6 parses html text with script tags within comments differently from previous releases

Dmitry Markov — 2013-04-25T09:11:39

Reminder.
Could you review this, please?

Thanks,
Dmitry

Re: [8] Review request for 8012004: JINTERNALFRAME NOT BEING FINALIZED AFTER CLOSING

mikhail cherkasov — 2013-04-22T21:48:10

Hello all,

javadoc was added:
http://cr.openjdk.java.net/~mcherkas/8012004/webrev.01/ 
<http://cr.openjdk.java.net/%7Emcherkas/8012004/webrev.01/>

Thanks,
Mikhail.

On 19.04.2013 15:59, mikhail cherkasov wrote:

[8] Review request for 7011777 JDK 6 parses html text with script tags within comments differently from previous releases

Dmitry Markov — 2013-04-19T12:55:28

Hello,

could you please review the fix:
bug: http://bugs.sun.com/view_bug.do?bug_id=7011777
webrev: http://cr.openjdk.java.net/~vkarnauk/7011777/jdk8/webrev.0/

The method parseScript() was modified, added functionality to determine 
the position of the </script> tag. If </script> is located inside HTML 
comment, the method will not take it into account and continue parsing.

Thanks,
Dmitry

[8] Review request for 8012004: JINTERNALFRAME NOT BEING FINALIZED AFTER CLOSING

mikhail cherkasov — 2013-04-19T11:59:04

Hello All,

Could you please review fix for this bug:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8012004
you can find webrev there:
http://cr.openjdk.java.net/~mcherkas/8012004/webrev.00/ 
<http://cr.openjdk.java.net/%7Emcherkas/8012004/webrev.00/>

Thanks,
Mikhail.

Re: [8] Request for review:

mikhail cherkasov — 2013-04-19T11:56:43

Please ignore this request, because as you can see subject is not 
complete.I'll resend it with correct subject in 2 min.

Thanks,
Mikhail.

On 19.04.2013 3:39, mikhail cherkasov wrote:

[8] Request for review:

mikhail cherkasov — 2013-04-18T23:39:07

Hello All,

Could you please review fix for this bug:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8012004
you can find webrev there:
http://cr.openjdk.java.net/~mcherkas/8012004/webrev.00/ 
<http://cr.openjdk.java.net/%7Emcherkas/8012004/webrev.00/>

Thanks,
Mikhail.

Re: Request for review: NPE when using Nimbus with aTableCellRenderer returning null.

Miguel Muñoz — 2013-04-18T05:37:01

JTable.prepareRenderer() should never return null. There's nothing in the API to suggest that null is a valid return value. I have found (and reported) at least one bug in Nimbus where it returns a null renderer when the column class is Icon. I think that's fixed, but I wouldn't be surprised if there are others.

— Miguel Muñoz


On Apr 16, 2013, at 7:55 AM, Alexander Scherbatiy wrote:


-------------------------------------------

Miguel Muñoz
SwingGuy1024-/E1597aS9LQAvxtiuMwx3w< at >public.gmane.org
323/225-7285

-------------------------------------------

The Sun, with all those planets revolving around it and dependent on it, can still ripen a vine of grapes like it had nothing else to do in the world.

  -- Galileo

-------------------------------------------

There are seven sins in the world.
    Wealth without work.
    Pleasure without conscience.
    Knowledge without character.
    Commerce without morality.
    Science without humanity.
    Worship without sacrifice.
    Politics without principl

Re: Request for review: NPE when using Nimbus with a TableCellRenderer returning null.

Alexander Scherbatiy — 2013-04-16T14:55:41

     Could you check that returning the null component is the correct 
behavior in this case?
     So there is no the real bug that does not allow to return the right 
component.

    There are 2 issues with the NPE in paintCell chain call in JTable:
      6582564 JTable with rowHeader and sorting given NPE when inserting 
a new row
         http://bugs.sun.com/view_bug.do?bug_id=6582564
      6429812 NPE after calling JTable.updateUI() when using a header 
renderer + XP L&F
       http://bugs.sun.com/view_bug.do?bug_id=6429812

    This issue is different so I can create the new one.

    Thanks,
    Alexandr.

Request for review: NPE when using Nimbus with a TableCellRenderer returning null.

Clemens Eisserer — 2013-04-13T10:19:17

Hi,

When testing a legacy application which was using Metal LnF previously
with Nimbus I ran into the following problem:

  Exception in thread "AWT-EventQueue-0" java.lang.NullPointerException
      at javax.swing.plaf.synth.SynthTableUI.paintCell(SynthTableUI.java:685)
      at javax.swing.plaf.synth.SynthTableUI.paintCells(SynthTableUI.java:581)
      ......

the code in question is:

  TableCellRenderer renderer = table.getCellRenderer(row, column);
  Component component = table.prepareRenderer(renderer, row, column);
  Color b = component.getBackground();

I've written a patch to simply check for "component" to be non-null:
http://cr.openjdk.java.net/~ceisserer/nimbusnpe/
Unfortunately I don't have a bug number, as the old bug-submission
system seems to be dead.

Please let me know what you think.

Regards, Clemens

Re: [8] Review request for CR 7153702 [TEST_BUG] [macosx] Synchronization problem in test javax/swing/JPopupMenu/6827786/bug6827786.java

Sergey Bylokhov — 2013-04-08T13:12:39

Hi, Konstantin.
Fix looks good.

On 4/8/13 11:39 AM, Konstantin Shefov wrote: