gmane.comp.java.openjdk.hotspot.runtime.devel

hg: hsx/hotspot-emb/langtools: Added tag jdk8-b39 for changeseta9f547c218d9

2012-05-18T03:50:01

Changeset: 8b869afd2eb4
Author:    katleman
Date:      2012-05-17 06:20 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-emb/langtools/rev/8b869afd2eb4

Added tag jdk8-b39 for changeset a9f547c218d9

! .hgtags

hg: hsx/hotspot-emb/jdk: 4 new changesets

2012-05-18T03:47:48

Changeset: c2d9166f3284
Author:    ihse
Date:      2012-05-11 08:21 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-emb/jdk/rev/c2d9166f3284

7168208: Change use of < at > in one sed command involving paths to different character
Reviewed-by: ohair

! make/common/Release.gmk

Changeset: 8d665b69ebf1
Author:    mfang
Date:      2012-05-15 11:46 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-emb/jdk/rev/8d665b69ebf1

7157855: jvisualvm.1 not included in binaries
Reviewed-by: katleman, thurka

! make/common/Release.gmk

Changeset: b6f529117521
Author:    katleman
Date:      2012-05-16 22:07 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-emb/jdk/rev/b6f529117521

Merge


Changeset: 47cd90bf0f66
Author:    katleman
Date:      2012-05-17 06:20 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-emb/jdk/rev/47cd90bf0f66

Added tag jdk8-b39 for changeset b6f529117521

! .hgtags

hg: hsx/hotspot-emb/jaxws: Added tag jdk8-b39 for changeset7f6b44fd3034

2012-05-18T03:47:34

Changeset: 09a0ddda03cb
Author:    katleman
Date:      2012-05-17 06:20 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-emb/jaxws/rev/09a0ddda03cb

Added tag jdk8-b39 for changeset 7f6b44fd3034

! .hgtags

hg: hsx/hotspot-emb/jaxp: Added tag jdk8-b39 for changesetf95fdbe525c8

2012-05-18T03:47:22

Changeset: 9ecfdbd6aed4
Author:    katleman
Date:      2012-05-17 06:20 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-emb/jaxp/rev/9ecfdbd6aed4

Added tag jdk8-b39 for changeset f95fdbe525c8

! .hgtags

hg: hsx/hotspot-emb/corba: Added tag jdk8-b39 for changeset785af00e2827

2012-05-18T03:47:14

Changeset: 56d030e5035f
Author:    katleman
Date:      2012-05-17 06:20 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-emb/corba/rev/56d030e5035f

Added tag jdk8-b39 for changeset 785af00e2827

! .hgtags

hg: hsx/hotspot-emb: 4 new changesets

2012-05-18T03:47:09

Changeset: 955a3e8ed4f0
Author:    ohair
Date:      2012-05-10 08:26 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-emb/rev/955a3e8ed4f0

7167593: Changed get_source.sh to allow for getting full oracle jdk repo forest
Reviewed-by: erikj, asaha, chegar, sla, dholmes, mbykov, coleenp

! get_source.sh
! make/scripts/hgforest.sh

Changeset: 8a4e92c10a9a
Author:    ohair
Date:      2012-05-11 17:52 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-emb/rev/8a4e92c10a9a

7167976: Fix broken get_source.sh script
Reviewed-by: tbell

! make/scripts/hgforest.sh

Changeset: 8927dd68aee3
Author:    katleman
Date:      2012-05-16 22:06 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-emb/rev/8927dd68aee3

Merge


Changeset: a2b2d435f1d2
Author:    katleman
Date:      2012-05-17 06:20 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-emb/rev/a2b2d435f1d2

Added tag jdk8-b39 for changeset 8927dd68aee3

! .hgtags

Re: x86 interpreters in hotspot

Krystal Mok — 2012-05-17T05:21:52

BTW, "the current bytecode pc" is called "bcp" in HotSpot, which stands for
"bytecode pointer".

- Kris

Re: x86 interpreters in hotspot

Xin Tong — 2012-05-16T20:34:12

can I assume that at the beginning of each interpreter routine for the
bytecodes, the current bytecode pc is going to be stored in r13 on x86_64 ?

Thanks

Xin

Re: Request for review (S): add the JRE name to the error log

Christian Thalinger — 2012-05-16T20:26:57

On May 16, 2012, at 12:44 PM, Krystal Mok wrote:


I looked at the changes and I think this is the right way to implement it.  It will definitely help debugging some strange crashes like the one mentioned.

Request for review (S): add the JRE name to the error log

Krystal Mok — 2012-05-16T19:44:15

Hi all,

Could I get some review for this change, please?
https://gist.github.com/2709918#file_jre_name.patch
I'm considering this as an initial draft version, and will improve it later
on
based on comments received.

Background:

An earlier case on hotspot-dev [1][2] seemed to have hit a bug caused by
mix-
matching an Oracle JRE with a OpenJDK-based HotSpot VM.

Chris suggested [3] that, to better aid future analysis of similar problems,
it's useful to print the JRE name in the error log, in addition to the JRE
version as printed currently. This patch implements Chris' suggestion.

An example of the effect of this patch is avaiable [4].

There are a few details that I'm not too sure about yet, and I'm looking for
comments on them:

1. How and when should I get the JRE name?

The JRE name is only exposed as a field of a Java-level class, namely the
"java_runtime_name" constant field in sun.misc.Version. I couldn't find it
exposed anywhere else. It is set into the Java-level system properties, by
the
key "jav

Re: RFR (S): 7167254: Crash on OSX in Enumerator.nextElement() withcompressed oops

Karen Kinnear — 2012-05-16T18:42:18

Roland,

Many thanks for testing and closing 7129716.

I did look at the code path for stack overflow and there is no obvious place
where we look for SEGV and also need to look for SIGBUS.
We will follow up on 7129715.

many thanks,
Karen

On May 16, 2012, at 9:49 AM, Roland Westrelin wrote:

Re: RFR (S): 7167254: Crash on OSX in Enumerator.nextElement() withcompressed oops

Vladimir Kozlov — 2012-05-16T15:44:24

Good.

Vladimir

On 5/16/12 7:25 AM, Roland Westrelin wrote:

Re: RFR (S): 7167254: Crash on OSX in Enumerator.nextElement() withcompressed oops

Roland Westrelin — 2012-05-16T14:25:30

One more webrev:
http://cr.openjdk.java.net/~roland/7167254/webrev.02/

I forgot to cast the MacroAssembler::needs_explicit_null_check() argument to intptr_t rather than int.

Roland.

Re: RFR (S): 7167254: Crash on OSX in Enumerator.nextElement() withcompressed oops

Roland Westrelin — 2012-05-16T14:21:12

A SIGBUS caused by a bug in generated code for instance? Yes, there is a risk, the same way there is a risk a SIGSEGV becomes a NPE.
A SIGBUS that should be caught by the VM rather than be converted to a NPE. It doesn't look possible to me.

Roland.

Re: RFR (S): 7167254: Crash on OSX in Enumerator.nextElement() withcompressed oops

Roland Westrelin — 2012-05-16T13:49:02

Hi Karen,


This one still reproduces with my change.


This one is a duplicate of my bug. I closed it.

Roland.

hg: hsx/hotspot-rt/hotspot: 7165755: OS Information much longer onlinux than other platforms

2012-05-16T10:52:35

Changeset: 7432b9db36ff
Author:    nloodin
Date:      2012-05-10 15:44 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/7432b9db36ff

7165755: OS Information much longer on linux than other platforms
Reviewed-by: sla, dholmes

! src/os/bsd/vm/os_bsd.cpp
! src/os/linux/vm/os_linux.cpp
! src/os/linux/vm/os_linux.hpp
! src/os/posix/vm/os_posix.cpp
+ src/os/posix/vm/os_posix.hpp
! src/os/solaris/vm/os_solaris.cpp
! src/os/solaris/vm/os_solaris.hpp
! src/os/windows/vm/os_windows.cpp
! src/os/windows/vm/os_windows.hpp
! src/share/vm/runtime/os.hpp

Re: RFR (S): 7167254: Crash on OSX in Enumerator.nextElement() withcompressed oops

David Holmes — 2012-05-16T03:22:38

Is there any possibility we will mistake a real SIGBUS for a 
NullPointerException ?

David

Re: x86 interpreters in hotspot

Xin Tong — 2012-05-15T23:56:49

i am looking at the dispatch code for fast_aaccess_0  221 fast_aaccess_0
 [0x00007f640d0363a0, 0x00007f640d0364a0]  256 bytes

   0x7f640d03646d:      call   0x7f6415353200
<_ZN14MacroAssembler7debug64EPclPl>
   0x7f640d036472:      hlt
   0x7f640d036473:      pop    r10
   0x7f640d036475:      dec    r13
   0x7f640d036478:      movzx  ebx,BYTE PTR [r13+0x4]
   0x7f640d03647d:      mov    r11,r13
   0x7f640d036480:      add    r13,0x4
   0x7f640d036484:      movabs r10,0x7f641623e8c0


It is decrementing r13, instead of incrementing. how is this possible ?

Thanks

Xin


On Tue, May 15, 2012 at 12:45 PM, Krystal Mok <rednaxelafx-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org> wrote:

Re: RFR (S): 7167254: Crash on OSX in Enumerator.nextElement() withcompressed oops

Roland Westrelin — 2012-05-15T18:40:49

Hi Karen,


Sure. I'll see if they still reproduce.

Roland.

Re: RFR (S): 7167254: Crash on OSX in Enumerator.nextElement() withcompressed oops

Karen Kinnear — 2012-05-15T17:52:54

Roland,

Does this fix either of the following SIGBUS on Mac bugs?

7129715 (this is the one where it also lists "An irrecoverable stack overflow has occurred,
  which is where my other question came from - is there a place where we look for
  SIGSEGV for stack overflow and also need to look for SIGBUS" - I didn't track the code
  path yet)
Test name: gc/gctests/JumbleGC002 ( see the jira link)

7129716 (probably just a duplicate of the one you just fixed)
   
Hotspot regression tests compiler/6865031/Test.java
fails on MacOS if run with -Xcomp:

Any chance you could run these tests with your new fix?

thanks very much,
Karen

On May 15, 2012, at 8:38 AM, Roland Westrelin wrote:

Re: x86 interpreters in hotspot

Krystal Mok — 2012-05-15T16:45:00

My slides did explain the TOS adaptation:
http://www.tektalk.org/2011/07/28/java-%E7%A8%8B%E5%BA%8F%E7%9A%84%E7%BC%96%E8%AF%91%EF%BC%8C%E5%8A%A0%E8%BD%BD-%E5%92%8C-%E6%89%A7%E8%A1%8C/


executed for them. Please see the end
of TemplateInterpreterGenerator::generate_and_dispatch(), and also see
TemplateTable::initialize() for the list of bytecodes that do dispatch on
their own.

- Kris