gmane.comp.java.openjdk.distro-packaging.devel

Re: [rfc] [icedtea-web] fix for PR811

Jiri Vanek — 2012-05-18T11:27:59

...

all the indentations and typos should be fixed now


Done. I have tasted a bit against strange characters and looks fine.
I have also realized that I forgot to encode query. It is now done.


2012-05-18  Jiri Vanek  <jvanek-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>

More tests for Spaces and characters in urls
* netx/net/sourceforge/jnlp/cache/CacheLRUWrapper.java: and
* netx/net/sourceforge/jnlp/cache/CacheUtil.java: for unit-tests
purposes (cacheDir) make to point to tmp dir when no
DeploymentConfigurationexists.
* tests/jnlp_tests/signed/Spaces can be everywhere signed/:
couple of new test dooing the same as simple "Spaces can be everywhere"
but are signed
* tests/jnlp_tests/simple/Spaces can be everywhere/: added new test-cases
and html/jnlp test files to try more combinations of encodable characters
x launches
* tests/netx/unit/net/sourceforge/jnlp/cache/ResourceTrackerTest.java:
unittest for url encoder behavior
* tests/netx/unit/net/sourceforge/jnlp/cache/CacheUtilTest.java:
unitte

Re: [RFC][icedtea-web] Fix for PR855: AppletStub getDocumentBase()doesn't return full URL

Jiri Vanek — 2012-05-18T09:15:11

Can we get also test for this? :(

Re: [rfc] [icedtea-web] make links

Jiri Vanek — 2012-05-18T09:08:09

agree - but form this point of view I'm doing the best thing right now.

make
make check
make install
make links //must be run manually
make run-netx-dist-tests  //if  links point to something not installed by this make install, then 
there is tests to catch this. If there are no correct links all browser tests will fail
make unlink (or make clean) //make unlink *restores* previous configuration

Looking forward for "whats going to happen" O:)
J.

Re: Thermostat 0.2 Released!

Andrew Dinn — 2012-05-18T09:01:16

Hi Thermostatters,

I tried building thermostat 0.2 (or rather the latest hg clone of the
repo) yesterday and got an error from surefire when executing the agent
tests. Details included below.

regards,


Andrew Dinn
-----------

Here is the maven output
----- 8< -------- 8< -------- 8< -------- 8< -------- 8< ---
. . .
Running com.redhat.thermostat.agent.config.AgentOptionParserTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.035 sec
Running com.redhat.thermostat.backend.system.DistributionInformationTest
Tests run: 2, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.011
sec <<< FAILURE!

Results :

Failed tests:
testName(com.redhat.thermostat.backend.system.DistributionInformationTest)

testVersion(com.redhat.thermostat.backend.system.DistributionInformationTest)

Tests run: 85, Failures: 2, Errors: 0, Skipped: 0

[INFO]
------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Thermostat ........................................

Re: [RFC][icedtea-web] Small code cleanup changes: fixing some codecloning, misleading comments & parameters etc

Omair Majid — 2012-05-17T21:44:14

Hi Adam,

On 05/17/2012 05:19 PM, Adam Domurad wrote:

Comments in-line, below.


Please don't do this. The fall-through here is intentional. It wont do
much harm, but it will leave out extra information for debugging. I
wouldn't mind if you added a comment here indicating this, though.
Something like:

/* fallthrough */


Could you actually fill in the TODOs befor commiting?

Cheers,
Omair

Re: [RFC][icedtea-web] Fix for PR855: AppletStub getDocumentBase()doesn't return full URL

Danesh Dadachanji — 2012-05-17T21:34:12


On 17/05/12 05:16 PM, Danesh Dadachanji wrote:

Woops forgot the ChangeLog entry:

+2012-05-17  Danesh Dadachanji  <ddadacha-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
+
+PR855: AppletStub getDocumentBase() doesn't return full URL
+* plugin/icedteanp/IcedTeaNPPlugin.cc (plugin_get_documentbase):
+Assign documentbase_copy directly to href's value instead of iterating
+through the segments to remove the file from the path.
+

There were also some tabs in my previous patch, those are gone now in the new attachment.

[RFC][icedtea-web] Small code cleanup changes: fixing some codecloning, misleading comments & parameters etc

Adam Domurad — 2012-05-17T21:19:01

Hi all. This incorporates some changes I made to reduce code cloning on a patch that I have to reconsider partially, as well as some comment clean ups etc. Generally contains small code cleanup changes, fixing some code cloning, misleading comments & parameters etc

Changelog:
2012-05-17  Adam Domurad  <adomurad-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
        Code cleanup, unification of cloned code & comment fixing
        * netx/net/sourceforge/jnlp/browser/BrowserAwareProxySelector.java:
        Added break statements (good practice, here it wouldn't affect the code
        due to a check of == null before changing the value).
        * netx/net/sourceforge/jnlp/cache/UpdatePolicy.java:
        Made fields intended as constants 'final'
        * netx/net/sourceforge/jnlp/controlpanel/CachePane.java:
        generateData(DirectoryNode root) had useless parameter - was set before
        being used. Similarly, the 'root' member variable was never set. Made
        the 'root' member variable set instead and

Re: [RFC][icedtea-web] Fix for PR855: AppletStub getDocumentBase()doesn't return full URL

Danesh Dadachanji — 2012-05-17T21:16:20

On 16/04/12 01:18 PM, Deepak Bhole wrote:

Ah yes I wasn't paying attention to the surrounding code :S

How's this look? I'd like to backport this to 1.2 as well. The reporter uses 1.1.3 though so perhaps it should go into 1.1 too? Thoughts?

Cheers,
Danesh

Re: Removal of two instances of synchronization on Boolean

Deepak Bhole — 2012-05-17T20:34:43

* Adam Domurad <adomurad-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org> [2012-05-17 16:30]:

Looks good to me! OK for 1.1/1.2/HEAD from me.

Thanks,
Deepak

Re: Removal of two instances of synchronization on Boolean

Adam Domurad — 2012-05-17T20:28:16


Thanks. The adjusted patch is attached. Also, for the subject of another
patch I'm working on, does the comment at the top of the file suggest
the class is named VoidPluginCallRequest or is it just me ?

Re: Removal of two instances of synchronization on Boolean

Deepak Bhole — 2012-05-17T20:19:57

* Omair Majid <omajid-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org> [2012-05-17 15:56]:

Good point. Yes, please change it to volatile.

Cheers,
Deepak

Re: Removal of two instances of synchronization on Boolean

Omair Majid — 2012-05-17T19:48:01

I could be wrong, but seems to me that read() and write() are running in
different threads. Without some form of synchronization, writes from one
thread may not be visible to the other thread at all. Making
shuttingDown a 'volatile boolean' should be sufficient.

Cheers,
Omair

Re: [RFC][icedtea-web] Use global JarCertVerifier in JNLPClassLoader- tests

Jiri Vanek — 2012-05-17T19:04:06

...

Yap. I will try to help with it.


I'm hesitating with delaying the tests. Imho tests are always forgotten when fix is delivered... There is always something more funny to do then tests. I would prefer th etest have priorirty before fix .. at least some most-issue-describing ones.

Do you think you can include few (cca 5) most describing ones (probably with Make extension)?

Ok. Thanx for clarification.


Good!

Re: Removal of two instances of synchronization on Boolean

Deepak Bhole — 2012-05-17T19:44:23

* Adam Domurad <adomurad-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org> [2012-05-17 15:39]:

Hi Adam,

Right, I don't think synchronization is needed because the value is
modified only once. The second lock below locks just to read, and all it
does with the value is determine whether to print a stack trace.

OK for 1.1/1.2/HEAD from me, but a second review is advisable as I was
already in favor of this approach before posting.

Cheers,
Deepak

Re: [rfc] [icedtea-web] make links

Deepak Bhole — 2012-05-17T19:42:22

* Jiri Vanek <jvanek-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org> [2012-05-17 15:28]:

What if something goes wrong during testing and it exits before
unlinking? The user system would be set to use the wrong plugin -- worse
yet, it could be without the user's knowledge.

Cheers,
Deepak

[RFC][icedtea-web] Removal of two instances of synchronization onBoolean

Adam Domurad — 2012-05-17T19:41:03


Woops, forgot to add [RFC][icedtea-web]. Added in this reply's header.

Removal of two instances of synchronization on Boolean

Adam Domurad — 2012-05-17T19:38:10

Hello all. Tiny patch here to remove two instances of synchronization on
Boolean (considered bad practice as typically only two Boolean objects
exist).

While I was not entirely sure what should be done about the Boolean
synchronization, Deepak's opinion was that the synchronization was not
needed, so I submitted this small patch.
2012-05-17  Adam Domurad  <adomurad-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>

        * plugin/icedteanp/java/sun/applet/PluginStreamHandler.java:
Removed 
        unnecessary synchronization on Boolean (dangerous) for code that
did
        not require synchronization.

Re: [rfc] [icedtea-web] make links

Jiri Vanek — 2012-05-17T19:31:45

Tests will definitely not! I also do not believe  make links will do not harm. They are linking and unlinking correctly. And are linking correct stuff to correct place. Maybe I should run unlink*  after each test run (but I dont like this idea)? Now the unlink is depending on make clean. But make links must be called manually, so there is no danger of being invoked by mistake. And if icedte-web is linked incorrectly there is test to catch it.

J.

Re: [rfc] [icedtea-web] make links

Deepak Bhole — 2012-05-17T19:17:43

* Jiri Vanek <jvanek-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org> [2012-05-17 15:15]:

Oh it is not evil. I have nothing against testing an installed
application. I just want to make sure that something as innocuous as
'make test' is not going to nuke my system installation.

Cheers,
Deepak

Re: [rfc] [icedtea-web] make links

Jiri Vanek — 2012-05-17T19:18:31

Yes we are. What do you think about stopping of testsuite in case that prefix will not be specified?
But I'm confused to. Normal user will never run run-netx-dist-tests. This family of targets will be always run by someone who understand the stuff. And if not, it will not make any harm. I still do not understand why is it so evil to test installed application (as eg jtreg is dooing).

Looking forward for "whats going to happen" :)
J.

/hg/icedtea-web: Went through the source of IcedTeaWeb with Find...

2012-05-17T18:14:10

changeset 7151720a2f5b in /hg/icedtea-web
details: http://icedtea.classpath.org/hg/icedtea-web?cmd=changeset;node=7151720a2f5b
author: Adam Domurad <adomurad-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
date: Thu May 17 14:14:03 2012 -0400

Went through the source of IcedTeaWeb with FindBugs and went over all reported cases of == being used to compare String's. Some usage cases were valid (eg, .equals eventually called, magic String value). I noted one such usage case. The others were changed to .equals calls.


diffstat:

 ChangeLog                                                        |  14 ++++++++++
 netx/net/sourceforge/jnlp/JNLPFile.java                          |   2 +-
 netx/net/sourceforge/jnlp/SecurityDesc.java                      |   4 +-
 netx/net/sourceforge/jnlp/Version.java                           |   5 ++-
 plugin/icedteanp/java/sun/applet/GetMemberPluginCallRequest.java |   2 +-
 plugin/icedteanp/java/sun/applet/PluginCallRequestFactory.java   |  10 +++---
 6 files changed, 26 insertions(+)