gmane.comp.java.openjdk.build.devel

Re: Preserving changeset authorship (was Re: PING: [PATCH] Enabledebug info on all libraries for OpenJDK builds)

David Holmes — 2013-05-22T04:40:40

Before the push up there is a sync down and we need to be sure that the 
new combination is still working.


No, as I already said there is a heap of testing that happens to a group 
repo before it can be pushed to main. So the only way to avoid going 
through a group repo is to have the same testing applied as a group repo.

David
-----

Re: BUILD_JOBJC woes on Mac

David Holmes — 2013-05-22T04:20:45

So has a bug been filed yet? :)

I think some further investigation is still needed because gensrc_jobjc 
is being used in some places and not others and I'd want to verify they 
are all supposed to be the same thing.

David

Re: Windows configure "issues"

Mario Torre — 2013-05-21T23:02:10

I fully agree with this point of view.

I don't think that this conflict with the idea of a wiki companion, this
can be done and surely would be of help, but copy-paste instructions should
be with the code. I also think that since we need to keep in sync the
readme with the wiki, the problem with the overhead of the process doesn't
really change (with the risk of then having an outdated readme).

Cheers,
Mario
Il giorno 22/mag/2013 00:26, <mark.reinhold-QHcLZuEGTsvQT0dZR+AlfA< at >public.gmane.org> ha scritto:

Re: Windows configure "issues"

2013-05-21T22:25:58

2013/5/21 6:54 -0700, gnu.andrew-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org:

I agree, on all three counts.  How-to-build documents, just like unit
tests, belong with the code to which they apply.  Posting them on a
wiki just increases inconvenience and invites confusion.

- Mark

Re: Windows configure "issues"

Andrew Hughes — 2013-05-21T21:11:19

----- Original Message -----

True.  But it's the process that needs to be changed in that case, because
it also applies to other patches.  Working around it doesn't help.

A sponsor is only needed for those without commit access.  It's pretty easy
to get a review.  Are we any further to being able to get access to the bug
system, which is long overdue?

Thanks,

hg: jdk8/build/hotspot: 46 new changesets

2013-05-21T21:51:04

Changeset: 6114c49b31b5
Author:    amurillo
Date:      2013-05-10 11:27 -0700
URL:       http://hg.openjdk.java.net/jdk8/build/hotspot/rev/6114c49b31b5

8014279: new hotspot build - hs25-b33
Reviewed-by: jcoomes

! make/hotspot_version

Changeset: 712a1e9c91f3
Author:    coleenp
Date:      2013-05-07 09:46 -0400
URL:       http://hg.openjdk.java.net/jdk8/build/hotspot/rev/712a1e9c91f3

8013063: nsk/jvmti/RetransformClasses/retransform001 failed debug version on os::free
Summary: Clear out class_file_bytes so they aren't deallocated twice
Reviewed-by: dcubed, sspitsyn

! src/share/vm/prims/jvmtiRedefineClasses.cpp

Changeset: 4674e409a9e6
Author:    coleenp
Date:      2013-05-07 18:51 -0400
URL:       http://hg.openjdk.java.net/jdk8/build/hotspot/rev/4674e409a9e6

8014024: NPG: keep compiled ic methods from being deallocated in redefine classes
Summary: Walk the compiledIC relocation records to keep Method* from being deallocated.
Reviewed-by: dlong, kvn

! src/share/vm/code/nmethod.cpp

Changeset: a1cc1d1e7c

Re: Preserving changeset authorship (was Re: PING: [PATCH] Enabledebug info on all libraries for OpenJDK builds)

Dalibor Topic — 2013-05-21T21:06:09

For the same reason jdk8-external wouldn't work. That's not how the flow of changes is set up to go - it's from the lowest rung upwards to the highest (and back), not sideways across. ;)

cheers,
dalibor topic

Re: Windows configure "issues"

Andrew Hughes — 2013-05-21T20:54:16

----- Original Message -----

Another reason is it makes the software self-contained; I don't need Internet
access and a web browser to be able to build it.

Re: Disable overrides during jdk build

Andrew Hughes — 2013-05-21T20:49:42

----- Original Message -----

Is there an option in the new build to turn on all warnings, as there
was in the old (JAVAC_MAX_WARNINGS if I recall correctly)?

Re: Preserving changeset authorship (was Re: PING: [PATCH] Enabledebug info on all libraries for OpenJDK builds)

Andrew Hughes — 2013-05-21T20:47:49

----- Original Message -----

Why do they need to be run through jprt twice?

external repo -> jprt -> hotspot-main

seems sufficient to me.

hg: jdk8/build/nashorn: 19 new changesets

2013-05-21T20:41:04

Changeset: 4ce88eec5078
Author:    katleman
Date:      2013-05-16 12:16 -0700
URL:       http://hg.openjdk.java.net/jdk8/build/nashorn/rev/4ce88eec5078

Added tag jdk8-b90 for changeset 67ca019e3713

! .hgtags

Changeset: b754fb89367d
Author:    jlaskey
Date:      2013-04-30 10:05 -0300
URL:       http://hg.openjdk.java.net/jdk8/build/nashorn/rev/b754fb89367d

8006220: Simplify PropertyMaps
Reviewed-by: hannesw, lagergren
Contributed-by: james.laskey-QHcLZuEGTsvQT0dZR+AlfA< at >public.gmane.org

! src/jdk/nashorn/internal/codegen/MapCreator.java
! src/jdk/nashorn/internal/codegen/ObjectClassGenerator.java
! src/jdk/nashorn/internal/codegen/ObjectCreator.java
! src/jdk/nashorn/internal/objects/NativeDebug.java
! src/jdk/nashorn/internal/objects/NativeJSAdapter.java
! src/jdk/nashorn/internal/runtime/AccessorProperty.java
! src/jdk/nashorn/internal/runtime/Context.java
! src/jdk/nashorn/internal/runtime/Property.java
! src/jdk/nashorn/internal/runtime/PropertyHashMap.java
! src/jdk/nashorn/internal/runtime/Property

hg: jdk8/build/langtools: 45 new changesets

2013-05-21T20:38:48

Changeset: 9717b9523d46
Author:    katleman
Date:      2013-05-16 12:16 -0700
URL:       http://hg.openjdk.java.net/jdk8/build/langtools/rev/9717b9523d46

Added tag jdk8-b90 for changeset e19283cd30a4

! .hgtags

Changeset: abd153854f16
Author:    jjg
Date:      2013-05-03 09:56 -0700
URL:       http://hg.openjdk.java.net/jdk8/build/langtools/rev/abd153854f16

8012728: Normalize < at >ignore comments on langtools tests
Reviewed-by: vromero, mcimadamore

! test/com/sun/javadoc/_template/Template.java
! test/com/sun/javadoc/_template/TemplateComplete.java
! test/com/sun/javadoc/testTypeAnnotations/TestTypeAnnotations.java
! test/com/sun/javadoc/typeAnnotations/smoke/TestSmoke.java
! test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest1.java
! test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest2.java
! test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass.java
! test/tools/javac/annotations/typeAnnotations/newlocations/MultiCatch.java
! test/

hg: jdk8/build/jdk: 102 new changesets

2013-05-21T20:12:07

Changeset: 08c28cdacd7b
Author:    katleman
Date:      2013-05-16 12:15 -0700
URL:       http://hg.openjdk.java.net/jdk8/build/jdk/rev/08c28cdacd7b

Added tag jdk8-b90 for changeset c63eda8f6300

! .hgtags

Changeset: 4dd6f7bb8bbd
Author:    simonis
Date:      2013-05-06 12:57 -0700
URL:       http://hg.openjdk.java.net/jdk8/build/jdk/rev/4dd6f7bb8bbd

7191872: Xrender: No text displayed using 64 bit JDK on solaris11-sparc
Reviewed-by: prr, ceisserer

! src/share/classes/sun/font/FileFontStrike.java
! src/share/classes/sun/font/GlyphList.java
! src/solaris/classes/sun/font/XRGlyphCacheEntry.java
! src/solaris/native/sun/java2d/x11/XRBackendNative.c

Changeset: 23f7ff502a89
Author:    jgodinez
Date:      2013-05-07 09:32 -0700
URL:       http://hg.openjdk.java.net/jdk8/build/jdk/rev/23f7ff502a89

8011069: Printing: NullPointerException since jdk8 b82 showing native Page Setup Dialog.
Reviewed-by: bae, prr

! src/macosx/classes/sun/lwawt/macosx/CPrinterJob.java
! src/share/classes/sun/print/RasterPrinterJob.ja

hg: jdk8/build/jaxp: 8 new changesets

2013-05-21T20:07:33

Changeset: f39d61028d2f
Author:    katleman
Date:      2013-05-16 12:14 -0700
URL:       http://hg.openjdk.java.net/jdk8/build/jaxp/rev/f39d61028d2f

Added tag jdk8-b90 for changeset 668acc0e1034

! .hgtags

Changeset: 452e1a182907
Author:    dfuchs
Date:      2013-05-06 18:50 +0200
URL:       http://hg.openjdk.java.net/jdk8/build/jaxp/rev/452e1a182907

8008738: Issue in com.sun.org.apache.xml.internal.serializer.Encodings causes some JCK tests to fail intermittently
Summary: Encodings.java sometimes creates EncodingInfo objects whose java names are not recognized by the Charset API. This patch fixes that issue.
Reviewed-by: joehw, alanb

! src/com/sun/org/apache/xml/internal/serializer/Encodings.java

Changeset: 1e8d98012ab8
Author:    joehw
Date:      2013-05-08 23:38 -0700
URL:       http://hg.openjdk.java.net/jdk8/build/jaxp/rev/1e8d98012ab8

8011653: Upgrade JDK8 to JAXP 1.5
Reviewed-by: alanb, dfuchs

! src/com/sun/org/apache/xalan/internal/XalanConstants.java
! src/com/sun/org/apache/xalan/internal/ut

hg: jdk8/build/jaxws: Added tag jdk8-b90 for changeset 3e5b9ea5ac35

2013-05-21T20:07:59

Changeset: 0bb1a9fa56b0
Author:    katleman
Date:      2013-05-16 12:14 -0700
URL:       http://hg.openjdk.java.net/jdk8/build/jaxws/rev/0bb1a9fa56b0

Added tag jdk8-b90 for changeset 3e5b9ea5ac35

! .hgtags

hg: jdk8/build/hotspot: Added tag jdk8-b90 for changeset 1ae0472ff3a0

2013-05-21T20:06:03

Changeset: 1cdbd42c3e49
Author:    katleman
Date:      2013-05-16 12:14 -0700
URL:       http://hg.openjdk.java.net/jdk8/build/hotspot/rev/1cdbd42c3e49

Added tag jdk8-b90 for changeset 1ae0472ff3a0

! .hgtags

hg: jdk8/build/corba: Added tag jdk8-b90 for changeset c8286839d0df

2013-05-21T20:05:23

Changeset: 8f7ffb296385
Author:    katleman
Date:      2013-05-16 12:14 -0700
URL:       http://hg.openjdk.java.net/jdk8/build/corba/rev/8f7ffb296385

Added tag jdk8-b90 for changeset c8286839d0df

! .hgtags

hg: jdk8/build: 5 new changesets

2013-05-21T20:05:16

Changeset: 83b519cafa68
Author:    katleman
Date:      2013-05-16 12:13 -0700
URL:       http://hg.openjdk.java.net/jdk8/build/rev/83b519cafa68

Added tag jdk8-b90 for changeset 69b773a221b9

! .hgtags

Changeset: e2eb6bc06621
Author:    mduigou
Date:      2013-05-08 21:42 -0700
URL:       http://hg.openjdk.java.net/jdk8/build/rev/e2eb6bc06621

8014269: Add missing .PHONY targets to Main.gmk
Reviewed-by: mchung, tbell

! common/makefiles/Main.gmk

Changeset: 49ea9293fa49
Author:    lana
Date:      2013-05-09 14:23 -0700
URL:       http://hg.openjdk.java.net/jdk8/build/rev/49ea9293fa49

Merge


Changeset: 40bba0507f76
Author:    lana
Date:      2013-05-17 10:06 -0700
URL:       http://hg.openjdk.java.net/jdk8/build/rev/40bba0507f76

Merge


Changeset: e83abb0a04ab
Author:    katleman
Date:      2013-05-21 12:51 -0700
URL:       http://hg.openjdk.java.net/jdk8/build/rev/e83abb0a04ab

Merge

Re: Windows configure "issues"

Volker Simonis — 2013-05-21T19:17:35

You're right, but the problem is that the process of updating the
instructions is much too heavyweight (getting a BugID, getting reviews,
getting a sponsor who will push the changes,..).

The other problem is that there exist so many different OS
releases/distributions and compiler versions which people may use for
building that I'm afraid the "official" README in the repo will never cover
them all. So I'd rather take a pragmatic approach of having more build
documentation in a central place in the Wiki than having a super-accurate
documentation in the repository for a system nobody can even set up today
(e.g. because the software mentioned there isn't available anymore).

I therefore like Kelly's suggestion of having a "bare bones" version in the
repository and more details and updates in the Wiki.

Re: MacOS build tool selections for JDK8

David DeHaven — 2013-05-21T19:03:52


No, 7u has not been changed. At least, whenever I need to have someone test a fix, they have to test on 10.8 :)

-DrD-

[PATCH] Provide debugging information for programs

Andrew Hughes — 2013-05-21T18:31:56

Hi all,

The following webrevs:

Root: http://cr.openjdk.java.net/~andrew/build/debugging/webrev.02/
JDK: http://cr.openjdk.java.net/~andrew/build/debugging/webrev.03/

1.  Enable debugging on programs for OpenJDK builds
(unclear why this is disabled; the comment says "Programs don't get the debug symbols added in the old build. It's not clear if this is intentional" but all our builds of 6 & 7 have debug info, making this a regression)
2.  Turn on debugging symbols for unpack200 and jexec which seem to have been missed.

Ok?  If so, can I have a bug ID for this, please?

Thanks,