gmane.comp.java.openjdk.awt.devel

hg: jdk8/awt/jdk: 2 new changesets

2013-05-17T10:12:23

Changeset: e944b78812a8
Author:    kshefov
Date:      2013-05-17 14:08 +0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/e944b78812a8

8014721: TEST_BUG: java/awt/TrayIcon/DragEventSource/DragEventSource.java fails with java.lang.UnsupportedOperationException
Reviewed-by: anthony, serb

! test/java/awt/TrayIcon/DragEventSource/DragEventSource.java

Changeset: 281add053efe
Author:    kshefov
Date:      2013-05-17 14:11 +0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/281add053efe

8013426: TEST_BUG: java/awt/datatransfer/HTMLDataFlavors/HTMLDataFlavorTest.java fails with "RuntimeException: The data should be available" on Linux
Reviewed-by: anthony, serb

! test/java/awt/datatransfer/HTMLDataFlavors/HTMLDataFlavorTest.java

Re: [8] Review request for CR 8014721 TEST_BUG: java/awt/TrayIcon/DragEventSource/DragEventSource.java fails with java.lang.UnsupportedOperationException

Anthony Petrov — 2013-05-17T09:47:03

Looks great. Thank you.

--
best regards,
Anthony

On 05/17/2013 01:45 PM, Konstantin Shefov wrote:

Re: [8] Review request for CR 8014721 TEST_BUG: java/awt/TrayIcon/DragEventSource/DragEventSource.java fails with java.lang.UnsupportedOperationException

Konstantin Shefov — 2013-05-17T09:45:47

Thanks for reviewing,
new webrev is http://cr.openjdk.java.net/~kshefov/8014721/webrev.01

On 17-May-13 13:43, Anthony Petrov wrote:

Re: [8] Review request for CR 8014721 TEST_BUG: java/awt/TrayIcon/DragEventSource/DragEventSource.java fails with java.lang.UnsupportedOperationException

Konstantin Shefov — 2013-05-17T09:38:08

On 17-May-13 13:20, Anthony Petrov wrote:
NO NPE is thrown, because SystemTray.isSupported is static method.
But I will correct the test by replacing tray.isSupported(); to 
SystemTray.isSupported();

Re: [8] Review request for CR 8014721 TEST_BUG: java/awt/TrayIcon/DragEventSource/DragEventSource.java fails with java.lang.UnsupportedOperationException

Anthony Petrov — 2013-05-17T09:43:59

Thanks. With such a change I'm fine with the fix.

--
best regards,
Anthony

On 05/17/2013 01:38 PM, Konstantin Shefov wrote:

Re: [8] Review request for CR 8014721 TEST_BUG: java/awt/TrayIcon/DragEventSource/DragEventSource.java fails with java.lang.UnsupportedOperationException

Anthony Petrov — 2013-05-17T09:24:52

I see that the SystemTray.isSupported() is a static method actually. 
Could you please call it explicitly as a static method instead of 
calling it on a (not-yet-created) instance?

--
best regards,
Anthony

On 05/17/2013 01:20 PM, Anthony Petrov wrote:

Re: [8] Review request for CR 8014721 TEST_BUG: java/awt/TrayIcon/DragEventSource/DragEventSource.java fails with java.lang.UnsupportedOperationException

Anthony Petrov — 2013-05-17T09:20:05

Hi Konstantin,

Did you run the test after your modification? I believe it should now 
fail with an NPE.

--
best regards,
Anthony

On 05/16/2013 02:19 PM, Konstantin Shefov wrote:

hg: jdk8/awt/jdk: 7079254: Toolkit eventListener leaksmemory

2013-05-17T07:04:12

Changeset: 7a8a8e31a126
Author:    pchelko
Date:      2013-05-17 11:02 +0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7a8a8e31a126

7079254: Toolkit eventListener leaks memory
Reviewed-by: serb, art

! src/share/classes/java/awt/Component.java
! src/share/classes/java/awt/Container.java
+ test/java/awt/LightweightDispatcher/LWDispatcherMemoryLeakTest.java

Re: [8] Review Request for JDK-7079254: Toolkit eventListener leaks memory

Sergey Bylokhov — 2013-05-16T16:16:04

Hi, Petr.
Fix looks good.

On 16.05.2013 16:03, Petr Pchelko wrote:

Re: [7u] Request for review: 8000629 [macosx] Blurry rendering with Java 7 on Retina display

Anthony Petrov — 2013-05-16T14:01:13

Hi Sergey,

The fix looks fine to me.

--
best regards,
Anthony

On 05/13/13 19:24, Sergey Bylokhov wrote:

Re: Fwd: Review request for 8014724: Broken 7u-dev build

Sergey Bylokhov — 2013-05-16T12:51:43

Fix looks good.
On 16.05.2013 16:50, Leonid Romanov wrote:

Fwd: Review request for 8014724: Broken 7u-dev build

Leonid Romanov — 2013-05-16T12:50:00

Hi guys,
Could any of you review the fix for the broken build, please? It's a trivial, one line fix. I just need the formal reviewer.

Thanks,
Leonid. 

Begin forwarded message:

Re: [8] Review Request for JDK-7079254: ToolkiteventListener leaks memory

Petr Pchelko — 2013-05-16T12:03:18

Hello, Sergey.

Thank you for the review. Please see the updated webrev at:
http://cr.openjdk.java.net/~pchelko/7079254/webrev.01/

With best regards. Petr.

On May 16, 2013, at 3:48 PM, Sergey Bylokhov wrote:

Re: [8] Review Request for JDK-7079254: Toolkit eventListener leaks memory

Sergey Bylokhov — 2013-05-16T11:48:59

Hi, Petr.
Looks like the test has incorrect header and < at >bug.

On 16.05.2013 12:48, Petr Pchelko wrote:

Re: [8] Review request for CR 8014721 TEST_BUG: java/awt/TrayIcon/DragEventSource/DragEventSource.java fails with java.lang.UnsupportedOperationException

Sergey Bylokhov — 2013-05-16T11:17:55

Hi, Konstantin.
Fix looks good.

On 16.05.2013 14:19, Konstantin Shefov wrote:

[8] Review request for CR 8014721 TEST_BUG: java/awt/TrayIcon/DragEventSource/DragEventSource.java fails with java.lang.UnsupportedOperationException

Konstantin Shefov — 2013-05-16T10:19:40

Hello,

Please review a fix for the issue:

8014721 TEST_BUG: java/awt/TrayIcon/DragEventSource/DragEventSource.java 
fails with java.lang.UnsupportedOperationException

http://bugs.sun.com/view_bug.do?bug_id=8014721

The webrev is: http://cr.openjdk.java.net/~kshefov/8014721/webrev.00/

Thanks,
Konstantin

Re: [8] Review Request for JDK-7079254: Toolkit eventListener leaks memory

Artem Ananiev — 2013-05-16T09:09:05

Hi, Petr,

the fix looks fine.

Thanks,

Artem

On 5/16/2013 12:48 PM, Petr Pchelko wrote:

Re: Review request for CR 2227234 - [macosx] Exception at java.awt.datatransfer on headless mode (only in GUI session)

Artem Ananiev — 2013-05-16T09:11:15

Looks fine.

Thanks,

Artem

On 5/16/2013 12:50 PM, Petr Pchelko wrote:

Re: Review request for CR 2227234 - [macosx] Exception atjava.awt.datatransfer on headless mode (only in GUI session)

Petr Pchelko — 2013-05-16T08:50:28

Hello, AWT Team.

This is a reminder. Could you please review this fix.

With best regards. Petr.

On Mar 14, 2013, at 2:54 PM, Petr Pchelko wrote:

[8] Review Request for JDK-7079254: Toolkit eventListenerleaks memory

Petr Pchelko — 2013-05-16T08:48:23

Hello, AWT Team.

Please review the fix for the issue:
http://bugs.sun.com/view_bug.do?bug_id=7079254
The webrev is available at:
http://cr.openjdk.java.net/~pchelko/7079254/webrev/

This is a very old fix and I have already sent this request, however I did not get any comments that time, so I resending the request.

With best regards. Petr.

Re: RFR(XS): 7196866: CTW fails on Solaris

Phil Race — 2013-05-16T00:30:30

To know whether the fix is appropriate or maybe the best fix,
I'd have to see what classes are loaded in what order.
I can see the JBS bug (external folks can't) but its not really
worth seeing anyway as there's not much info in there :-
http://bugs.sun.com/view_bug.do?bug_id=7196866
seems to contain all the data there is ..

I am still curious about the test envt. that triggered Xrender.

-phil.

On 5/15/13 4:40 PM, Vladimir Kozlov wrote: