gmane.comp.jakarta.tomcat.devel

buildbot failure in ASF Buildbot on tomcat-trunk

2013-05-23T00:46:43

The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/tomcat-trunk/builds/4360

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: bb-vm_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch tomcat/trunk] 1485512
Blamelist: markt

BUILD FAILED: failed compile_1

sincerely,
 -The Buildbot

buildbot success in ASF Buildbot on tomcat-trunk

2013-05-22T23:56:13

The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/tomcat-trunk/builds/4359

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: bb-vm_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch tomcat/trunk] 1485495
Blamelist: markt

Build succeeded!

sincerely,
 -The Buildbot

svn commit: r1485512 - in /tomcat/trunk/test/org/apache/tomcat/websocket: TestWsRemoteEndpoint.java TestWsWebSocketContainer.java TesterSingleMessageClient.java

2013-05-22T23:52:28

Author: markt
Date: Wed May 22 23:52:28 2013
New Revision: 1485512

URL: http://svn.apache.org/r1485512
Log:
Refactor passing of the latch to improve robustness on test failure. Once the session is closed, user properties are no longer accessible.

Modified:
    tomcat/trunk/test/org/apache/tomcat/websocket/TestWsRemoteEndpoint.java
    tomcat/trunk/test/org/apache/tomcat/websocket/TestWsWebSocketContainer.java
    tomcat/trunk/test/org/apache/tomcat/websocket/TesterSingleMessageClient.java

Modified: tomcat/trunk/test/org/apache/tomcat/websocket/TestWsRemoteEndpoint.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/websocket/TestWsRemoteEndpoint.java?rev=1485512&r1=1485511&r2=1485512&view=diff
==============================================================================
--- tomcat/trunk/test/org/apache/tomcat/websocket/TestWsRemoteEndpoint.java (original)
+++ tomcat/trunk/test/org/apache/tomcat/websocket/TestWsRemoteEndpoint.java Wed May 22 23:52:28 2013
< at >< at > -38,6 +38,7 < at >< at > import or

svn commit: r1485495 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2013-05-22T23:13:57

Author: markt
Date: Wed May 22 23:13:56 2013
New Revision: 1485495

URL: http://svn.apache.org/r1485495
Log:
Revert r1485489 - wrong file commited

Modified:
    tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java?rev=1485495&r1=1485494&r2=1485495&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java Wed May 22 23:13:56 2013
< at >< at > -1602,14 +1602,12 < at >< at > public class AprEndpoint extends Abstrac
                                 log.debug("Poller run() adding socket: " +
                                         info.socket);
                             }
+                            removeFromPoller(info.socket);
                             timeouts.remove(info.so

svn commit: r1485490 - /tomcat/trunk/test/org/apache/tomcat/websocket/TesterSingleMessageClient.java

2013-05-22T23:12:15

Author: markt
Date: Wed May 22 23:12:14 2013
New Revision: 1485490

URL: http://svn.apache.org/r1485490
Log:
Revert r1485458. Right idea but that isn't how to do it.

Modified:
    tomcat/trunk/test/org/apache/tomcat/websocket/TesterSingleMessageClient.java

Modified: tomcat/trunk/test/org/apache/tomcat/websocket/TesterSingleMessageClient.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/websocket/TesterSingleMessageClient.java?rev=1485490&r1=1485489&r2=1485490&view=diff
==============================================================================
--- tomcat/trunk/test/org/apache/tomcat/websocket/TesterSingleMessageClient.java (original)
+++ tomcat/trunk/test/org/apache/tomcat/websocket/TesterSingleMessageClient.java Wed May 22 23:12:14 2013
< at >< at > -35,19 +35,19 < at >< at > public class TesterSingleMessageClient {
 
     public static class TesterProgrammaticEndpoint extends Endpoint {
 
-        private CountDownLatch latch = null;
-
         < at >Override
         public void onClose(Session sessi

svn commit: r1485489 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2013-05-22T23:11:47

Author: markt
Date: Wed May 22 23:11:47 2013
New Revision: 1485489

URL: http://svn.apache.org/r1485489
Log:
Revert r1485458. Right idea but that isn't how to do it.

Modified:
    tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java?rev=1485489&r1=1485488&r2=1485489&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java Wed May 22 23:11:47 2013
< at >< at > -1602,12 +1602,14 < at >< at > public class AprEndpoint extends Abstrac
                                 log.debug("Poller run() adding socket: " +
                                         info.socket);
                             }
-                            removeFromPoller(info.socket);
                             time

buildbot failure in ASF Buildbot on tomcat-trunk

2013-05-22T22:53:01

The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/tomcat-trunk/builds/4358

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: bb-vm_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch tomcat/trunk] 1485458
Blamelist: markt

BUILD FAILED: failed compile_1

sincerely,
 -The Buildbot

svn commit: r1485458 - /tomcat/trunk/test/org/apache/tomcat/websocket/TesterSingleMessageClient.java

2013-05-22T22:03:11

Author: markt
Date: Wed May 22 22:03:11 2013
New Revision: 1485458

URL: http://svn.apache.org/r1485458
Log:
Cleaner handling of errors
Session may have been closed after an error so get the latch before it closes.

Modified:
    tomcat/trunk/test/org/apache/tomcat/websocket/TesterSingleMessageClient.java

Modified: tomcat/trunk/test/org/apache/tomcat/websocket/TesterSingleMessageClient.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/websocket/TesterSingleMessageClient.java?rev=1485458&r1=1485457&r2=1485458&view=diff
==============================================================================
--- tomcat/trunk/test/org/apache/tomcat/websocket/TesterSingleMessageClient.java (original)
+++ tomcat/trunk/test/org/apache/tomcat/websocket/TesterSingleMessageClient.java Wed May 22 22:03:11 2013
< at >< at > -35,19 +35,19 < at >< at > public class TesterSingleMessageClient {
 
     public static class TesterProgrammaticEndpoint extends Endpoint {
 
+        private CountDownLatch latch = null;
+
         < at >Ov

Re: Automatic deployment changes

Mark Thomas — 2013-05-22T17:30:49

It should be be, yes.

Mark

Re: Automatic deployment changes

Mark Thomas — 2013-05-22T17:30:04


Correct.

Mark

Re: Automatic deployment changes

Christopher Schultz — 2013-05-22T16:50:42

Mark,

On 5/17/13 3:25 PM, Mark Thomas wrote:

... and a warning will be issued, no?

-chris

Re: Automatic deployment changes

Christopher Schultz — 2013-05-22T16:48:44

Mark,

On 5/17/13 3:04 PM, Mark Thomas wrote:

+1


When you say "added", do you mean a WAR or DIR that exists in the place
where the XML pointed (but was previously impossible to deploy, because
of the missing WAR/DIR)?

-chris

[Bug 54997] SSL Handshake implementation in AsycnChannelWrapperSecure does not handle SSLEngineResult.Status.BUFFER_UNDERFLOW and SSLEngineResult.Status.BUFFER_OVERFLOW states

2013-05-22T14:44:25

https://issues.apache.org/bugzilla/show_bug.cgi?id=54997

Violeta Georgieva <violetagg< at >apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30309|0                           |1
           is patch|                            |
  Attachment #30309|application/octet-stream    |text/plain
          mime type|                            |

[Bug 54999] JSESSIONIDSSO not re-created upon re-authentication on the same request - logout() and login(username,password)

2013-05-22T13:18:26

https://issues.apache.org/bugzilla/show_bug.cgi?id=54999

--- Comment #1 from Keith Mashinter <kmashint< at >yahoo.com> ---
Created attachment 30313
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=30313&action=edit
Fix for Bug 54999 to ensure JSESSIONIDSSO can be re-created

In the Bug comments I chose to < at >override the AuthenticatorBase logout(Request) 
but the more self-consistent place to patch this seems to be in
AuthenticatorBase.register(Request,...) that I've done here against the
tc7.0.x/trunk/tc7.0.x/java/org/apache/catalina/authenticator/AuthenticatorBase.java.

[Bug 54984] multipart/form-data is not always read with correct encoding

2013-05-22T11:42:32

https://issues.apache.org/bugzilla/show_bug.cgi?id=54984

--- Comment #3 from Per Holmberg <holmis83< at >gmail.com> ---
Created attachment 30312
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=30312&action=edit
Multipart demo source

[Bug 54984] multipart/form-data is not always read with correct encoding

2013-05-22T11:36:44

https://issues.apache.org/bugzilla/show_bug.cgi?id=54984

--- Comment #2 from Per Holmberg <holmis83< at >gmail.com> ---
Created attachment 30311
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=30311&action=edit
Multipart demo war

Re: [Bug 48358] JSP-unloading reloaded

Mark Thomas — 2013-05-22T11:32:36

This idiot has been blocked from BZ.

Mark

Re: WebSockets in Tomcat 8 (proxy support and ssl handshake)

Niki Dokovski — 2013-05-22T11:06:09

On Wed, May 22, 2013 at 1:48 PM, Konstantin Kolinko
<knst.kolinko< at >gmail.com>wrote:


Thanks:

buffer underflow
https://issues.apache.org/bugzilla/show_bug.cgi?id=54997

http proxy
https://issues.apache.org/bugzilla/show_bug.cgi?id=55006

[Bug 55006] Add http proxy support for ClientEndpoint using system properties

2013-05-22T11:04:26

https://issues.apache.org/bugzilla/show_bug.cgi?id=55006

--- Comment #1 from Niki Dokovski <nickytd< at >gmail.com> ---
Created attachment 30310
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=30310&action=edit
patch in WsWebSocketContainer

[Bug 55006] New: Add http proxy support for ClientEndpoint using system properties

2013-05-22T11:04:02

https://issues.apache.org/bugzilla/show_bug.cgi?id=55006

            Bug ID: 55006
           Summary: Add http proxy support for ClientEndpoint using system
                    properties
           Product: Tomcat 8
           Version: trunk
          Hardware: PC
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: Catalina
          Assignee: dev< at >tomcat.apache.org
          Reporter: nickytd< at >gmail.com
    Classification: Unclassified

Currently there is no support for utilization of http proxy for
ClientEndpoints. Here is a patch that illustrates the usage of
http(s).proxy(Host)(Port) system properties. A request for improvement in
WebSocket JSR 356 can be found here
https://java.net/jira/browse/WEBSOCKET_SPEC-202

[Bug 48358] JSP-unloading reloaded

2013-05-22T10:58:40

https://issues.apache.org/bugzilla/show_bug.cgi?id=48358

Rainer Jung <rainer.jung< at >kippdata.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P4                          |P2
          Component|Manager application         |Jasper
           Hardware|Other                       |All
                 OS|Windows XP                  |All