gmane.comp.handhelds.moblin.connman

RE: wifi: scan all stored hidden networks relevantly

Grant Erickson — 2013-05-21T00:27:56

Tomasz,

I found this surprising. Why did the callback change from scan_callback to scan_callback_hidden? Isn't the appropriate closure for the scan, scan_callback?

Best,

Grant

[PATCH] service: Restart timeserver polling only for the default service

Patrik Flykt — 2013-05-20T12:37:23

When timeservers are set, restart timeserver polling only if the service
is the the default one.
---
 src/service.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/service.c b/src/service.c
index bba548e..9e79b03 100644
--- a/src/service.c
+++ b/src/service.c
< at >< at > -3210,7 +3210,9 < at >< at > static DBusMessage *set_property(DBusConnection *conn,
 service_save(service);
 timeservers_configuration_changed(service);
 
-__connman_timeserver_sync(service);
+if (service == __connman_service_get_default())
+__connman_timeserver_sync(service);
+
 } else if (g_str_equal(name, "Domains.Configuration") == TRUE) {
 DBusMessageIter entry;
 GString *str;

[PATCH] doc: Document the deprecated RemoveProvider method call

Patrik Flykt — 2013-05-20T09:59:10

Fixes BMC#25958
---
 doc/manager-api.txt |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/doc/manager-api.txt b/doc/manager-api.txt
index ed23c8d..ad07c3d 100644
--- a/doc/manager-api.txt
+++ b/doc/manager-api.txt
< at >< at > -64,6 +64,10 < at >< at > Methodsdict GetProperties()
 
 Possible Errors: [service].Error.InvalidArguments
 
+void RemoveProvider(object path)[deprecated]
+
+Remove a VPN specified by the object path.
+
 void RegisterAgent(object path)
 
 Register new agent for handling user requests.

Re: [PATCH] Tethering: Add the open Wi-Fi Access Point

Tomasz Bursztyka — 2013-05-20T09:58:41

Hi,

NACK from me on this one.

I will pass the discussion whether we want or not such feature.

I will concentrate only on the patch:


This is totally bogus: plugins should _never_ override user's settings.
If you want to be able to reset such properties, you will have to let it 
possible through SetProperty() in technology DBus API, nothing else.


This would be useless if you apply my previous comment about SetProperty().


Ok.

Tomasz

[PATCH] Tethering: Add the open Wi-Fi Access Point

2013-05-20T09:42:42

Sometimes users need create the open Wi-Fi Access Point

---
 include/technology.h |    2 ++
 plugins/wifi.c       |    1 +
 src/technology.c     |   17 +++++++++++++++--
 3 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/include/technology.h b/include/technology.h
index 9fe994c..1d9b333 100644
--- a/include/technology.h
+++ b/include/technology.h
< at >< at > -36,6 +36,8 < at >< at > extern "C" {
 
 struct connman_technology;
 
+void connman_technology_reset_tethering_properties(
+struct connman_technology *technology);
 void connman_technology_tethering_notify(struct connman_technology *technology,
 connman_bool_t enabled);
 int connman_technology_set_regdom(const char *alpha2);
diff --git a/plugins/wifi.c b/plugins/wifi.c
index 5f07869..7960da3 100644
--- a/plugins/wifi.c
+++ b/plugins/wifi.c
< at >< at > -2035,6 +2035,7 < at >< at > static int tech_set_tethering(struct connman_technology *technology,
 }
 
 connman_technology_tethering_notify(technology, FALSE);
+connman_technology_reset_tethering_properties(techn

Re: [PATCH 0/4] Timeserver handling and property saving

Patrik Flykt — 2013-05-20T09:41:31

Applied with v2 for patch 3/4.

Patrik

[PATCH v2 3/4] clock: Implement Load and save for Clock API properties

Patrik Flykt — 2013-05-20T09:24:43

Load and save TimeUpdates and TimezoneUpdates Clock API  properties.
Clock API Timeservers property is already handled by the timeserver
code.

Fixes BMC#25988
---

v2: when loading, use variables to hold the enum and set the main property
    if the values are not *_ UNKNOWN
    This way the startup default value is assigned in one place only

 src/clock.c |   62 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 62 insertions(+)

diff --git a/src/clock.c b/src/clock.c
index 1c16d40..2ce61d9 100644
--- a/src/clock.c
+++ b/src/clock.c
< at >< at > -88,6 +88,65 < at >< at > static enum timezone_updates string2timezone_updates(const char *value)
         return TIMEZONE_UPDATES_UNKNOWN;
 }
 
+static void clock_properties_load(void)
+{
+GKeyFile *keyfile;
+char *str;
+enum time_updates time_value;
+enum timezone_updates timezone_value;
+
+keyfile = __connman_storage_load_global();
+if (keyfile == NULL)
+return;
+
+str = g_key_file_get_string(keyfile, "global", "TimeUpdates", NULL);
+
+time_value

Re: [PATCH] TODO: DHCPv6 DECLINE message support

Patrik Flykt — 2013-05-17T12:22:49

Applied, thanks!

Patrik

Re: [PATCH v2] wifi: scan all stored hidden networks relevantly

Patrik Flykt — 2013-05-17T12:22:27

Applied, thanks!

Patrik

Re: [PATCH v2] README: update information about wpa_supplicant built config

Patrik Flykt — 2013-05-17T12:21:45

Applied, thanks!

Patrik

[PATCH 2/4] timeserver: Check the time update method

Patrik Flykt — 2013-05-17T11:53:27

If the time update method is manual, no NTP time servers are returned.
---
 src/timeserver.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/timeserver.c b/src/timeserver.c
index f934b58..970b8eb 100644
--- a/src/timeserver.c
+++ b/src/timeserver.c
< at >< at > -182,6 +182,9 < at >< at > GSList *__connman_timeserver_get_all(struct connman_service *service)
 char **fallback_ts;
 int index, i;
 
+if (__connman_clock_timeupdates() == TIME_UPDATES_MANUAL)
+return NULL;
+
 service_ts_config = connman_service_get_timeservers_config(service);
 
 /* First add Service Timeservers.Configuration to the list */

[PATCH 0/4] Timeserver handling and property saving

Patrik Flykt — 2013-05-17T11:53:25

Hi,

The two first patches make timeserver handling use TimeUpdates Clock API
property to decide whether to enable NTP timeservers or not.

The third patch adds save and load support for TimeUpdates and
TimezoneUpdates properties so that the desired auto/manual timeserver
handling will be remebered over restarts.

The fourth patch adds a quick test scrip to set these two Clock API
properties.

Cheers,

Patrik


Patrik Flykt (4):
  clock: Export information about time update method
  timeserver: Check the time update method
  clock: Implement Load and save for Clock API properties
  test: Add test script for Clock API

 Makefile.am      |    3 ++-
 src/clock.c      |   71 +++++++++++++++++++++++++++++++++++++++++++++++++-----
 src/connman.h    |    7 ++++++
 src/timeserver.c |    3 +++
 test/set-clock   |   32 ++++++++++++++++++++++++
 5 files changed, 109 insertions(+), 7 deletions(-)
 create mode 100755 test/set-clock

[PATCH 1/4] clock: Export information about time update method

Patrik Flykt — 2013-05-17T11:53:26

---
 src/clock.c   |   11 +++++------
 src/connman.h |    7 +++++++
 2 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/src/clock.c b/src/clock.c
index e2cc19f..1c16d40 100644
--- a/src/clock.c
+++ b/src/clock.c
< at >< at > -29,12 +29,6 < at >< at >
 
 #include "connman.h"
 
-enum time_updates {
-TIME_UPDATES_UNKNOWN = 0,
-TIME_UPDATES_MANUAL  = 1,
-TIME_UPDATES_AUTO    = 2,
-};
-
 enum timezone_updates {
 TIMEZONE_UPDATES_UNKNOWN = 0,
 TIMEZONE_UPDATES_MANUAL  = 1,
< at >< at > -94,6 +88,11 < at >< at > static enum timezone_updates string2timezone_updates(const char *value)
         return TIMEZONE_UPDATES_UNKNOWN;
 }
 
+enum time_updates __connman_clock_timeupdates(void)
+{
+return time_updates_config;
+}
+
 static void append_timeservers(DBusMessageIter *iter, void *user_data)
 {
 int i;
diff --git a/src/connman.h b/src/connman.h
index db84962..1d9f077 100644
--- a/src/connman.h
+++ b/src/connman.h
< at >< at > -56,6 +56,13 < at >< at > DBusMessage *__connman_error_invalid_property(DBusMessage *msg);
 int __connman_manager_init(void);
 void __

[PATCH 3/4] clock: Implement Load and save for Clock API properties

Patrik Flykt — 2013-05-17T11:53:28

Load and save TimeUpdates and TimezoneUpdates Clock API  properties.
Clock API Timeservers property is already handled by the timeserver
code.

Fixes BMC#25988
---
 src/clock.c |   60 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 60 insertions(+)

diff --git a/src/clock.c b/src/clock.c
index 1c16d40..990c80a 100644
--- a/src/clock.c
+++ b/src/clock.c
< at >< at > -88,6 +88,63 < at >< at > static enum timezone_updates string2timezone_updates(const char *value)
         return TIMEZONE_UPDATES_UNKNOWN;
 }
 
+static void clock_properties_load(void)
+{
+GKeyFile *keyfile;
+char *str;
+
+keyfile = __connman_storage_load_global();
+if (keyfile == NULL)
+return;
+
+str = g_key_file_get_string(keyfile, "global", "TimeUpdates", NULL);
+
+time_updates_config = string2time_updates(str);
+if (time_updates_config == TIME_UPDATES_UNKNOWN)
+time_updates_config = TIME_UPDATES_AUTO;
+
+g_free(str);
+
+str = g_key_file_get_string(keyfile, "global", "TimezoneUpdates",
+NULL);
+
+timezone_updates_con

[PATCH 4/4] test: Add test script for Clock API

Patrik Flykt — 2013-05-17T11:53:29

---
 Makefile.am    |    3 ++-
 test/set-clock |   32 ++++++++++++++++++++++++++++++++
 2 files changed, 34 insertions(+), 1 deletion(-)
 create mode 100755 test/set-clock

diff --git a/Makefile.am b/Makefile.am
index 04677ac..f05b755 100644
--- a/Makefile.am
+++ b/Makefile.am
< at >< at > -331,7 +331,8 < at >< at > test_scripts = test/get-state test/list-services \
 test/test-session test/test-supplicant \
 test/test-new-supplicant test/service-move-before \
 test/set-global-timeservers test/get-global-timeservers \
-test/set-nameservers test/set-domains test/set-timeservers
+test/set-nameservers test/set-domains test/set-timeservers \
+test/set-clock
 
 test_scripts += test/vpn-connect test/vpn-disconnect test/vpn-get \
 test/monitor-vpn test/vpn-property
diff --git a/test/set-clock b/test/set-clock
new file mode 100755
index 0000000..a9db3e3
--- /dev/null
+++ b/test/set-clock
< at >< at > -0,0 +1,32 < at >< at >
+#!/usr/bin/python
+
+import sys
+import dbus
+
+def print_usage():
+print "Usage: %s TimeUpdates|TimezoneUpdates manua

[PATCH v2] README: update information about wpa_supplicant built config

Tomasz Bursztyka — 2013-05-17T11:45:00

---

Small typo fixed

 README | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/README b/README
index bfb246a..161c535 100644
--- a/README
+++ b/README
< at >< at > -274,14 +274,21 < at >< at > CONFIG_WPS=y
 CONFIG_AP=y
 CONFIG_CTRL_IFACE_DBUS_NEW=y
 
-and, add:
+add:
 
 CONFIG_BGSCAN_SIMPLE=y
 
 This last option will enable the support of background scanning while being
 connected, which is necessary when roaming on wifi.
 
-It is recommended to use wpa_supplicant 0.8.x or 1.x or later.
+and finally:
+
+CONFIG_AUTOSCAN_EXPONENTIAL=y
+
+This will enable the exact same function as bgscan but while being
+disconnected.
+
+It is recommended to use wpa_supplicant 1.x or later.
 
 
 VPN

[PATCH v4 11/12] session_policy_local: Set session identification method

Daniel Wagner — 2013-05-17T11:08:33

From: Daniel Wagner <daniel.wagner< at >bmw-carit.de>

For SELinux we need to store the complete context for iptables
to work.
---
 plugins/session_policy_local.c | 44 +++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 43 insertions(+), 1 deletion(-)

diff --git a/plugins/session_policy_local.c b/plugins/session_policy_local.c
index d9f9aef..8a25c3c 100644
--- a/plugins/session_policy_local.c
+++ b/plugins/session_policy_local.c
< at >< at > -88,6 +88,7 < at >< at > struct policy_group {
 /* A struct policy_config object is created and owned by a session. */
 struct policy_config {
 char *selinux;
+char *selinux_context;
 char *uid;
 GSList *gids;
 
< at >< at > -173,12 +174,18 < at >< at > static void finish_create(struct policy_config *policy,
 group = g_hash_table_lookup(selinux_hash, policy->selinux);
 if (group != NULL) {
 set_policy(policy, group);
+
+policy->config->id_type = CONNMAN_SESSION_ID_TYPE_LSM;
+policy->config->id = g_strdup(policy->selinux_context);
 goto done;
 }
 
 group = g_hash_table_lookup(uid_hash, polic

[PATCH v4 09/12] session_policy_local: Retrieve UID/GID from session user

Daniel Wagner — 2013-05-17T11:08:31

From: Daniel Wagner <daniel.wagner< at >bmw-carit.de>

When the session core ask to create a configuration, then we
first ask the D-Bus server which UID/GID the session belongs to.
If possible we also ask for the SELinux context. Then we try
to figure out which file containts the configuration for
SElinux, UID or GID identification.

The order of matching preference is SELinux, UID and finally GID.
---
 plugins/session_policy_local.c | 204 ++++++++++++++++++++++++++++++++++++-----
 1 file changed, 179 insertions(+), 25 deletions(-)

diff --git a/plugins/session_policy_local.c b/plugins/session_policy_local.c
index f820bd4..d9f9aef 100644
--- a/plugins/session_policy_local.c
+++ b/plugins/session_policy_local.c
< at >< at > -27,6 +27,9 < at >< at >
 #include <string.h>
 #include <sys/inotify.h>
 #include <sys/stat.h>
+#include <sys/types.h>
+#include <pwd.h>
+#include <grp.h>
 
 #include <glib.h>
 
< at >< at > -49,8 +52,10 < at >< at > static DBusConnection *connection;
 static GHashTable *file_hash;    /* (filename, policy_file) */
 static GHashTable

[PATCH v4 07/12] session_policy_local: Rework policy file handling

Daniel Wagner — 2013-05-17T11:08:29

From: Daniel Wagner <daniel.wagner< at >bmw-carit.de>

The old assumption was that a config file is associtated
with one session only. With introducing UID/GID support a policy
might be used for several sessions. Furthermore, it was assumed
that the file name is the key/ident to identify a session and
a file containts exactly one policy.

Here are the new rules for writing a policy file.

- A valid file name contains letters or numbers and must have a '.policy'
  suffix.
- The file name has not semantical meaning
- A policy file may contain contain more than 1 policy
- Each policy entry starts with 'policy_'
- Each policy entry shall have one and exactly one valid key (e.g. selinux)

And now some comments on the implementation. We have two main hash
tables, file_hash and session_hash which own 'the file' respectively
the session config. Additionally we have a hash table which connects a
policy with a session (selinux_hash).
---
 plugins/session_policy_local.c | 400 ++++++++++++++++++++++++++---------------
 1 fil

[PATCH v4 12/12] session-test: Add tests for session_policy_local

Daniel Wagner — 2013-05-17T11:08:34

From: Daniel Wagner <daniel.wagner< at >bmw-carit.de>

Use the UID as identification.
---
 tools/session-test.c | 151 +++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 151 insertions(+)

diff --git a/tools/session-test.c b/tools/session-test.c
index c296b95..ac91894 100644
--- a/tools/session-test.c
+++ b/tools/session-test.c
< at >< at > -24,11 +24,16 < at >< at >
 #endif
 
 #include <stdio.h>
+#include <unistd.h>
+#include <pwd.h>
+#include <sys/types.h>
 
 #include <gdbus.h>
 
 #include "session-test.h"
 
+#define POLICYDIR STORAGEDIR "/session_policy_local"
+
 enum test_session_state {
 TEST_SESSION_STATE_0 = 0,
 TEST_SESSION_STATE_1 = 1,
< at >< at > -495,6 +500,149 < at >< at > static gboolean test_session_connect_free_ride(gpointer data)
 return FALSE;
 }
 
+static void policy_save(GKeyFile *keyfile, char *pathname)
+{
+gchar *data = NULL;
+gsize length = 0;
+GError *error = NULL;
+
+data = g_key_file_to_data(keyfile, &length, NULL);
+
+if(!g_file_set_contents(pathname, data, length, &error)) {
+DBG("Failed to store

[PATCH v4 08/12] session_policy_local: Remove struct create_data

Daniel Wagner — 2013-05-17T11:08:30

From: Daniel Wagner <daniel.wagner< at >bmw-carit.de>

Instead we use struct policy_data from the beginning.
---
 plugins/session_policy_local.c | 43 ++++++++++++++----------------------------
 1 file changed, 14 insertions(+), 29 deletions(-)

diff --git a/plugins/session_policy_local.c b/plugins/session_policy_local.c
index 4b17a4c..f820bd4 100644
--- a/plugins/session_policy_local.c
+++ b/plugins/session_policy_local.c
< at >< at > -52,10 +52,6 < at >< at > static GHashTable *session_hash; /* (connman_session, policy_config) */
 /* Global lookup table for mapping sessions to policies */
 static GHashTable *selinux_hash; /* (lsm context, policy_group) */
 
-struct create_data {
-struct connman_session *session;
-};
-
 /*
  * A instance of struct policy_file is created per file in
  * POLICYDIR.
< at >< at > -156,31 +152,19 < at >< at > static char *parse_selinux_type(const char *context)
 return ident;
 }
 
-static struct policy_config *create_policy(void)
-{
-struct policy_config *policy;
-
-policy = g_new0(struct policy_config, 1);
-
-DBG("pol