gmane.comp.graphics.openscenegraph.cvs

Re: Osg submission

Robert Osfield — 2013-05-21T10:23:35

Thanks for the name clarification Sebastien.

Thanks to Valeriy for the change, now merged and submitted to svn/trunk.

On 15 May 2013 09:44, Sebastian Messerschmidt
<sebastian.messerschmidt< at >gmx.de> wrote:
_______________________________________________
osg-submissions mailing list
osg-submissions< at >lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Re: Strange code in Dragger handle

Robert Osfield — 2013-05-21T09:48:35

Thanks Alexander, change looks appropriate now merged and submitted to
svn/trunk.

On 16 May 2013 13:41, Alexander Sinditskiy <verybigbadboy-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org> wrote:

Re: Texture Buffer Object

Paweł Księżopolski — 2013-05-20T17:25:11

Hi,

After a while I found that osg::Texture::applyTexParameters() used with TextureBuffer may cause some OpenGL errors ( applying texture filters and wraps to TextureBuffer makes no sense ) so I fixed it. Also added proper file structure to zip file.

Thank you!

Cheers,
Paweł

------------------
Read this topic online here:
http://forum.openscenegraph.org/viewtopic.php?p=54065#54065




Attachments: 
http://forum.openscenegraph.org//files/texturebuffer_104.zip


_______________________________________________
osg-submissions mailing list
osg-submissions< at >lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Strange code in Dragger handle

Alexander Sinditskiy — 2013-05-16T12:41:07

Hi,

I just noticed that Dragger allways handle events even when 
handle(const PointerInfo&, const osgGA::GUIEventAdapter&, osgGA::GUIActionAdapter&)
returns false.
I think it is not correct.

patch

Code:

diff --git a/src/osgManipulator/Dragger.cpp b/src/osgManipulator/Dragger.cpp
index a693f7a..886d9b1 100644
--- a/src/osgManipulator/Dragger.cpp
+++ b/src/osgManipulator/Dragger.cpp
< at >< at > -403,9 +403,11 < at >< at > bool Dragger::handle(const osgGA::GUIEventAdapter& ea, osgGA::GUIActionAdapter&
                                 _pointer.setCamera(rootCamera);
                                 _pointer.setMousePosition(ea.getX(), ea.getY());

-                                dragger->handle(_pointer, ea, aa);
-                                dragger->setDraggerActive(true);
-                                handled = true;
+                                if(dragger->handle(_pointer, ea, aa))
+                                {
+                                  dragger->setDraggerActive(true);
+

Re: osg-submissions Digest, Vol 71, Issue 4

Валерий Дубов — 2013-05-15T21:17:24

Hi Robert, Sebastian is right, but i'm used to writing Valeriy Dubov
_______________________________________________
osg-submissions mailing list
osg-submissions-ZwoEplunGu0hajLcUbyfC12AsgEQdTeF< at >public.gmane.org
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Re: Osg submission

Sebastian Messerschmidt — 2013-05-15T08:44:10

Hi Robert,
Probably the most accurate transcription is "Valery Dubov".

cheers
Sebastian

_______________________________________________
osg-submissions mailing list
osg-submissions-ZwoEplunGu0hajLcUbyfC12AsgEQdTeF< at >public.gmane.org
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Re: Osg submission

Robert Osfield — 2013-05-14T16:26:42

Hi,

I'm about to review your changes but when I merged submissions I attach a
name to the submission to keep track of hows submitted what, but I'm not
quite sure how to put your name as svn prefers ascii characters.  If you
were to write your name for the benefit of a english speaker how might you
write it?

Cheers,
Robert.


On 25 April 2013 11:29, Валерий Дубов <dvv101111-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org> wrote:

_______________________________________________
osg-submissions mailing list
osg-submissions-ZwoEplunGu0hajLcUbyfC12AsgEQdTeF< at >public.gmane.org
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Re: Messages classification

Robert Osfield — 2013-05-14T16:24:07

Thansk Lionel, fix looks appropriate, now merged and submitted to svn/trunk.


On 7 May 2013 15:56, Lionel Lagarde <lionel.lagarde-YsyJidqXC8BWj0EZb7rXcA< at >public.gmane.org> wrote:

_______________________________________________
osg-submissions mailing list
osg-submissions-ZwoEplunGu0hajLcUbyfC12AsgEQdTeF< at >public.gmane.org
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Re: Fixed missing constness of osg::GL2Extensionsclass

Robert Osfield — 2013-05-14T16:18:55

Thanks Michael, changes merged and submitted to svn/trunk.


On 7 May 2013 17:22, michael kapelko <kornerr-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org> wrote:

_______________________________________________
osg-submissions mailing list
osg-submissions-ZwoEplunGu0hajLcUbyfC12AsgEQdTeF< at >public.gmane.org
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Re: Fix for loading 16-bit TGA images

Robert Osfield — 2013-05-14T16:15:11

Thanks Farshid, fix merged and submitted to svn/trunk.


On 10 May 2013 02:33, Farshid Lashkari <flashk-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org> wrote:

_______________________________________________
osg-submissions mailing list
osg-submissions-ZwoEplunGu0hajLcUbyfC12AsgEQdTeF< at >public.gmane.org
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Fix for loading 16-bit TGA images

Farshid Lashkari — 2013-05-10T01:33:08

Hi Robert,

The tga image loader was not properly reading in 16-bit images. Fix is
attached.

Cheers,
Farshid
_______________________________________________
osg-submissions mailing list
osg-submissions-ZwoEplunGu0hajLcUbyfC12AsgEQdTeF< at >public.gmane.org
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Fixed missing constness of osg::GL2Extensionsclass

michael kapelko — 2013-05-07T16:22:08

The provided patch (against SVN revision 13380) adds missing constness to
returning calls (without it the user code does not compile).
I've also included the full osg::GL2Extensions file to comply with the
submission rules.
_______________________________________________
osg-submissions mailing list
osg-submissions-ZwoEplunGu0hajLcUbyfC12AsgEQdTeF< at >public.gmane.org
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Messages classification

Lionel Lagarde — 2013-05-07T14:56:23

Hi,

When a function do:

OSG_DEBUG << "Hello world!\n";

the underlying stream is not automatically flushed. It is flushed
if endl is queued instead of \n:

OSG_DEBUG << "Hello world!" << std::endl;


The notify macros do:
stream->setCurrentSeverity(severity);
return *stream;

So, if a function do:

OSG_DEBUG << "This is a debug message\n";
OSG_NOTICE << "This is a notice message" << std::endl;

the debug message will be classified as a notice message.

It is a problem when the application uses a NotifyHandler. The notify
method of the handler is called with:

severity = NOTICE
message = "This is a debug message\nThis is a notice message"

The attached Notify.cpp contains an automatic flush of the stream when
the current severity changes.


_______________________________________________
osg-submissions mailing list
osg-submissions-ZwoEplunGu0hajLcUbyfC12AsgEQdTeF< at >public.gmane.org
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Osg submission

Валерий Дубов — 2013-04-25T10:29:58

The compilation of OSG for Android on Mac OS X requires to change some
conditional statements in different CMakeLists.txt file from:
IF(APPLE)
to
IF(APPLE AND NOT ANDROID)

Modifications need to be applied on the main CMakeLists.txt,
src/osgDB/CMakeLists.txt and src/osgViewer/CMakeLists.txt.
_______________________________________________
osg-submissions mailing list
osg-submissions-ZwoEplunGu0hajLcUbyfC12AsgEQdTeF< at >public.gmane.org
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Update state stack when applying StateSet

Farshid Lashkari — 2013-04-18T19:49:17

Hi Robert,

I'm working on a custom ShaderComposer and I need access to the full
StateSetStack of the State object within the getOrCreateProgram() method.
The problem is that  "State::apply(const StateSet* dstate)" does not add
the specified stateset to the stack. I'm not sure if this was intentional,
but I've updated the function to push/pop the stateset.

I hope the change seems reasonable. I searched the entire code base for
code that accesses the StateSetStack, and noticed RenderBin and RenderStage
use it. However, I don't think that code would ever be called from within
the State::apply() function, so I'm fairly confident the change should be
safe.

Cheers,
Farshid
_______________________________________________
osg-submissions mailing list
osg-submissions-ZwoEplunGu0hajLcUbyfC12AsgEQdTeF< at >public.gmane.org
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Re: DDS - Crash fixes, improved handling of S3TC-DXTC

Sukender — 2013-04-18T12:16:43

Forgot to mention authors:
Commits 1 & 2: Diane Delallée & Sukender (Benoit Neil)
Commits 3 & 4: Sukender (Benoit Neil)

Sukender



----- Mail original -----
De: "Sukender" <suky0001< at >free.fr>
À: "OpenSceneGraph Submissions" <osg-submissions< at >lists.openscenegraph.org>
Envoyé: Jeudi 18 Avril 2013 14:13:15
Objet: [osg-submissions] DDS - Crash fixes, improved handling of S3TC-DXTC

Hi Robert,

It's been a while, eh?

Well, here are submissions about handling of S3TC-DXTC (.dds) images. All changes are related, but they come in multiple commits.
If I could easily base my work on a specific revision for "Image.cpp" (few changes), the recent changes in "ReaderWriterDDS.cpp" are based on my previous submissions. To avoid the pain of searching old submissions in the mailing list, I re-organized everything here. This is why you'll find 3 (numbered) versions of the RW, to separate changes in multiple commits. Just focus on this submission and forget my previous ones about DDS! :)

Base revision is master b5fa42c203

DDS - Crash fixes, improved handling of S3TC-DXTC

Sukender — 2013-04-18T12:13:15

Hi Robert,

It's been a while, eh?

Well, here are submissions about handling of S3TC-DXTC (.dds) images. All changes are related, but they come in multiple commits.
If I could easily base my work on a specific revision for "Image.cpp" (few changes), the recent changes in "ReaderWriterDDS.cpp" are based on my previous submissions. To avoid the pain of searching old submissions in the mailing list, I re-organized everything here. This is why you'll find 3 (numbered) versions of the RW, to separate changes in multiple commits. Just focus on this submission and forget my previous ones about DDS! :)

Base revision is master b5fa42c203 / trunk r13348.

Attached are the modified source files, a simple test program (which creates test images, or read+rewrites images through DDS ReaderWriter), and DDS files used & produced during this test.

1. Image.cpp
Failure to perform a vertical flip on S3TC-DXTC now simply leaves the original image instead of corrupting it.
Image.cpp was sometimes performing a "normal" (= for

OpenFlight importer spot light direction

Sebastian Messerschmidt — 2013-04-17T13:28:27

Attached you'll find the corrected PrimaryRecords.cpp
This patch is against the 3.1.5 release

The pitch and yaw rotations where multiplied in the incorrect order for 
directional and spot light sources.
Could some please test the modification, as I only discovered the 
problem when construction light volumes for deferred rendering.
The attached model has 4 spot lights pointing towards the cross on the 
floor as the picture shows.


cheers
Sebastian
/* -*-c++-*- OpenSceneGraph - Copyright (C) 1998-2006 Robert Osfield
 *
 * This library is open source and may be redistributed and/or modified under
 * the terms of the OpenSceneGraph Public License (OSGPL) version 0.0 or
 * (at your option) any later version.  The full license is in LICENSE file
 * included with this distribution, and on the openscenegraph.org website.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  Se

Fix for osgAnimation serialization

Jan Ciger — 2013-04-17T09:12:53

Hello,

Here is a little patch to fix a bug in the InfluenceMap serialization. The
names of the maps weren't quoted properly and therefore it was breaking
loading of rigged models exported from e.g. Blender. Also names that
contained spaces wouldn't have been parsed properly.

Regards,

Jan
_______________________________________________
osg-submissions mailing list
osg-submissions-ZwoEplunGu0hajLcUbyfC12AsgEQdTeF< at >public.gmane.org
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Wrong include path

Nico Kruithof — 2013-04-17T08:39:26

Hello,

For the VNC server, it seems that the wrong include path is used.

Instead of
INCLUDE_DIRECTORIES(${LIBVNCCLIENT_INCLUDE_DIR})
the CMake variable
INCLUDE_DIRECTORIES(${LIBVNCSERVER_INCLUDE_DIR})
should be used.

Attached is a fix for src/osgPlugins/vnc/CMakeLists.txt

Remove debugging messages from ShaderAttribute

Farshid Lashkari — 2013-04-16T19:13:25

Hi Robert,

The osg::ShaderAttribute class was being really noisy. I removed the
debugging messages from it and attached the file.

Cheers,
Farshid
_______________________________________________
osg-submissions mailing list
osg-submissions-ZwoEplunGu0hajLcUbyfC12AsgEQdTeF< at >public.gmane.org
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org