gmane.comp.freedesktop.packagekit

Small API fixup

Richard Hughes — 2013-06-17T13:51:58

I've just committed this:

commit c0f93fb6119be8fe821a9f0191a2e655dc529d30
Author: Richard Hughes <richard-DRAXeJJ+PL1BDgjK7y7TUQ< at >public.gmane.org>
Date:   Mon Jun 17 14:48:53 2013 +0100

    Make pk_backend_job_files() accept an array of strings

    At the moment C/C++ backends have to convert from char** to char* which the
    daemon promptly converts back to char**.

    There's no point penalising all the backends for the spawned
backends sake and
    doing all the splitting and joining hurts performance for packages
that have a
    lot of files.

A couple of the non-spawned backends will need a tiny patch in the
next couple of weeks. I'll fix dummy and zif now.

Thanks,

Richard.

Re: FreeBSD and Ports/Pkg

Richard Hughes — 2013-06-17T12:16:06

Brilliant, thanks for doing all that, it's appreciated.

Richard.
_______________________________________________
PackageKit mailing list
PackageKit< at >lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/packagekit

FreeBSD and Ports/Pkg

Anders F Björklund — 2013-06-16T20:00:14

I merged the updates for the Ports backend and for FreeBSD builds.

It updates the backend to 0.8, and fixes some portability issues...

Apparently there are some GSOC projects working on a "Pkg" backend:

https://wiki.freebsd.org/pkgng (it would be native, rather than Ruby)

--anders

Re: [PATCH 0 of 4] Improve the PiSi backend

Richard Hughes — 2013-06-10T09:12:10

Okay, I've added ikeydoherty to the list of committers, please just
push to the pisi backend without asking :)

On the maintainer/author issue, I see this as the basic ground rules:

./MAINTAINERS = people who maintain PackageKit as a whole (i.e. me :)
./AUTHORS = people who have changed/added a significant number of
lines of code. Lets say 50 as a guide
./backends/*/pk-backend-*.* - if you're the maintainer of the backend,
i.e. you want to be contacted if anyone has any problems, please add
yourself to the list in the backend file, e.g.

const gchar *
pk_backend_get_author (PkBackend *backend)
{
return "Richard Hughes <richard-DRAXeJJ+PL1BDgjK7y7TUQ< at >public.gmane.org>\nAnyone Else <foo-+RB1Aph5k6s< at >public.gmane.org>";
}

Richard.

Re: [PATCH 0 of 4] Improve the PiSi backend

Ikey Doherty — 2013-06-10T08:21:56

Got a better solution; I'll just whack my name somewhere in the source 
files in comments. Too much fuss otherwise ^^

- Ikey

Re: [PATCH 0 of 4] Improve the PiSi backend

Matthias Klumpp — 2013-06-10T06:56:14

2013/6/10 Daniel Nicoletti <dantti12-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org>:
Well, you can always use an author string with multiple lines...
Cheers,
   Matthias

Re: [PATCH 0 of 4] Improve the PiSi backend

Steve Nordquist — 2013-06-10T03:51:09

Iff !toxicquestion{
  Can Pisi log be briefer, e.g.
  pisi update $CREDENTIALS     : Has 7 lines (for every package/dep) where
one will do save -v (-vv?) or -t --terse  invocation
  pisi history -l 2     : Has '$pkg upgraded from a to b with delta.' where
a and b are fogged by arch, build (distro); also
                                   number similarity; s.b.    df upgraded
from 3.7.9 to .7.10 by 41GiB delta. (Seems legit. I did SHA4000 checksums.)
  pisi upgrade $CREDENTIALS     : as update, although now I think the color
scheme looks like a chicken avacado sprout sammich
                                      so perhaps I shouldn't break diet
guidelines led by relative preponderance of text. #avacado lobby sponsors
yeah
  pisi info libgtk-3     : :) Okay, so the short of it is that the
installed package is the same as the one in the(!) SolusOS repository but
                                   somehow has no reverse (!) deps to
libgtk-3-devel (and later, there's no package in source repos?) or -demo or
-do

Re: [PATCH 0 of 4] Improve the PiSi backend

Daniel Nicoletti — 2013-06-10T01:40:22

2013/6/9 Ikey Doherty <ikey-3GWFbv30islBDgjK7y7TUQ< at >public.gmane.org>:
Good question, maybe we should have add a maintainers property? Richard?
As you are not the author but as you are taking up his job you surely deserve
credit, is it possible to add your name next to his?

Best,

--
Daniel Nicoletti

KDE Developer - http://dantti.wordpress.com

Re: [PATCH 0 of 4] Improve the PiSi backend

Ikey Doherty — 2013-06-09T18:48:07

Set up an account on Gitorious < at > https://gitorious.org/~ikeydoherty
Look forward to pushing the new changes to the PiSi backend :)

Related question: Should I change the author information in the pk 
backend to reflect my involvement?

- Ikey

Re: [PATCH 0 of 4] Improve the PiSi backend

Ikey Doherty — 2013-06-09T12:44:34

Awesome.

More awesome :) I'll set that up tonight, and probably drop by in 
#PackageKit so I can clarify a few things (mainly advice on simulated 
transactions so that gpk-application actually informs me it's installed 
38 packages not one :))

- Ikey

Re: [PATCH 0 of 4] Improve the PiSi backend

Matthias Klumpp — 2013-06-09T11:42:26

Hi!

2013/6/8 Richard Hughes <hughsient-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org>:
That was the motivation for my question ;-) I celebrate every new PK
0.8.x-compatible backend here anyway :P

2013/6/9 Ikey Doherty <ikey-3GWFbv30islBDgjK7y7TUQ< at >public.gmane.org>:
Well, that is the goal of PackageKit, and why it is so awesome :D

We can certainly and easily merge your branches, but Richard offered
you to maintain the backend directly in the PackageKit master branch,
meaning you will be able to push your patches to the PiSi backend
directly. This makes sense, because you can judge wether the changes
make sense for PiSi - I can't do that, because I never used it ^^
If you want, you can also join #PackageKit on Freenode - some
discussions happen there, and it is great for small questions.
So, if you have an account on Gitorious, just ask Richard (hughsie) to
add you as contributor.
Cheers,
   Matthias

Re: [PATCH 0 of 4] Improve the PiSi backend

Ikey Doherty — 2013-06-09T11:33:27

Hi Richard,

I am indeed :) It's about some time it got some love, and it seems to me 
from looking at the old code it was never up to scratch at any stage, 
just there on the basis of "support".

I'd like to change that, purely for selfish reasons. It's easier for me 
to maintain the PiSi backend than it is for me to go on and write 
alternatives to GNOME PackageKit and integrate PiSi with 
gnome-control-center, tools, etc. Awesome framework just waiting for 
some PiSi love :)

I'll open up a new Gitorious account this evening, push everything into 
it and hit you up with a pull request if that's easier? Or just maintain 
my changed git ?

- Ikey

Re: [PATCH 0 of 4] Improve the PiSi backend

Richard Hughes — 2013-06-08T18:59:17

It sounds like you're offering to maintain the PiSi backend :) If
that's okay, if you create an account on gitorious and share the
username with me you can push all your patches, I don't need to review
backend changes at all.

Richard.

[PATCH] Implement 'download-packages'

Ikey Doherty — 2013-06-08T16:18:30

# HG changeset patch
# User Ikey Doherty <ikey-3GWFbv30islBDgjK7y7TUQ< at >public.gmane.org>
# Date 1370708058 -3600
# Node ID 09d65a071a3f87af374d01f44804b1c1246c7d3f
# Parent  e879418c1a584364fe9f035dd17633bef4eb4ac6
Implement 'download-packages'

diff -r e879418c1a58 -r 09d65a071a3f backends/pisi/pisiBackend.py
--- a/backends/pisi/pisiBackend.pySat Jun 08 13:46:12 2013 +0100
+++ b/backends/pisi/pisiBackend.pySat Jun 08 17:14:18 2013 +0100
< at >< at > -245,7 +245,43 < at >< at >
             self.update_detail(package_id, updates, obsoletes, vendor_url,
                 bugzilla_url, cve_url, "none", update_message, changelog,
                 state, issued, updated)
-    
+
+    def download_packages(self, directory, package_ids):
+        """ Download the given packages to a directory """
+        self.allow_cancel (False)
+        self.percentage (None)
+        self.status (STATUS_DOWNLOAD)
+        
+        packages = list()
+        
+        def progress_cb (**kw):
+            self.percentage (int(kw['percent']))
+

Re: [PATCH 3 of 4] Add progress reporting to pisibackend

Ikey Doherty — 2013-06-08T13:40:00

Hi Matthias!
That could definitely be a plan for the future, switch it to GIR 
interface. Right now I can see that several key features were always 
missing from the PiSi backend.
What I'd like to add:
  * Download support (done via the pisi.api.fetch, similar to how I'm 
handling install)
  * Support reboot, etc,
  * Pull CVE's and BUGID's from <Comment>'s in pisi-index
  * Speed it all up :)

I would like to maintain the PiSi backend, its something we intend to 
integrate quite deeply within SolusOS 2. That said a decision would have 
to be made on which PiSi to follow :)

PiSi itself (the original Pardus version) is no longer maintained, as 
Pardus switched to Debian as a base. Within SolusOS we intend to 
actively maintain our version of PiSi, and hopefully make it a standard 
implementation. My thought on this topic is that nobody else is 
maintaining or adding significant fixes/features to any implementation 
of PiSi but our own, so I naturally propose the SolusOS PiSi 
implementation to become the ref

Re: [PATCH 3 of 4] Add progress reporting to pisibackend

Matthias Klumpp — 2013-06-08T13:31:25

Hi!
Without knowing the Pisi backend, your patches look okay in general.
It might make sense to use the PackageKit GIR interface in some places
instead of python-packagekit, but since I never wrote a Python PK
backend, I don't have much experience here (I'll leave this up to
Richard to comment :P).
Do you plan to maintain the Pisi backend in future?
Cheers,
    Matthias

[PATCH 3 of 4] Add progress reporting to pisi backend

Ikey Doherty — 2013-06-08T12:56:01

# HG changeset patch
# User Ikey Doherty <ikey< at >solusos.com>
# Date 1370690735 -3600
# Node ID 6924c435d4774792912d965c8690597614805f03
# Parent  fc4a918536a57ef67bc8cd756a09261157a1b291
Add progress reporting to pisi backend

diff --git a/backends/pisi/pisiBackend.py b/backends/pisi/pisiBackend.py
--- a/backends/pisi/pisiBackend.py
+++ b/backends/pisi/pisiBackend.py
< at >< at > -20,11 +20,20 < at >< at >
 # Copyright (C) 2007 S.Çağlar Onur <caglar< at >pardus.org.tr>
 
 import pisi
+import pisi.ui
 from packagekit.backend import *
 from packagekit.package import PackagekitPackage
 from packagekit import enums
 import os.path
 
+class SimplePisiHandler(pisi.ui.UI):
+    
+    def __init(self):
+        pisi.ui.UI.__init__(self, False, False)
+        
+    def display_progress (self, **ka):
+        self.the_callback (**ka)
+
 class PackageKitPisiBackend(PackageKitBaseBackend, PackagekitPackage):
         
     MAPPING_FILE = "/etc/PackageKit/pisi.conf"
< at >< at > -218,13 +227,21 < at >< at >
         # FIXME: use only_trusted
 
         package =

[PATCH 4 of 4] Implement 'get-update-detail'

Ikey Doherty — 2013-06-08T12:56:02

# HG changeset patch
# User Ikey Doherty <ikey-3GWFbv30islBDgjK7y7TUQ< at >public.gmane.org>
# Date 1370695572 -3600
# Node ID e879418c1a584364fe9f035dd17633bef4eb4ac6
# Parent  6924c435d4774792912d965c8690597614805f03
Implement 'get-update-detail'

diff --git a/backends/pisi/pisiBackend.py b/backends/pisi/pisiBackend.py
--- a/backends/pisi/pisiBackend.py
+++ b/backends/pisi/pisiBackend.py
< at >< at > -25,6 +25,7 < at >< at >
 from packagekit.package import PackagekitPackage
 from packagekit import enums
 import os.path
+import piksemel
 
 class SimplePisiHandler(pisi.ui.UI):
     
< at >< at > -201,6 +202,50 < at >< at >
             else:
                 self.package(id, INFO_NORMAL, pkg.summary)
 
+    def _extract_update_details (self, pindex, package_name):
+document = piksemel.parse (pindex)
+packages = document.tags ("Package")
+for pkg in packages:
+if pkg.getTagData ("Name") == package_name:
+history = pkg.getTag("History")
+update = history.tags ("Update")
+update_message = "Updated"
+update_release = 0
+update_

[PATCH 2 of 4] Load PiSi Components -> PK Groupsmapping from a file

Ikey Doherty — 2013-06-08T12:56:00

# HG changeset patch
# User Ikey Doherty <ikey-3GWFbv30islBDgjK7y7TUQ< at >public.gmane.org>
# Date 1370656106 -3600
# Node ID fc4a918536a57ef67bc8cd756a09261157a1b291
# Parent  2db9a53fc49df8f5c1e3f3115ee33d2c951b1969
Load PiSi Components -> PK Groups mapping from a file

PiSi vendors may wish to categorise different PiSi components differently,
limiting with a preconfigured set requires one limited and "standard"
repository layout. Here we enable the vendor to configure this in a
separately shipped file

diff --git a/backends/pisi/pisiBackend.py b/backends/pisi/pisiBackend.py
--- a/backends/pisi/pisiBackend.py
+++ b/backends/pisi/pisiBackend.py
< at >< at > -22,85 +22,15 < at >< at >
 import pisi
 from packagekit.backend import *
 from packagekit.package import PackagekitPackage
+from packagekit import enums
+import os.path
 
 class PackageKitPisiBackend(PackageKitBaseBackend, PackagekitPackage):
-
-    # It's an ugly way to sync with PK Groups and PiSi Components
-    # Maybe we can provide these with our index?
-    groups = {
-

[PATCH 1 of 4] Simple alterations to make PiSi workonce more

Ikey Doherty — 2013-06-08T12:55:59

# HG changeset patch
# User Ikey Doherty <ikey-3GWFbv30islBDgjK7y7TUQ< at >public.gmane.org>
# Date 1370656016 -3600
# Node ID 2db9a53fc49df8f5c1e3f3115ee33d2c951b1969
# Parent  1f562828e967dc88ad7520922f599f582afa6bac
Simple alterations to make PiSi work once more

diff --git a/backends/pisi/pisiBackend.py b/backends/pisi/pisiBackend.py
--- a/backends/pisi/pisiBackend.py
+++ b/backends/pisi/pisiBackend.py
< at >< at > -170,14 +170,16 < at >< at >
 
         if self.packagedb.has_package(package):
             pkg = self.packagedb.get_package(package)
+            repo = self.packagedb.get_package_repo (pkg.name, None)
+            pkg_id = self.get_package_id (pkg.name, self.__get_package_version(pkg), pkg.architecture, repo[1])
 
             if self.groups.has_key(pkg.partOf):
                 group = self.groups[pkg.partOf]
             else:
                 group = GROUP_UNKNOWN
 
-            self.details("%s-%s" % (pkg.name, self.__get_package_version(pkg)),
-                            pkg.license,
+            self.details

[PATCH 0 of 4] Improve the PiSi backend

Ikey Doherty — 2013-06-08T12:55:58

Improve the PiSi backend, and make it work with the 0.8.9 release.