http://permalink.gmane.org/gmane.comp.emulators.virt-tools hourly 1 1901-01-01T00:00+00:00 http://gmane.org/img/gmane-25t.png http://gmane.org http://permalink.gmane.org/gmane.comp.emulators.virt-tools/5887 <pre>There used to be a check to fullscreen the only visible display on current monitor, by checking the number of visible monitors. Now that fullscreen is independant for each display, and goes on current monitor, it's useless. However, this code path is still used for the app --full-screen, at startup time. And it is still nicer to open the display on respective client monitors, rather than all on current monitor. --- src/virt-viewer-app.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c index 539c4a4..c2ecc67 100644 --- a/src/virt-viewer-app.c +++ b/src/virt-viewer-app.c &lt; at &gt;&lt; at &gt; -631,16 +631,12 &lt; at &gt;&lt; at &gt; viewer_window_focus_out_cb(GtkWindow *window G_GNUC_UNUSED, } static void -app_window_try_fullscreen(VirtViewerApp *self, VirtViewerWindow *win, gint nth) +app_window_try_fullscreen(VirtViewerApp *self G_GNUC_UNUSED, + VirtViewerWindow *win, gint nth) { GdkScreen *screen = gdk_screen_get_default(); - gboolea</pre> Marc-André Lureau 2013-05-22T19:40:03 http://permalink.gmane.org/gmane.comp.emulators.virt-tools/5885 <pre>Hi All, I was looking at virsh attach-disk and i see the below [snip] DESCRIPTION Attach new disk device. OPTIONS [--domain] &lt;string&gt; domain name, id or uuid [--source] &lt;string&gt; source of disk device [--target] &lt;string&gt; target of disk device ... ... *--sourcetype &lt;string&gt; type of source (block|file)* [/snip] I was wondering why the sourcetype only support block|file only ? What if i wanted to add a network (disk type=network) based drive ? Is this a constraint of virsh or QEMU itself doesn't allow hotplu of network block device disk ? thanx, deepak </pre> Deepak C Shetty 2013-05-22T12:55:38 http://permalink.gmane.org/gmane.comp.emulators.virt-tools/5884 <pre> Thanks Marc, pushed now. - Cole </pre> Cole Robinson 2013-05-21T20:03:28 http://permalink.gmane.org/gmane.comp.emulators.virt-tools/5883 <pre> Looks fine, thanks for the work! Couple pylint errors: $ python setup.py pylint running pylint ************* Module virtManager.createnet W:506:vmmCreateNetwork.change_routev6_enable: Unused argument 'src' W:580:vmmCreateNetwork.change_dhcpv6_enable: Unused argument 'src' ************* Module virtManager.network W: 20: Unused import logging running pep8 virtManager/createnet.py:551: [E271] multiple spaces after keyword One thing though: looks like &lt;domain name= is now unconditionally used for new networks. Intentional? Are there downsides here that might cause someone to complain? - Cole _______________________________________________ virt-tools-list mailing list virt-tools-list&lt; at &gt;redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list</pre> Cole Robinson 2013-05-21T20:00:00 http://permalink.gmane.org/gmane.comp.emulators.virt-tools/5882 <pre>Hi, Here's a patch to update the list of Ubuntu releases. Thanks, Marc. commit 1ada943da0ec01f444b3df452e6f371d07021330 Author: Marc Deslauriers &lt;marc.deslauriers-GeWIH/nMZzLQT0dZR+AlfA&lt; at &gt;public.gmane.org&gt; Date: Tue May 21 15:59:17 2013 -0400 Update list of Ubuntu releases diff --git a/virtinst/osdict.py b/virtinst/osdict.py index 3f8ae95..68ba8c3 100644 --- a/virtinst/osdict.py +++ b/virtinst/osdict.py &lt; at &gt;&lt; at &gt; -60,6 +60,12 &lt; at &gt;&lt; at &gt; VGA_VIDEO = { ] } +VMVGA_VIDEO = { + "model_type": [ + (HV_ALL, "vmvga"), + ] +} + DEFAULTS = { "acpi": True, "apic": True, &lt; at &gt;&lt; at &gt; -507,7 +513,6 &lt; at &gt;&lt; at &gt; OS_TYPES = { "ubuntuhardy": { "label": "Ubuntu 8.04 LTS (Hardy Heron)", "distro": "ubuntu", - "supported": True, "devices" : { NET : VIRTIO_NET, }, &lt; at &gt;&lt; at &gt; -555,7 +560,6 &lt; at &gt;&lt; at &gt; OS_TYPES = { "ubuntunatty": { "label": "Ubuntu 11.04 (Natty Narwhal)", "distro": "ubuntu", - "supported": True, "devices"</pre> Marc Deslauriers 2013-05-21T20:00:41 http://permalink.gmane.org/gmane.comp.emulators.virt-tools/5881 <pre>Jim, Thanks so much for your help. Much appreciated! I filed a bug report with Ubuntu: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1180281 Hopefully other Ubuntu users who are experiencing the same issue will add comments/feedback to the bug report. Best regards, Gizmo Chicken On Mon, May 20, 2013 at 9:46 AM, Jim Fehlig &lt;jfehlig-IBi9RG/b67k&lt; at &gt;public.gmane.org&gt; wrote: </pre> Gizmo Chicken 2013-05-21T01:32:52 http://permalink.gmane.org/gmane.comp.emulators.virt-tools/5879 <pre> Exactly, sounds like Bug 887106 [1]. Feel free to check if it looks the same and comment on the bug. Can you create new one by clicking on the "New" button? Martin [1] https://bugzilla.redhat.com/show_bug.cgi?id=887106 </pre> Martin Kletzander 2013-05-20T13:01:36 http://permalink.gmane.org/gmane.comp.emulators.virt-tools/5877 <pre> Well this sounds like a bug. Did you see if there are any existing bug reports or file a new one? There's no need to "reset" anything. Just kill virt-manager and start it up again. You can even restart libvirtd if you think that is causing the problem; it won't affect your running VMs. Rich. </pre> Richard W.M. Jones 2013-05-17T20:13:02 http://permalink.gmane.org/gmane.comp.emulators.virt-tools/5876 <pre>ACK. On 05/17/2013 05:01 PM, Marc-André Lureau wrote: </pre> Hans de Goede 2013-05-17T17:32:31 http://permalink.gmane.org/gmane.comp.emulators.virt-tools/5875 <pre>This field is used to invite the user to close running instances, when updating the installation with an MSI. "A remote desktop client" isn't specific enough, use a VirtViewer specific description. --- src/virt-viewer.rc.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/virt-viewer.rc.in b/src/virt-viewer.rc.in index 196e631..2f52c34 100644 --- a/src/virt-viewer.rc.in +++ b/src/virt-viewer.rc.in &lt; at &gt;&lt; at &gt; -8,10 +8,10 &lt; at &gt;&lt; at &gt; BEGIN BLOCK "040904E4" BEGIN VALUE "CompanyName", "virt-manager.org" - VALUE "FileDescription", "A remote desktop client" + VALUE "FileDescription", "VirtViewer desktop client" VALUE "FileVersion", "&lt; at &gt;VERSION&lt; at &gt;" VALUE "InternalName", "&lt; at &gt;PACKAGE_STRING&lt; at &gt;" - VALUE "LegalCopyright", "Copyright (C) 2007-2012 Red Hat, Inc." + VALUE "LegalCopyright", "Copyright (C) 2007-2013 Red Hat, Inc." VALUE "OriginalFilename", "virt-viewer.exe" VALUE "ProductName", "VirtViewer" VALUE "ProductVersion", "&lt; at &gt;VERSION&lt; at &gt;" </pre> Marc-André Lureau 2013-05-17T15:01:00 http://permalink.gmane.org/gmane.comp.emulators.virt-tools/5874 <pre> A bit scared that this will cause other subtle issues, but why not, ACK Christophe </pre> Christophe Fergeau 2013-05-17T14:04:31 http://permalink.gmane.org/gmane.comp.emulators.virt-tools/5873 <pre>ACK On Thu, May 16, 2013 at 09:33:18PM +0200, Marc-André Lureau wrote: </pre> Christophe Fergeau 2013-05-17T13:25:59 http://permalink.gmane.org/gmane.comp.emulators.virt-tools/5872 <pre>ACK On Thu, May 16, 2013 at 09:33:22PM +0200, Marc-André Lureau wrote: </pre> Christophe Fergeau 2013-05-17T12:59:20 http://permalink.gmane.org/gmane.comp.emulators.virt-tools/5871 <pre> ACK </pre> Christophe Fergeau 2013-05-17T12:59:05 http://permalink.gmane.org/gmane.comp.emulators.virt-tools/5870 <pre>Yup, this indeed looks unused, ACK Christophe On Thu, May 16, 2013 at 09:33:20PM +0200, Marc-André Lureau wrote: </pre> Christophe Fergeau 2013-05-17T12:58:42 http://permalink.gmane.org/gmane.comp.emulators.virt-tools/5869 <pre>Looks good, ack series. On 05/17/2013 02:28 PM, Marc-André Lureau wrote: </pre> Hans de Goede 2013-05-17T13:01:26 http://permalink.gmane.org/gmane.comp.emulators.virt-tools/5868 <pre>ACK On Thu, May 16, 2013 at 09:33:17PM +0200, Marc-André Lureau wrote: </pre> Christophe Fergeau 2013-05-17T12:54:39 http://permalink.gmane.org/gmane.comp.emulators.virt-tools/5867 <pre>https://bugzilla.redhat.com/show_bug.cgi?id=864026 --- src/remote-viewer.c | 16 ++++++++++++++++ src/virt-viewer-app.c | 34 +++++++++++++++++++--------------- src/virt-viewer-app.h | 2 +- src/virt-viewer.c | 6 +++--- 4 files changed, 39 insertions(+), 19 deletions(-) diff --git a/src/remote-viewer.c b/src/remote-viewer.c index d1c5525..a0adef7 100644 --- a/src/remote-viewer.c +++ b/src/remote-viewer.c &lt; at &gt;&lt; at &gt; -77,6 +77,7 &lt; at &gt;&lt; at &gt; static gboolean remote_viewer_start(VirtViewerApp *self); static gboolean remote_viewer_activate(VirtViewerApp *self, GError **error); static void remote_viewer_window_added(VirtViewerApp *self, VirtViewerWindow *win); static void spice_foreign_menu_updated(RemoteViewer *self); +static gint connect_dialog(gchar **uri); static void remote_viewer_get_property (GObject *object, guint property_id, &lt; at &gt;&lt; at &gt; -145,6 +146,20 &lt; at &gt;&lt; at &gt; remote_viewer_dispose (GObject *object) #endif static void +remote_viewer_deactivated(VirtViewerApp *app, gboolean connect_error) +{ + RemoteViewer *self </pre> Marc-André Lureau 2013-05-17T12:28:11 http://permalink.gmane.org/gmane.comp.emulators.virt-tools/5866 <pre>The Spice session may outlive the virt-viewer session, due to it's async nature. Use the more robust virt_viewer_signal_connect_object() to fix delayed potential crashes. --- src/virt-viewer-session-spice.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/virt-viewer-session-spice.c b/src/virt-viewer-session-spice.c index d7b01a7..06e0005 100644 --- a/src/virt-viewer-session-spice.c +++ b/src/virt-viewer-session-spice.c &lt; at &gt;&lt; at &gt; -194,10 +194,10 &lt; at &gt;&lt; at &gt; create_spice_session(VirtViewerSessionSpice *self) self-&gt;priv-&gt;gtk_session = spice_gtk_session_get(self-&gt;priv-&gt;session); g_object_set(self-&gt;priv-&gt;gtk_session, "auto-clipboard", TRUE, NULL); - g_signal_connect(self-&gt;priv-&gt;session, "channel-new", - G_CALLBACK(virt_viewer_session_spice_channel_new), self); - g_signal_connect(self-&gt;priv-&gt;session, "channel-destroy", - G_CALLBACK(virt_viewer_session_spice_channel_destroy), self); + virt_viewer_signal_connect_object(self-&gt;priv-&gt;session,</pre> Marc-André Lureau 2013-05-17T12:28:10 http://permalink.gmane.org/gmane.comp.emulators.virt-tools/5865 <pre>--- src/remote-viewer-main.c | 95 +------------------------------------- src/remote-viewer.c | 118 ++++++++++++++++++++++++++++++++++++++++++++++- src/virt-viewer-app.c | 4 +- 3 files changed, 120 insertions(+), 97 deletions(-) diff --git a/src/remote-viewer-main.c b/src/remote-viewer-main.c index de1544f..ee0025e 100644 --- a/src/remote-viewer-main.c +++ b/src/remote-viewer-main.c &lt; at &gt;&lt; at &gt; -70,94 +70,6 &lt; at &gt;&lt; at &gt; option_fullscreen(G_GNUC_UNUSED const gchar *option_name, return FALSE; } -static void recent_selection_changed_dialog_cb(GtkRecentChooser *chooser, gpointer data) -{ - GtkRecentInfo *info; - GtkWidget *entry = data; - const gchar *uri; - - info = gtk_recent_chooser_get_current_item(chooser); - if (info == NULL) - return; - - uri = gtk_recent_info_get_uri(info); - g_return_if_fail(uri != NULL); - - gtk_entry_set_text(GTK_ENTRY(entry), uri); - - gtk_recent_info_unref(info); -} - -static void recent_item_activated_dialog_cb(GtkRecentChooser *chooser G_GNUC_</pre> Marc-André Lureau 2013-05-17T12:28:09 http://permalink.gmane.org/gmane.comp.emulators.virt-tools/5864 <pre>small mistake below On Thu, May 16, 2013 at 9:33 PM, Marc-André Lureau &lt; marcandre.lureau-Re5JQEeQqe8AvxtiuMwx3w&lt; at &gt;public.gmane.org&gt; wrote: + if (self-&gt;priv-&gt;fullscreen) </pre> Marc-André Lureau 2013-05-16T19:52:52 Search the mailing list at Gmane query http://search.gmane.org/?group=$group=gmane.comp.emulators.virt-tools