gmane.comp.emulators.spice.devel

回复： MacOS SPICE client

jojo — 2013-05-18T02:56:03

Hi,

Ok, i will try to compile it :)  

Thanks,

- Jojo


在 2013年5月17日星期五，下午7:40，Christophe Fergeau 写道：

spice server release 0.12.3

Alon Levy — 2013-05-17T18:36:41

I'm pleased to announce a bug fixing minor release of spice server:

http://spice-space.org/download/releases/spice-0.12.3.tar.bz2

here is the excerpt from NEWS:

* monitor client bandwidth and latency.
* dynamically adjust video stream quality based on client bandwidth &
latency.
** new SPICE_MSGC_DISPLAY_STREAM_REPORT
** can also set SPICE_BIT_RATE environment variable to override.
* support arbitrary latency of audio stream wrt video stream:
** new SPICE_MSG_PLAYBACK_LATENCY
* notify agent on client disconnection
** new VD_AGENT_CLIENT_DISCONNECTED message
* better support for switching from qxl to vga mode
** new library export spice_qxl_driver_unload
* multiple monitor support in single channel fixes.
* stop streams before migration.
* don't send empty volume messages.
* Bugs fixed: rhbz#891326, rhbz#958276, rhbz#956345
* fixes to inputs, chardev, build fixes.

Spice Team

Re: [PATCH 0/9] 0.12.3 + a bunch of small fixes I had laying around

Hans de Goede — 2013-05-17T17:35:26

Looks good, ACK series,

On 05/17/2013 05:08 PM, Alon Levy wrote:

Re: resolution

David Jaša — 2013-05-17T16:16:35

Why don't you use remote-viewer? It's available precompiled for download
at downloads page and it will work better for you if you want just to
use spice.

On topic - the client resolution change is the way of old spicec to get
remote guest monitor displayed fullscreen as it made almost no harm on
CRTs and CPU power for software scaling was way more scarce. The
opposite is true these days so remote-viewer won't touch your client
resolution at all but it will try to adjust remote system resolution to
best match current view and if that won't be possible, it will scale the
remote guest monitor to fit the widget viewport.

David


天外银龙 píše v Ne 12. 05. 2013 v 11:17 +0800:

spice-html5 development plan

jeasonw — 2013-05-15T03:53:12

Hi:
What is the development plans of spice-html5?

Resolution

天外银龙 — 2013-05-12T03:13:19

When I have compiled spicy.exe on fodera14,run it on windows,the resolution(DPI) and colour will change both local and remote desktop.Can you help me?Thank you~

resolution

天外银龙 — 2013-05-12T03:17:12

When I have compiled spicy.exe on fodera14,run it on windows,the resolution(DPI) and colour will change both local and remote desktop.Can you help me?Thank you~

Resolution

天外银龙 — 2013-05-12T01:52:38

When I have compiled spicy.exe on fodera14,run it on windows,the resolution(DPI) and colour will change both local and remote desktop.Can you help me?Thank you~

[PATCH 9/9] 0.12.3 release

Alon Levy — 2013-05-17T15:08:14

---
 NEWS         | 18 ++++++++++++++++++
 configure.ac |  4 ++--
 2 files changed, 20 insertions(+), 2 deletions(-)

diff --git a/NEWS b/NEWS
index 30912c5..acfffb8 100644
--- a/NEWS
+++ b/NEWS
< at >< at > -1,3 +1,21 < at >< at >
+Major changes in 0.12.3:
+========================
+* monitor client bandwidth and latency.
+* dynamically adjust video stream quality based on client bandwidth & latency.
+** new SPICE_MSGC_DISPLAY_STREAM_REPORT
+** can also set SPICE_BIT_RATE environment variable to override.
+* support arbitrary latency of audio stream wrt video stream:
+** new SPICE_MSG_PLAYBACK_LATENCY
+* notify agent on client disconnection
+** new VD_AGENT_CLIENT_DISCONNECTED message
+* better support for switching from qxl to vga mode
+** new library export spice_qxl_driver_unload
+* multiple monitor support in single channel fixes.
+* stop streams before migration.
+* don't send empty volume messages.
+* Bugs fixed: rhbz#891326, rhbz#958276, rhbz#956345
+* fixes to inputs, chardev, build fixes.
+
 Major changes in 0.12.2:

[PATCH 8/9] server/red_parse_qxl: two codingconvention pointer cast fix

Alon Levy — 2013-05-17T15:08:13

---
 server/red_parse_qxl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/server/red_parse_qxl.c b/server/red_parse_qxl.c
index 4b39029..65781e7 100644
--- a/server/red_parse_qxl.c
+++ b/server/red_parse_qxl.c
< at >< at > -104,7 +104,7 < at >< at > static size_t red_get_data_chunks_ptr(RedMemSlotInfo *slots, int group_id,
         red_prev = red;
         red = spice_new(RedDataChunk, 1);
         memslot_id = get_memslot_id(slots, qxl->next_chunk);
-        qxl = (QXLDataChunk*)get_virt(slots, qxl->next_chunk, sizeof(*qxl), group_id,
+        qxl = (QXLDataChunk *)get_virt(slots, qxl->next_chunk, sizeof(*qxl), group_id,
                                       &error);
         if (error) {
             return 0;
< at >< at > -130,7 +130,7 < at >< at > static size_t red_get_data_chunks(RedMemSlotInfo *slots, int group_id,
     int error;
     int memslot_id = get_memslot_id(slots, addr);
 
-    qxl = (QXLDataChunk*)get_virt(slots, addr, sizeof(*qxl), group_id, &error);
+    qxl = (QXLDataChunk *)get_virt(slots, addr, size

[PATCH 7/9] server/dispatchers: initialize stack to 0for valgrind

Alon Levy — 2013-05-17T15:08:12

---
 server/main_dispatcher.c | 2 +-
 server/red_dispatcher.c  | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/server/main_dispatcher.c b/server/main_dispatcher.c
index 92b0791..e7a451a 100644
--- a/server/main_dispatcher.c
+++ b/server/main_dispatcher.c
< at >< at > -78,7 +78,7 < at >< at > static void main_dispatcher_handle_channel_event(void *opaque,
 
 void main_dispatcher_channel_event(int event, SpiceChannelEventInfo *info)
 {
-    MainDispatcherChannelEventMessage msg;
+    MainDispatcherChannelEventMessage msg = {0,};
 
     if (pthread_self() == main_dispatcher.base.self) {
         main_dispatcher_self_handle_channel_event(event, info);
diff --git a/server/red_dispatcher.c b/server/red_dispatcher.c
index f4b140c..ef47c28 100644
--- a/server/red_dispatcher.c
+++ b/server/red_dispatcher.c
< at >< at > -97,7 +97,7 < at >< at > static void red_dispatcher_set_display_peer(RedChannel *channel, RedClient *clie
                                             int num_common_caps, uint32_t *common_caps, int num_caps,

[PATCH 6/9] server/red_dispatcher: close pa hole inRedWorkerMessageDisplayConnect for valgrind

Alon Levy — 2013-05-17T15:08:11

---
 server/red_dispatcher.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/server/red_dispatcher.h b/server/red_dispatcher.h
index 4d0d2a8..7d23b11 100644
--- a/server/red_dispatcher.h
+++ b/server/red_dispatcher.h
< at >< at > -43,10 +43,10 < at >< at > void red_dispatcher_client_monitors_config(VDAgentMonitorsConfig *monitors_confi
 typedef struct RedWorkerMessageDisplayConnect {
     RedClient * client;
     RedsStream * stream;
-    int migration;
     uint32_t *common_caps; // red_worker should free
-    int num_common_caps;
     uint32_t *caps;        // red_worker should free
+    int migration;
+    int num_common_caps;
     int num_caps;
 } RedWorkerMessageDisplayConnect;

[PATCH 5/9] server/tests: test_display_width_stride

Alon Levy — 2013-05-17T15:08:10

---
 server/tests/Makefile.am                 |  8 ++-
 server/tests/test_display_base.c         | 48 ++++++++++++++---
 server/tests/test_display_base.h         | 13 +++++
 server/tests/test_display_width_stride.c | 92 ++++++++++++++++++++++++++++++++
 4 files changed, 154 insertions(+), 7 deletions(-)
 create mode 100644 server/tests/test_display_width_stride.c

diff --git a/server/tests/Makefile.am b/server/tests/Makefile.am
index e0472f3..655bc83 100644
--- a/server/tests/Makefile.am
+++ b/server/tests/Makefile.am
< at >< at > -35,6 +35,7 < at >< at > noinst_PROGRAMS =\
 test_display_resolution_changes\
 test_two_servers\
 test_vdagent\
+test_display_width_stride\
 $(NULL)
 
 test_vdagent_SOURCES =\
< at >< at > -90,4 +91,9 < at >< at > test_two_servers_SOURCES =\
 test_two_servers.c \
 $(NULL)
 
-
+test_display_width_stride_SOURCES =\
+$(COMMON_BASE)\
+test_display_base.c\
+test_display_base.h\
+test_display_width_stride.c \
+$(NULL)
diff --git a/server/tests/test_display_base.c b/serv

[PATCH 4/9] server/red_worker: simplifymonitors_config update

Alon Levy — 2013-05-17T15:08:09

---
 server/red_worker.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/server/red_worker.c b/server/red_worker.c
index 14d219b..f047d29 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
< at >< at > -1279,6 +1279,9 < at >< at > static MonitorsConfig *monitors_config_getref(MonitorsConfig *monitors_config)
 
 static void monitors_config_decref(MonitorsConfig *monitors_config)
 {
+    if (!monitors_config) {
+        return;
+    }
     if (--monitors_config->refs > 0) {
         return;
     }
< at >< at > -11339,9 +11342,7 < at >< at > static void worker_update_monitors_config(RedWorker *worker,
     MonitorsConfig *monitors_config;
     int i;
 
-    if (worker->monitors_config) {
-        monitors_config_decref(worker->monitors_config);
-    }
+    monitors_config_decref(worker->monitors_config);
 
     spice_debug("monitors config %d(%d)",
                 dev_monitors_config->count,
< at >< at > -11396,12 +11397,10 < at >< at > static void set_monitors_config_to_primary(RedWorker *worker)
     DrawContext *context;

[PATCH 3/9] server/tests/test_display_base: addmissing set_client_capabilities,fix client_monitors_config signature

Alon Levy — 2013-05-17T15:08:08

---
 server/tests/test_display_base.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/server/tests/test_display_base.c b/server/tests/test_display_base.c
index 588e960..8657e91 100644
--- a/server/tests/test_display_base.c
+++ b/server/tests/test_display_base.c
< at >< at > -701,13 +701,22 < at >< at > static int flush_resources(QXLInstance *qin)
     return TRUE;
 }
 
-static void client_monitors_config(QXLInstance *qin, VDAgentMonitorsConfig *monitors_config)
+static int client_monitors_config(QXLInstance *qin,
+                                  VDAgentMonitorsConfig *monitors_config)
 {
     if (!monitors_config) {
         printf("%s: NULL monitors_config\n", __func__);
     } else {
         printf("%s: %d\n", __func__, monitors_config->num_of_monitors);
     }
+    return 0;
+}
+
+static void set_client_capabilities(QXLInstance *qin,
+                                    uint8_t client_present,
+                                    uint8_t caps[58])
+{
+    printf("%s: present %d caps %d\n",

[PATCH 2/9] server/red_worker: turn critical (assert)non error into warning

Alon Levy — 2013-05-17T15:08:07

The situation causing this assert is unknown but it doesn't cause
correctness issues with later rendering, and it is causing an abort.
---
 server/red_worker.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/server/red_worker.c b/server/red_worker.c
index 8f3e478..14d219b 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
< at >< at > -11367,7 +11367,10 < at >< at > static void red_push_monitors_config(DisplayChannelClient *dcc)
 {
     MonitorsConfig *monitors_config = DCC_TO_WORKER(dcc)->monitors_config;
 
-    spice_return_if_fail(monitors_config != NULL);
+    if (monitors_config == NULL) {
+        spice_warning("monitors_config is NULL");
+        return;
+    }
 
     if (!red_channel_client_test_remote_cap(&dcc->common.base,
                                             SPICE_DISPLAY_CAP_MONITORS_CONFIG)) {

[PATCH 1/9] server/red_worker:s/driver_has_monitors_config/driver_cap_monitors_config/(plus small comment)

Alon Levy — 2013-05-17T15:08:06

---
 server/red_worker.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/server/red_worker.c b/server/red_worker.c
index fb736b5..8f3e478 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
< at >< at > -1040,7 +1040,7 < at >< at > typedef struct RedWorker {
     uint64_t *command_counter;
 #endif
 
-    int driver_has_monitors_config;
+    int driver_cap_monitors_config;
     int set_client_capabilities_pending;
 } RedWorker;
 
< at >< at > -11442,7 +11442,9 < at >< at > static void dev_create_primary_surface(RedWorker *worker, uint32_t surface_id,
     set_monitors_config_to_primary(worker);
 
     if (display_is_connected(worker) && !worker->display_channel->common.during_target_migrate) {
-        if (!worker->driver_has_monitors_config) {
+        /* guest created primary, so it will (hopefully) send a monitors_config
+         * now, don't send our own temporary one */
+        if (!worker->driver_cap_monitors_config) {
             red_worker_push_monitors_config(worker);
         }
         red_pipes

[PATCH 0/9] 0.12.3 + a bunch of small fixes I hadlaying around

Alon Levy — 2013-05-17T15:08:05

Feel free to shoot down anything (like the rename for no apparent reason other
then using the word cap)

Alon Levy (9):
  server/red_worker:
    s/driver_has_monitors_config/driver_cap_monitors_config/ (plus small
    comment)
  server/red_worker: turn critical (assert) non error into warning
  server/tests/test_display_base: add missing set_client_capabilities,
    fix client_monitors_config signature
  server/red_worker: simplify monitors_config update
  server/tests: test_display_width_stride
  server/red_dispatcher: close pa hole in RedWorkerMessageDisplayConnect
    for valgrind
  server/dispatchers: initialize stack to 0 for valgrind
  server/red_parse_qxl: two coding convention pointer cast fix
  0.12.3 release

 NEWS                                     | 18 +++++++
 configure.ac                             |  4 +-
 server/main_dispatcher.c                 |  2 +-
 server/red_dispatcher.c                  |  8 +--
 server/red_dispatcher.h                  |  4 +-
 server/red_parse_qxl.c

Re: [PATCH spice-gtk] widget: remove grab key filter

Christophe Fergeau — 2013-05-17T12:46:12

Ah right, I read it backward ;) ACK.

Christophe

Re: where to find msg type and its meaning

Christophe Fergeau — 2013-05-17T11:45:53

You can find message type definitions at
http://cgit.freedesktop.org/spice/spice-protocol/tree/spice/enums.h#n382
They are per-channel.

Christophe

Re: 回复： MacOS SPICE client

Christophe Fergeau — 2013-05-17T11:40:38

Hi,

On Fri, May 17, 2013 at 05:00:56PM +0800, jojo wrote:

The client is all free software, and the code is already available online,
just follow the building steps, and this will download all the needed source
as part of the build process.

Christophe