gmane.comp.documentfoundation.libreoffice.devel

[PATCH] fdo#38838 Replacement of the String with OUString

Marcos Paulo dos Santos (via Code Review — 2013-05-18T22:42:23

Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/3958

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/58/3958/1

fdo#38838 Replacement of the String with OUString

Change-Id: I1feaa0bee39868aedd768202b584cabc1010f4d6
---
M cui/source/tabpages/tabarea.cxx
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/cui/source/tabpages/tabarea.cxx b/cui/source/tabpages/tabarea.cxx
index 236333d..a5b6772 100644
--- a/cui/source/tabpages/tabarea.cxx
+++ b/cui/source/tabpages/tabarea.cxx
< at >< at > -135,7 +135,7 < at >< at >
 
     // save the tables when they have been changed
 
-    const String aPath( SvtPathOptions().GetPalettePath() );
+    const OUString aPath( SvtPathOptions().GetPalettePath() );
 
     if( mnHatchingListState & CT_MODIFIED )
     {

Re: Fwd: libreoffice + liborcus build problem

Kohei Yoshida — 2013-05-18T21:40:38

You can't build the 4.0 branch with 0.5.1. You need to use 0.3.0.

Kohei

Fwd: libreoffice + liborcus build problem

Kohei Yoshida — 2013-05-18T20:11:51

Forwarding it to the list.

---------- Forwarded message ----------
From: Arkadiusz Miśkiewicz <arekm< at >maven.pl>
Date: Sat, May 18, 2013 at 3:17 PM
Subject: libreoffice + liborcus build problem
To: Kohei Yoshida <kohei.yoshida< at >gmail.com>



Hi,

Trying to build libreoffice 4.0.3.3 with liborcus 0.5.1 and that
unfortunately
fails with:

http://tnij.org/vqp8  (build log)

eg:
sc/source/filter/orcus/orcusfiltersimpl.cxx:36:20: error: cannot declare
variable 'aFactory' to be of abstract type 'ScOrcusFactory'
sc/source/filter/orcus/interface.cxx:32:69: error: cannot allocate an object
of abstract type 'ScOrcusSheet'

and similar.

Is there fix for that somewhere in libreoffice git branches?


Thanks,
--
Arkadiusz Miśkiewicz, arekm / maven.pl

[PATCH] Change compareTo -> == in dbaccess module

Paulo Henrique Cuchi (via Code Review — 2013-05-18T19:33:03

Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/3957

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/57/3957/1

Change compareTo -> == in dbaccess module

Change-Id: I4708c043713a4ae9f9e0656fddf60b0888fed96e
---
M dbaccess/source/ui/app/AppController.cxx
M dbaccess/source/ui/control/opendoccontrols.cxx
M dbaccess/source/ui/misc/UITools.cxx
3 files changed, 3 insertions(+), 3 deletions(-)



diff --git a/dbaccess/source/ui/app/AppController.cxx b/dbaccess/source/ui/app/AppController.cxx
index a8d32fa..326a3c2 100644
--- a/dbaccess/source/ui/app/AppController.cxx
+++ b/dbaccess/source/ui/app/AppController.cxx
< at >< at > -2562,7 +2562,7 < at >< at >
             OUString sName = xContent->getIdentifier()->getContentIdentifier();
             sal_Int32 nIndex = 0;
             sName = sName.copy(sName.getToken(0,'/',nIndex).getLength() + 1);
-            if ( m_aAsyncDrop.aUrl.Len() >= sName.getLength() && 0 == sName.compareTo(m_aAsyncDrop.aUrl,sName.getLen

[PATCH] Changed compareTo to startsWith

Ricardo Botto (via Code Review — 2013-05-18T19:25:35

Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/3956

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/56/3956/1

Changed compareTo to startsWith

Change-Id: Ia72e220f29c26bdf789bd3f1102b850aafcf525d
---
M vcl/generic/fontmanager/fontsubst.cxx
M vcl/source/gdi/outdev3.cxx
M vcl/source/window/window.cxx
3 files changed, 8 insertions(+), 10 deletions(-)



diff --git a/vcl/generic/fontmanager/fontsubst.cxx b/vcl/generic/fontmanager/fontsubst.cxx
index 94dcda1..36c683d 100644
--- a/vcl/generic/fontmanager/fontsubst.cxx
+++ b/vcl/generic/fontmanager/fontsubst.cxx
< at >< at > -160,8 +160,8 < at >< at >
     if( rFontSelData.IsSymbolFont() )
         return false;
     // StarSymbol is a unicode font, but it still deserves the symbol flag
-    if( 0 == rFontSelData.maSearchName.compareTo( "starsymbol", 10)
-    ||  0 == rFontSelData.maSearchName.compareTo( "opensymbol", 10) )
+    if(rFontSelData.maSearchName.startsWith( "starsymbol" )
+    || rFontSelData.maSea

Re: Gbuild explanation

David Tardon — 2013-05-18T13:51:58

Hi,

On Fri, May 17, 2013 at 03:08:20AM +0200, Mat M wrote:

We need to pass something that $(dir) can strip as file part. % is just
convenient. I.e., the calls will expand as follows:

$(dir $(call gb_AutoInstallLibs_get_target,%))
->
$(dir $(WORKDIR)/AutoInstallLibs/%)
->
$(WORKDIR)/AutoInstallLibs/


I am sorry, but I do not understand the rest of the question.

D.

[PATCH] fdo#39468 Translate German comments - graphicfilter

Christian M. Heller (via Code Review — 2013-05-18T11:19:45

Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/3955

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/55/3955/1

fdo#39468 Translate German comments - graphicfilter

Change-Id: I4e64c2d9ca8d85251a4cde5d3ab68f0956a4f0d1
---
M vcl/source/filter/graphicfilter.cxx
M vcl/source/filter/graphicfilter2.cxx
2 files changed, 41 insertions(+), 48 deletions(-)



diff --git a/vcl/source/filter/graphicfilter.cxx b/vcl/source/filter/graphicfilter.cxx
index f6d1a9f..204fe2e 100644
--- a/vcl/source/filter/graphicfilter.cxx
+++ b/vcl/source/filter/graphicfilter.cxx
< at >< at > -770,8 +770,7 < at >< at >
 
 sal_uInt16 GraphicFilter::ImpTestOrFindFormat( const String& rPath, SvStream& rStream, sal_uInt16& rFormat )
 {
-    // ggf. Filter bzw. Format durch anlesen ermitteln,
-    // oder durch anlesen zusichern, dass das Format stimmt:
+    // determine or check the filter/format by reading into it
     if( rFormat == GRFILTER_FORMAT_DONTKNOW )
     {
         String aFormat

[PATCH] fdo#63878 fix the zoom bug on RTL sheet

Faisal al-otaibi (via Code Review — 2013-05-18T05:35:01

Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/3954

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/54/3954/1

fdo#63878 fix the zoom bug on RTL sheet

fix the X position after check if the sheet are RTL

Change-Id: Icbb9ce44508698e0f03898b202e033c07ae2de70
---
M sc/source/ui/view/drawview.cxx
1 file changed, 3 insertions(+), 0 deletions(-)



diff --git a/sc/source/ui/view/drawview.cxx b/sc/source/ui/view/drawview.cxx
index e249e8c..92e9200 100644
--- a/sc/source/ui/view/drawview.cxx
+++ b/sc/source/ui/view/drawview.cxx
< at >< at > -782,6 +782,9 < at >< at >
         Point aCurPos =  pViewData->GetScrPos(  aOldStt.Col(), aOldStt.Row(), eWhich, sal_True );
         Point aCurPosHmm = pGridWin->PixelToLogic(aCurPos, aDrawMode );
         Point aGridOff = ( aCurPosHmm - aOldPos );
+        // fdo#63878 Fix the X position for RTL Sheet
+        if( pDoc->IsNegativePage( GetTab() ) )
+            aGridOff.setX( aCurPosHmm.getX() + aOldPos.getX() );

It is registration of the PNG data to a toolbar at calc.

Miday — 2013-05-18T03:09:06

Hi,

I registered the bug.

When registering the png file with alpha information to the toolbar, it 
was discolored.
https://bugs.freedesktop.org/show_bug.cgi?id=64717

LibreOffice 4.0.3/3.6.6/3.5.7    calc/write
ubuntu 12.04 32bit

Image data registered into the toolbar.
http://www.ne.jp/asahi/soft/miday/Calc_Moji/pngdata.zip

Result(256tr.png)
http://www.ne.jp/asahi/soft/miday/Calc_Moji/errorIcon.png

Please verify.

[PATCH] Loader's ImageTree doesn't store multiple image pathesanymo...

Rodolfo Ribeiro Gomes (via Code Review — 2013-05-17T23:38:37

Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/3951

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/51/3951/1

Loader's ImageTree doesn't store multiple image pathes anymore

Change-Id: Idd13039a76c46bfccad5f54e3357dde952508211
Signed-off-by: Rodolfo Ribeiro Gomes <rodolforg< at >gmail.com>
---
M vcl/inc/impimagetree.hxx
M vcl/source/gdi/impimagetree.cxx
2 files changed, 53 insertions(+), 67 deletions(-)



diff --git a/vcl/inc/impimagetree.hxx b/vcl/inc/impimagetree.hxx
index f42a039..0dc3110 100644
--- a/vcl/inc/impimagetree.hxx
+++ b/vcl/inc/impimagetree.hxx
< at >< at > -65,11 +65,10 < at >< at >
         OUString const & name, OUString const & style,
         BitmapEx & bitmap, bool localized);
 
-    typedef std::list<
-        std::pair<
-            OUString,
-            com::sun::star::uno::Reference<
-                com::sun::star::container::XNameAccess > > > Paths;
+    typedef std::pair<
+        OUString,
+        com::sun::star::uno::Referenc

[PATCH] Allow 'textual links' on icon theme packages

Rodolfo Ribeiro Gomes (via Code Review — 2013-05-17T23:38:49

Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/3953

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/53/3953/1

Allow 'textual links' on icon theme packages

This would allow use of better icon names ( fdo#30425 ) and
minimizes space size needed by reuses of same icons bitmaps
with different filenames.

Icon packages shoud have a file named "links.txt" on root folder
in order to achieve that. It binds a name of a 'virtual' file to
an existing one, to avoid duplicates.

This file should contain one or more lines like this:
path/for/fakefile_that_reuse_a_bitmap.png path/for/existing_one.png

Implemented as discussed in:
http://lists.freedesktop.org/archives/libreoffice/2013-April/049650.html

Change-Id: Ia65a1ba18f93297fae47fa520104821f6f336694
Signed-off-by: Rodolfo Ribeiro Gomes <rodolforg< at >gmail.com>
---
M vcl/inc/impimagetree.hxx
M vcl/source/gdi/impimagetree.cxx
2 files changed, 92 insertions(+), 3 deletions(-)



diff --git a/vcl/in

[PATCH] Removal of includes not needed anymore

Rodolfo Ribeiro Gomes (via Code Review — 2013-05-17T23:38:43

Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/3952

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/52/3952/1

Removal of includes not needed anymore

Change-Id: I5dccad8629a59e92dc2864e2b3630732a631ee96
Signed-off-by: Rodolfo Ribeiro Gomes <rodolforg< at >gmail.com>
---
M vcl/inc/impimagetree.hxx
M vcl/source/gdi/impimagetree.cxx
2 files changed, 0 insertions(+), 15 deletions(-)



diff --git a/vcl/inc/impimagetree.hxx b/vcl/inc/impimagetree.hxx
index 0dc3110..d22e770 100644
--- a/vcl/inc/impimagetree.hxx
+++ b/vcl/inc/impimagetree.hxx
< at >< at > -22,8 +22,6 < at >< at >
 
 #include "sal/config.h"
 
-#include <list>
-#include <utility>
 #include <vector>
 
 #include <boost/unordered_map.hpp>
diff --git a/vcl/source/gdi/impimagetree.cxx b/vcl/source/gdi/impimagetree.cxx
index 86e2f22..fe252fa 100644
--- a/vcl/source/gdi/impimagetree.cxx
+++ b/vcl/source/gdi/impimagetree.cxx
< at >< at > -20,11 +20,6 < at >< at >
 
 #include "sal/config.h"
 
-#include <list>
-#include <memory>

[PATCH] Little cleanup in image loader internal functions

Rodolfo Ribeiro Gomes (via Code Review — 2013-05-17T23:38:30

Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/3950

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/50/3950/1

Little cleanup in image loader internal functions

Change-Id: I6def704dc22d7a536849a9e4b51a08bf68778329
Signed-off-by: Rodolfo Ribeiro Gomes <rodolforg< at >gmail.com>
---
M vcl/source/gdi/impimagetree.cxx
1 file changed, 22 insertions(+), 43 deletions(-)



diff --git a/vcl/source/gdi/impimagetree.cxx b/vcl/source/gdi/impimagetree.cxx
index bcdfd01..97fa471 100644
--- a/vcl/source/gdi/impimagetree.cxx
+++ b/vcl/source/gdi/impimagetree.cxx
< at >< at > -63,13 +63,13 < at >< at >
 
 namespace {
 
-OUString createPath(
+static OUString createPath(
     OUString const & name, sal_Int32 pos, OUString const & locale)
 {
     return name.copy(0, pos + 1) + locale + name.copy(pos);
 }
 
-boost::shared_ptr< SvStream > wrapFile(osl::File & file)
+static boost::shared_ptr< SvStream > wrapFile(osl::File & file)
 {
     // This could use SvInputStream instead if

[PATCH] Make some uses of OUStrings a little more readable

Rodolfo Ribeiro Gomes (via Code Review — 2013-05-17T23:38:24

Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/3949

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/49/3949/1

Make some uses of OUStrings a little more readable

Change-Id: I2e85fa39abbff86918464aae67b4b9eacd3bf7a4
Signed-off-by: Rodolfo Ribeiro Gomes <rodolforg< at >gmail.com>
---
M vcl/source/gdi/impimagetree.cxx
1 file changed, 2 insertions(+), 8 deletions(-)



diff --git a/vcl/source/gdi/impimagetree.cxx b/vcl/source/gdi/impimagetree.cxx
index 7a2fbdd..bcdfd01 100644
--- a/vcl/source/gdi/impimagetree.cxx
+++ b/vcl/source/gdi/impimagetree.cxx
< at >< at > -66,10 +66,7 < at >< at >
 OUString createPath(
     OUString const & name, sal_Int32 pos, OUString const & locale)
 {
-    OUStringBuffer b(name.copy(0, pos + 1));
-    b.append(locale);
-    b.append(name.copy(pos));
-    return b.makeStringAndClear();
+    return name.copy(0, pos + 1) + locale + name.copy(pos);
 }
 
 boost::shared_ptr< SvStream > wrapFile(osl::File & file)
< at >< at > -279,10 +276,7 < at >< at >

Re: [libreoffice-users] Re: Ask.LibreOffice.org and Bugzilla Twitteraccounts

Joel Madero — 2013-05-17T22:18:30

On Fri, May 17, 2013 at 12:00 PM, Florian Effenberger <
floeff< at >documentfoundation.org> wrote:



+1 to what Florian said. Awesome work.


Thanks!


Joel

Re: [PATCH]fdo#55846 Comboboxes werent displayed in vertical toolbars

Eike Rathke — 2013-05-17T20:33:09

Hi Janit,

On Wednesday, 2013-04-24 00:51:59 +0530, Janit Anjaria wrote:


Sorry, that was lingering on the list too long. I'd also suggest that
you don't explicitly Cc a developer when submitting a patch on the
mailing list if s/he didn't ask for it. It leaves the impression to
others reading the list that the dev on Cc would be responsible. Which
I am not ;-)



How did you derive the hardcoded value 150, where does it originate? To
me it seems to be a value that by chance matches your screen,
resolution, window size, current width of pane, and maybe more. It does
not seem to be a generally applicable value. On the other hand, if it
really was, a named constant value would be much better suited than
repeating the hard coded value in several places throughout the code.


Same here, 120 what and why?


And this 15?



Please don't screw up existing indentation if it is reasonable.


The extra parentheses here only make the code harder to read and are not
needed.



The 150 again.
And please align comments wi

Re: Visual formula editor

Ruslan Kabatsayev — 2013-05-17T18:42:18

Hi,

On Fri, May 17, 2013 at 10:37 PM, Tomaž Vajngerl <quikee< at >gmail.com> wrote:
By _visual_ formula editor I mean the experimental feature where one
can enter formulas directly in formula viewing frame, not having to
write LO Math code itself.
So, my question is rather for specially this feature, not the whole math.
Thanks, I'll have a look in that dir.
_______________________________________________
LibreOffice mailing list
LibreOffice< at >lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Visual formula editor

Tomaž Vajngerl — 2013-05-17T18:37:10

Hi,

With formula editor you mean LO Math? I am working on a new "elements"
docking window as better alternative to the current one. All elements are
rendered so I can put in any equation that I want - see attached image. I
hope I will be able to deliver something in LO 4.1

Generally everything is in starmath folder in LO. Most interesting are
starmath/source/visitors.cxx / stamath/inc/visitors.hxx which contain
visitors which perform various tasks on a parsed equation tree like drawing
the equation. With a custom visitor you could for implement solving or
exporting.

Regards, Tomaž


On Fri, May 17, 2013 at 7:47 PM, Ruslan Kabatsayev <b7.10110111< at >gmail.com>wrote:

Re: How can I obtain the data stored in variables of Calc ?

Kohei Yoshida — 2013-05-17T18:04:29

Yes, I was confused and didn't really understand the question.

But he asked the same question on IRC, and we got this sorted out.

He somehow thought that the cell data would go to different places 
whether they are loaded from a file, or typed in by the user, which led 
to his original question.

The answer to that is all cell data go to the same place, which is 
ScDocument (and its nested internal structure).

Kohei

Visual formula editor

Ruslan Kabatsayev — 2013-05-17T17:47:06

Hi all,

Is visual formula editor still being worked on?
I'd like to make some changes on its interface, namely shortcuts to
insert some elements like fractions, roots etc., making all this feel
more like Wolfram Mathematica's formula editor (which is _quite_
powerful and logically consistent). Ideally, this would have the power
of Mathematica's formula editor, residing in a FOSS suite.
Has there in fact been any discussion on how these things should feel
like? Or is there any documentation about this?
Also, could someone give some pointers on where all this stuff is
located in the code?

Regards,
Ruslan

Re: How can I obtain the data stored in variables of Calc ?

Terrence Enger — 2013-05-17T17:45:46

I see that four days have passed without anyone biting at your
question.  Perhaps everybody has some of the confusion that I feel.

It might help us to understand your questions if you tell us something
about what you want to accomplish.  If you want to automate some
user-like actions, consider one of the scripting languages that
LibreOffice offers.  If you really want to hack on the C++ code, a
hint about your goal will permit a more focused answer.  If you just
want to understand what is going on, a different kind of answer will
be useful.

On Mon, 2013-05-13 at 07:56 -0700, leo2013 wrote: