gmane.comp.bug-tracking.mantis.devel

Stephen Morley is out of the office

2013-05-18T14:59:05

I will be out of the office starting  2013-05-18 and will not return until
2013-05-28.

Please contact Stephen Smigel for any issues that cannot wait for my
return.


DISCLAIMER: This e-mail contains information solely intended for named
recipients and is confidential and proprietary to PartnerRe. If you are not
one of the intended recipients of this message, you must not read, use or
disseminate the information in it and should notify the sender by replying
to this message and deleting it afterwards from your mail system. Please be
aware that unauthorized reproduction or distribution of this communication
is prohibited.


------------------------------------------------------------------------------
AlienVault Unified Security Management (USM) platform delivers complete
security visibility with the essential security capabilities. Easily and
efficiently configure, manage, and operate all of your security controls
from a single console and one unified framework. Download a free trial.
http://p.sf.net/sfu/al

Re: License / Copyright Header

Paul Richards — 2013-05-18T15:13:10

IIRC, the original issue that led people to discuss licensing was along the
lines of:

a) The original Mantis Code stated that it was licensed under the GPL, but
did not state the explicity 'any newer version' of the gpl statement
required. More recently, we've updated our licensed header to state GPL2+ -
but as someone pointed out before GPL2 vs GPL2+ are two different things [
https://github.com/mantisbt/mantisbt/commit/3744d8760bfdaee7af5f1d336a6f20f7430ea232
 ]

b) The original mantis soap code was dual licensed under GPL3 + commercial
license.

Now iirc, that means that mantis is actually licensed under GPL3... which
means that the GPL2+ header on the source files would be misleading.
------------------------------------------------------------------------------
AlienVault Unified Security Management (USM) platform delivers complete
security visibility with the essential security capabilities. Easily and
efficiently configure, manage, and operate all of your security controls
from a single console and o

Re: License / Copyright Header

Robert Munteanu — 2013-05-18T15:11:49

The copyright is currently assigned to a non-existent entity. For
instance, Jenkins has a more encompasing 'Jenkins contributors'
formula ( [1] ). That should be changed IMO.

[1]: http://jenkins-ci.org/mit-license

Robert




--
http://robert.muntea.nu/

------------------------------------------------------------------------------
AlienVault Unified Security Management (USM) platform delivers complete
security visibility with the essential security capabilities. Easily and
efficiently configure, manage, and operate all of your security controls
from a single console and one unified framework. Download a free trial.
http://p.sf.net/sfu/alienvault_d2d

Re: License / Copyright Header

Paul Richards — 2013-05-18T14:55:59

That's something that I think we've mentioned  before - technically I think
even historically we've agreed it would need agreement from copyright
holders.

At the same time, before we accept a patch to mantis, we should be checking
that:
a) the author of the patch is willing for the code to be used under the GPL
b) transferring copyright to 'the mantis team' [which I'd probably be
inclined to go as far to say is probably an undefined entity]. It is the
Mantis Team that is listed as the copyright owner in each file.

Some of the larger projects then have agreements people need to accept
before they can add code etc etc etc etc.

If I go to google and read http://www.gnu.org/licenses/why-assign.html :

"And despite the broad right of distribution conveyed by the GPL,
enforcement of copyright is generally not possible for distributors: only
the copyright holder or someone having assignment of the copyright can
enforce the license. If there are multiple authors of a copyrighted work,
successful enforcement depen

Re: License / Copyright Header

Damien Regad — 2013-05-17T22:07:45


It saves one commit per year to update the copyright. Which is not a big
deal (and I've actually scripted that task so it's really minimal effort to
do it - update-copyright.sh in mantisbt-tools repo). But I don't mind


That's really cosmetic as far as I'm concerned. I don't really care either.


The links you provided do not offer any justification for the change (legal
requirement ?), just stating that they will change.


The joys of copy-paste... 


Is it really worth the effort of going back and checking for each file when
it was first added to the repo ? 

As a side note, in one of your links, it's said that when merging files
created in an earlier year into the master branch, it's the *current* year
that becomes the copyright year... 


Does it really matter ? What's wrong with GPL ?


I don't think any MantisBT core code is under MIT (at least a 'git grep -w
-i mit' does not yield anything other than jquery and language files)

I know that some of John's *plugins* are under MIT though.

D



------

Re: License / Copyright Header

Robert Munteanu — 2013-05-17T19:24:23

IANAL, but my understanding is that if we want to relicense the code (
Apache-style licenses seem to be in favour these days ) we need to get
the agreement of _all_ the copyright holders. We can't simply change
it.

Robert

--
http://robert.muntea.nu/

------------------------------------------------------------------------------
AlienVault Unified Security Management (USM) platform delivers complete
security visibility with the essential security capabilities. Easily and
efficiently configure, manage, and operate all of your security controls
from a single console and one unified framework. Download a free trial.
http://p.sf.net/sfu/alienvault_d2d

Re: [mantisbt-commits] [mantisbt/mantisbt] 4775bf: Do not display login dialog when using HTTP_AUTH

Paul Richards — 2013-05-15T20:52:22

Actually, this just got reverted from 1.2.x - I think you'll find this
actually breaks 'HTTP AUTH', and that there is confusion behind additional
auth types that need to come as part of auth plugins and 'HTTP AUTH'

auth_prepare_password + auth_prepare_username set the username/password
that "http auth" deals with - therefore auth_password_match needs to check
the password matches, else it's a security risk.

Paul


On Wed, May 15, 2013 at 10:58 AM, GitHub <noreply-9UaJU3cA/F/QT0dZR+AlfA< at >public.gmane.org> wrote:

------------------------------------------------------------------------------
AlienVault Unified Security Management (USM) platform delivers complete
security visibility with the essential security capabilities. Easily and
efficiently configure, manage, and operate all of your security controls
from a single console and one unified framework. Download a free trial.
http://p.sf.net/sfu/alienvault_d2d_______________________________________________
mantisbt-dev mailing list
mantisbt-dev-5NWGOfrQmneRv+

Re: Fwd: Filters - 1.3.x/2.0.x

Paul Richards — 2013-05-12T17:03:36

The idea would be to simplify them towards user_get_access_level();

The other thing to consider is if you have a User Object:

MantisUser->GetAccessLevel()



On Sun, May 12, 2013 at 3:46 PM, Roland Becker <roland-zVvRqJHQDrk< at >public.gmane.org> wrote:

------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and 
their applications. This 200-page book is written by three acclaimed 
leaders in the field. The early access version is available now. 
Download your free book today! http://p.sf.net/sfu/neotech_d2d_may_______________________________________________
mantisbt-dev mailing list
mantisbt-dev-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f< at >public.gmane.org
https://lists.sourceforge.net/lists/listinfo/mantisbt-dev

Re: IRC-logs not updated (nt)

John Reese — 2013-05-12T15:43:53

And... of course the server promptly fell over.  However, this time when it
rebooted, mantisbot came back up with it, so logs should continue working
now.


John Reese
noswap.com


On Sun, May 12, 2013 at 8:10 AM, John Reese <john-YEv5Xp0AzNLQT0dZR+AlfA< at >public.gmane.org> wrote:

------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and 
their applications. This 200-page book is written by three acclaimed 
leaders in the field. The early access version is available now. 
Download your free book today! http://p.sf.net/sfu/neotech_d2d_may_______________________________________________
mantisbt-dev mailing list
mantisbt-dev-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f< at >public.gmane.org
https://lists.sourceforge.net/lists/listinfo/mantisbt-dev

Re: IRC-logs not updated (nt)

John Reese — 2013-05-12T15:10:50

The mantisbot configuration (specifically the alternate nick values) was
invalid and preventing the bot from starting.  I updated the config and
restarted the bot, and it is running now.  I assume that the bot has been
offline since the server restarted yesterdaya/overnight, so I don't think
much, if any, history was lost.


John Reese
noswap.com


On Sun, May 12, 2013 at 4:54 AM, Roland Becker <roland-zVvRqJHQDrk< at >public.gmane.org> wrote:

------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and 
their applications. This 200-page book is written by three acclaimed 
leaders in the field. The early access version is available now. 
Download your free book today! http://p.sf.net/sfu/neotech_d2d_may_______________________________________________
mantisbt-dev mailing list
mantisbt-dev-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f< at >public.gmane.org
https://lists.sourceforge.net/lists/lis

Re: Fwd: Filters - 1.3.x/2.0.x

Roland Becker — 2013-05-12T14:46:49

I hoped that "context concept" means that things become more clear and simple.

Now there are a lot of possible options e.g. user_get_access_level can be
called.
Current implementation in master-2.0.x:
function user_get_access_level( $p_user_id = null, $p_project_id = null ) {
  if( $p_user_id === null ) {
    $p_user_id = MantisContext::GetUser();
  }
  if( $p_project_id === null ) {
    $p_project_id = MantisContext::GetProject();
  }
…
}

possible calls:
user_get_access_level()
user_get_access_level( $p_user_id != null )
user_get_access_level( $p_user_id == null )
user_get_access_level( $p_user_id != null, $p_project_id != null )
user_get_access_level( $p_user_id != null, $p_project_id == null )
user_get_access_level( $p_user_id == null, $p_project_id != null )
user_get_access_level( $p_user_id == null, $p_project_id == null )

I prefer simple approaches,
What about only offering
function user_get_access_level() {
    $t_user_id = MantisContext::GetUser();
    $t_project_id = MantisContext::GetProject()

Re: Source control integration plugin

Paul Richards — 2013-05-12T13:25:04

Actually, it seems to have eventually pulled through commits but isn't
linking them up.


On Sun, May 12, 2013 at 1:26 PM, Paul Richards <paul-P/naLZWKUS8A3RpLMO19ww< at >public.gmane.org> wrote:

------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and 
their applications. This 200-page book is written by three acclaimed 
leaders in the field. The early access version is available now. 
Download your free book today! http://p.sf.net/sfu/neotech_d2d_may_______________________________________________
mantisbt-dev mailing list
mantisbt-dev-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f< at >public.gmane.org
https://lists.sourceforge.net/lists/listinfo/mantisbt-dev

Source control integration plugin

Paul Richards — 2013-05-12T12:26:44

looks like it may have stopped updating - can someone check?
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and 
their applications. This 200-page book is written by three acclaimed 
leaders in the field. The early access version is available now. 
Download your free book today! http://p.sf.net/sfu/neotech_d2d_may_______________________________________________
mantisbt-dev mailing list
mantisbt-dev-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f< at >public.gmane.org
https://lists.sourceforge.net/lists/listinfo/mantisbt-dev

IRC-logs not updated (nt)

Roland Becker — 2013-05-12T11:54:15

------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and 
their applications. This 200-page book is written by three acclaimed 
leaders in the field. The early access version is available now. 
Download your free book today! http://p.sf.net/sfu/neotech_d2d_may

License / Copyright Header

Paul Richards — 2013-05-11T09:47:32

We've had discussions in the past about the gpl/copyright/license we use
and associated header in the source code.

To make life easier in the future in the master-2.0.x branch, I'm about to
commit a header change along the same lines as what google did a year ago
to their chrome/chromium and associated projects source code:


1) They concluded that the copyright information only needs to contain the
initial creation year.

2) They removed the (C) text from any copyright lines.

Reference Links:
https://groups.google.com/a/chromium.org/forum/#!msg/chromium-dev/8p4JKV76kig/EE_IM4syQYkJ
https://code.google.com/p/chromium/issues/detail?id=140977

These changes are included in the commits:
https://github.com/mantisbt/mantisbt/compare/9812237facec...6057993edce0

and now for some discussion points....

3) We have some files with incorrect copyright information.

For example,
https://github.com/mantisbt/mantisbt/commits/master-1.2.x/billing_inc.php?page=2

billing_inc.php in master-1.2/master and master-2.0.x, was

Re: [mantisbt-commits] [mantisbt/mantisbt] 18113c: Prototype for mc_project_get_issues_assigned_to() ...

Paul Richards — 2013-05-11T00:22:10

I was under the impression the plan was to only include critical bug fixes
in the 1.2.x branch after the 1.2.15 release.

I'm not entirely sure I'd consider this to be a critical bug fix.

Could you elaborate on the bug this fixes?


On Fri, May 10, 2013 at 5:36 PM, GitHub <noreply-9UaJU3cA/F/QT0dZR+AlfA< at >public.gmane.org> wrote:

------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and 
their applications. This 200-page book is written by three acclaimed 
leaders in the field. The early access version is available now. 
Download your free book today! http://p.sf.net/sfu/neotech_d2d_may_______________________________________________
mantisbt-dev mailing list
mantisbt-dev-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f< at >public.gmane.org
https://lists.sourceforge.net/lists/listinfo/mantisbt-dev

Re: Fwd: Filters - 1.3.x/2.0.x

Paul Richards — 2013-05-10T20:56:23

Atrol,

Did you manage to take a look at
https://github.com/mantisbt/mantisbt/commit/b997da939b18c47840611c508e0cc2d5500cfe96
 yet?

Paul


On Fri, Apr 12, 2013 at 10:18 AM, Roland Becker <roland-zVvRqJHQDrk< at >public.gmane.org> wrote:

------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and 
their applications. This 200-page book is written by three acclaimed 
leaders in the field. The early access version is available now. 
Download your free book today! http://p.sf.net/sfu/neotech_d2d_may_______________________________________________
mantisbt-dev mailing list
mantisbt-dev-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f< at >public.gmane.org
https://lists.sourceforge.net/lists/listinfo/mantisbt-dev

Re: Unit test failures

Victor Boctor — 2013-05-07T04:40:40

Not urgent, I've opened a bug
http://www.mantisbt.org/bugs/view.php?id=15817


On Mon, May 6, 2013 at 2:37 PM, Damien Regad <damien.regad-5ypYqlS8vzm41k5uCYKmRQ< at >public.gmane.org>wrote:

------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and 
their applications. This 200-page book is written by three acclaimed 
leaders in the field. The early access version is available now. 
Download your free book today! http://p.sf.net/sfu/neotech_d2d_may_______________________________________________
mantisbt-dev mailing list
mantisbt-dev-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f< at >public.gmane.org
https://lists.sourceforge.net/lists/listinfo/mantisbt-dev

Re: Unit test failures

Damien Regad — 2013-05-06T21:37:33

Robert Munteanu <robert.munteanu-Re5JQEeQqe8Avxt
iuMwx3w-XMD5yJDbdMReXY1tMh2IBg< at >public.gmane.org> Wrote in message:
[...]

Ah yes you're right, forgot about this compatibility issue. Not
 sure i can be bothered to downgrade my dev box to test this on
 nusoap though ;) But i may have a server at work with a PHP 5.3
 setup.


Nothing urgent from my pow - maybe Victor has a different
 perception though. 



----Android NewsGroup Reader----
http://www.piaohong.tk/newsgroup


------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and 
their applications. This 200-page book is written by three acclaimed 
leaders in the field. The early access version is available now. 
Download your free book today! http://p.sf.net/sfu/neotech_d2d_may

Re: Unit test failures

Robert Munteanu — 2013-05-06T19:39:39

On Mon, May 6, 2013 at 2:08 PM, Damien Regad
<damien.regad-5ypYqlS8vzm41k5uCYKmRQ< at >public.gmane.org> wrote:

Yes


OK



I guess you're using PHP 5.4, and nusoap does not support it.


If you think the test is incorrect, fix it. But make sure it's the
test and not the actual code. I won't be able to look into this for
the next two weeks so if it's urgent don't wait for me to
fix/review/whatever.

Robert




--
http://robert.muntea.nu/

------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and 
their applications. This 200-page book is written by three acclaimed 
leaders in the field. The early access version is available now. 
Download your free book today! http://p.sf.net/sfu/neotech_d2d_may

Re: Unit test failures

Damien Regad — 2013-05-06T11:08:16

I assume you mean setting $g_mc_use_nusoap in mc_config_inc.php ?

A. $g_mc_use_nusoap = OFF;

I get the same behavior reported by Victor, i.e.

$ phpunit --bootstrap tests/bootstrap.php tests/soap/AttachmentTest.php

There was 1 failure:

1) AttachmentTest::testAttachmentIsAdded
Failed asserting that two strings are equal.
--- Expected
+++ Actual
< at >< at > < at >< at >
-'http://localhost/mantis/dev/file_download.php?file_id=229&type=bug'
+'http://localhost/mantis/dev/file_download.php?file_id=229&amp;type=bug'

/path/to/mantisbt/tests/soap/AttachmentTest.php:76


B. $g_mc_use_nusoap = ON;

It's even worse, now the test does not even run ;-) But as I don't use this
much, it could be due to my setup.

$ phpunit --bootstrap tests/bootstrap.php tests/soap/AttachmentTest.php

[...]

There was 1 error:

1) AttachmentTest::testAttachmentIsAdded
SoapFault: Error Type: SYSTEM NOTICE,
Error Description: Array to string conversion

/path/to/mantisbt/tests/soap/AttachmentTest.php:67


Note, I get Similar results for VersionTest.php