gmane.comp.boot-loaders.u-boot

Re: [PATCH 3/3] omap: cm_t35: Fix cm_t35 for weaksplash_screen_prepare

Igor Grinberg — 2013-06-19T05:38:45

Yes, that's understood.
There are plenty of simple patches, but still it is a good practice
to have even a minimal commit message.

[PATCH] ARM: OMAP4+: Fix MA detection duringSDRAM_AUTO_DETECTION

Lokesh Vutla — 2013-06-19T05:20:45

During SDRAM_AUTO_DETECTION MA is not configured.
For Soc's > OMAP4460 MA is present. So populating
MA for the same.

Tested on OMAP4430 PANDA, OMAP4460 PANDA.

Reported-by: Dan Murphy <dmurphy< at >ti.com>
Signed-off-by: Lokesh Vutla <lokeshvutla< at >ti.com>
---
 arch/arm/cpu/armv7/omap-common/emif-common.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/cpu/armv7/omap-common/emif-common.c b/arch/arm/cpu/armv7/omap-common/emif-common.c
index 11e830a..e6287cd 100644
--- a/arch/arm/cpu/armv7/omap-common/emif-common.c
+++ b/arch/arm/cpu/armv7/omap-common/emif-common.c
< at >< at > -1180,6 +1180,9 < at >< at > void dmm_init(u32 base)
 /* TRAP for invalid TILER mappings in section 0 */
 lis_map_regs_calculated.dmm_lisa_map_0 = DMM_LISA_MAP_0_INVAL_ADDR_TRAP;
 
+if (omap_revision() >= OMAP4460_ES1_0)
+lis_map_regs_calculated.is_ma_present = 1;
+
 lisa_map_regs = &lis_map_regs_calculated;
 #endif
 struct dmm_lisa_map_regs *hw_lisa_map_regs =

Re: [PATCH 4/4] sf: Warn to use BAR for > 16MiB flashes

Simon Glass — 2013-06-19T04:32:27

Hi Jagan,

On Fri, Jun 14, 2013 at 1:18 PM, Jagannadha Sutradharudu Teki <
jagannadha.sutradharudu-teki< at >xilinx.com> wrote:


Perhaps you can shorten this to fit on one line?

Warning: CONFIG_SPI_FLASH_BAR provides full access to >16MiB devices

Anyway you should not split strings across lines.

+       }
Regards,
Simon
_______________________________________________
U-Boot mailing list
U-Boot< at >lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [PATCH 1/4] sf: Unify spi_flash write code

Simon Glass — 2013-06-19T04:31:31

Hi Jagan,

On Fri, Jun 14, 2013 at 1:18 PM, Jagannadha Sutradharudu Teki <
jagannadha.sutradharudu-teki< at >xilinx.com> wrote:


This looks good except that  spi_flash_write_common() is not a great name -
only one of the operations is a 'write'. Perhaps spi_flash_oper_common() or
similar?

Regards,
Simon
_______________________________________________
U-Boot mailing list
U-Boot< at >lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [PATCH v4 14/14] sf: Add Flag status register pollingsupport

Simon Glass — 2013-06-19T04:30:28

Hi Jagan,

On Thu, Jun 13, 2013 at 1:55 PM, Jagannadha Sutradharudu Teki <
jagannadha.sutradharudu-teki< at >xilinx.com> wrote:


Move this line into spi_flash_do_alloc()

+       if ((*idp == SPI_FLASH_STMICRO_IDCODE0) &&

...and the above into the stmicro.c's probe handler


Simon
_______________________________________________
U-Boot mailing list
U-Boot< at >lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [PATCH v4 05/14] sf: Update sf read to support allsizes of flashes

Simon Glass — 2013-06-19T04:29:14

Hi Jagan,

On Thu, Jun 13, 2013 at 1:55 PM, Jagannadha Sutradharudu Teki <
jagannadha.sutradharudu-teki< at >xilinx.com> wrote:


FYI you can also use 'sf test' to get performance numbers.

Regards,
Simon
_______________________________________________
U-Boot mailing list
U-Boot< at >lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [PATCH v4 02/14] sf: Discover the bank addr commands

Simon Glass — 2013-06-19T04:28:23

Hi Jagan,

On Thu, Jun 13, 2013 at 1:55 PM, Jagannadha Sutradharudu Teki <
jagannadha.sutradharudu-teki< at >xilinx.com> wrote:


I suggest bank_read_cmd, bank_write_cmd


Regards,
Simon
_______________________________________________
U-Boot mailing list
U-Boot< at >lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[PATCH v3 03/16] sandbox: config: Don't use 64-bitphysical memory

Simon Glass — 2013-06-19T03:52:27

Sandbox uses an emulated memory map which is quite small. We don't need the
CONFIG_PHYS_64BIT option since we can address memory with a 32-bit offset
into our ram_buf.

Adjust the phys_addr_t and phys_size_t types accordingly.

Signed-off-by: Simon Glass <sjg< at >chromium.org>
---
Changes in v3: None
Changes in v2: None

 arch/sandbox/include/asm/types.h | 4 ++--
 include/configs/sandbox.h        | 1 -
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/sandbox/include/asm/types.h b/arch/sandbox/include/asm/types.h
index 2316c2d..07c2986 100644
--- a/arch/sandbox/include/asm/types.h
+++ b/arch/sandbox/include/asm/types.h
< at >< at > -64,8 +64,8 < at >< at > typedef unsigned long long u64;
 #define BITS_PER_LONGCONFIG_SANDBOX_BITS_PER_LONG
 
 typedef unsigned long dma_addr_t;
-typedef unsigned long phys_addr_t;
-typedef unsigned long phys_size_t;
+typedef u32 phys_addr_t;
+typedef u32 phys_size_t;
 
 #endif /* __KERNEL__ */
 
diff --git a/include/configs/sandbox.h b/include/configs/sandbox.h
index 788207d..78eda90

[PATCH v3 07/16] dm: Add base driver model support

Simon Glass — 2013-06-19T03:52:31

Add driver model functionality for generic board.

This includes data structures and base code for registering devices and
uclasses (groups of devices with the same purpose, e.g. all I2C ports will
be in the same uclass).

The feature is enabled with CONFIG_DM.

Signed-off-by: Simon Glass <sjg< at >chromium.org>
Signed-off-by: Marek Vasut <marex< at >denx.de>
Signed-off-by: Pavel Herrmann <morpheus.ibis< at >gmail.com>
Signed-off-by: Viktor Křivák <viktor.krivak< at >gmail.com>
Signed-off-by: Tomas Hlavacek <tmshlvck< at >gmail.com>
---
Changes in v3:
- Tidy up commenting of functions and structures
- Rename per_device_priv_size to per_device_auto_alloc_size, etc.
- Add a flag for tracking whether DM allocates/frees platform_data

Changes in v2: None

 Makefile                          |   2 +
 common/dm/Makefile                |  43 +++++
 common/dm/device.c                | 331 ++++++++++++++++++++++++++++++++++++++
 common/dm/lists.c                 | 168 +++++++++++++++++++
 common/dm/root.c                  | 115 ++++++++++++

[PATCH v3 10/16] dm: Add a 'dm' command for testing

Simon Glass — 2013-06-19T03:52:34

This command is not required for driver model operation, but can be useful
for testing. It provides simple dumps of internal data structures.

Signed-off-by: Simon Glass <sjg< at >chromium.org>
Signed-off-by: Marek Vasut <marex< at >denx.de>
Signed-off-by: Pavel Herrmann <morpheus.ibis< at >gmail.com>
Signed-off-by: Viktor Křivák <viktor.krivak< at >gmail.com>
Signed-off-by: Tomas Hlavacek <tmshlvck< at >gmail.com>
---
Changes in v3: None
Changes in v2: None

 include/configs/sandbox.h |   1 +
 test/dm/Makefile          |   1 +
 test/dm/cmd_dm.c          | 146 ++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 148 insertions(+)
 create mode 100644 test/dm/cmd_dm.c

diff --git a/include/configs/sandbox.h b/include/configs/sandbox.h
index 38e0384..8e9a661 100644
--- a/include/configs/sandbox.h
+++ b/include/configs/sandbox.h
< at >< at > -23,6 +23,7 < at >< at >
 #define __CONFIG_H
 
 #define CONFIG_DM
+#define CONFIG_CMD_DM
 #define CONFIG_DM_TEST
 
 /* Number of bits in a C 'long' on this architecture */
diff --git a/test/dm/Makefile b/

[PATCH v3 11/16] dm: Add a demonstration/example driver

Simon Glass — 2013-06-19T03:52:35

As an example of how to write a uclass and a driver, provide a demo version
of each, accessible through the 'demo' command.

To use these with driver model, define CONFIG_CMD_DEMO and CONFIG_DM_DEMO.

The two demo drivers are enabled with CONFIG_DM_DEMO_SIMPLE and
CONFIG_DM_DEMO_SHAPE.

Signed-off-by: Simon Glass <sjg< at >chromium.org>
Signed-off-by: Marek Vasut <marex< at >denx.de>
Signed-off-by: Pavel Herrmann <morpheus.ibis< at >gmail.com>
Signed-off-by: Viktor Křivák <viktor.krivak< at >gmail.com>
Signed-off-by: Tomas Hlavacek <tmshlvck< at >gmail.com>
---
Changes in v3:
- Fix up demo command help
- Update demo driver to use device tree

Changes in v2: None

 Makefile                   |   1 +
 common/Makefile            |   1 +
 common/cmd_demo.c          | 115 ++++++++++++++++++++++++++++++++++++
 drivers/demo/Makefile      |  44 ++++++++++++++
 drivers/demo/demo-pdata.c  |  60 +++++++++++++++++++
 drivers/demo/demo-shape.c  | 143 +++++++++++++++++++++++++++++++++++++++++++++
 drivers/demo/demo-simple.c |  61 ++++++++++++++

[PATCH v3 02/16] sandbox: Correct data sizes and printf()strings in fdtdec.c

Simon Glass — 2013-06-19T03:52:26

There are a few warnings in this file when building for sandbox. Addresses
coming from the device tree need to be treated as ulong as elsewhere in
U-Boot and we must use map_sysmem() to convert to a pointer when needed.

Signed-off-by: Simon Glass <sjg< at >chromium.org>
---
Changes in v3: None
Changes in v2: None

 lib/fdtdec.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/fdtdec.c b/lib/fdtdec.c
index 005ad3d..dc53a1a 100644
--- a/lib/fdtdec.c
+++ b/lib/fdtdec.c
< at >< at > -93,10 +93,10 < at >< at > fdt_addr_t fdtdec_get_addr_size(const void *blob, int node,
 size = (fdt_size_t *)((char *)cell +
 sizeof(fdt_addr_t));
 *sizep = fdt_size_to_cpu(*size);
-debug("addr=%p, size=%p\n", (void *)addr,
-      (void *)*sizep);
+debug("addr=%08lx, size=%08x\n",
+      (ulong)addr, *sizep);
 } else {
-debug("%p\n", (void *)addr);
+debug("%08lx\n", (ulong)addr);
 }
 return addr;
 }
< at >< at > -618,7 +618,7 < at >< at > int fdtdec_decode_region(const void *blob, int node,
 if (!cell || (len

[PATCH v3 04/16] sandbox: Build a device tree file forsandbox

Simon Glass — 2013-06-19T03:52:28

Add support for building a device tree for sandbox's CONFIG_OF_HOSTFILE
option to make it easier to use device tree with sandbox.

This adjusts the Makefile to build a u-boot.dtb file which can be passed
to sandbox U-Boot with:

   ./u-boot -d u-boot.dtb

Signed-off-by: Simon Glass <sjg< at >chromium.org>
---
Changes in v3:
- Add new patch to build a device tree file for sandbox

Changes in v2: None

 Makefile                      |  1 +
 arch/sandbox/config.mk        |  2 ++
 board/sandbox/dts/sandbox.dts | 20 ++++++++++++++++++++
 include/configs/sandbox.h     |  1 +
 4 files changed, 24 insertions(+)
 create mode 100644 board/sandbox/dts/sandbox.dts

diff --git a/Makefile b/Makefile
index 693b3f2..ed8068b 100644
--- a/Makefile
+++ b/Makefile
< at >< at > -413,6 +413,7 < at >< at > ALL-$(CONFIG_NAND_U_BOOT) += $(obj)u-boot-nand.bin
 ALL-$(CONFIG_ONENAND_U_BOOT) += $(obj)u-boot-onenand.bin
 ALL-$(CONFIG_SPL) += $(obj)spl/u-boot-spl.bin
 ALL-$(CONFIG_OF_SEPARATE) += $(obj)u-boot.dtb $(obj)u-boot-dtb.bin
+ALL-$(CONFIG_OF_HOSTFILE) +=

[PATCH v3 15/16] dm: Add README for driver model

Simon Glass — 2013-06-19T03:52:39

From: Pavel Herrmann <morpheus.ibis< at >gmail.com>

This adds a README to help with understanding of this series.

Signed-off-by: Simon Glass <sjg< at >chromium.org>
---
Changes in v3:
- Updated README.txt to cover changes since version 2

Changes in v2:
- Removed pointer return values in favour of integer
- Use driver_bind() in dm_init() instead of writing new code
- Allow driver_bind() to support a NULL parent
- Add dm_warn() to warn about impending doom
- Standardise variable names (e.g. uclass instead of class)
- Remove relocation functions
- Add new header file for lists
- Add new util file to hold utility functions
- Allow a driver to bind to only one uclass
- Remove unneeded arguments to uclass_bind(), uclass_unbind()
- Rename struct device's 'bus' to 'parent'
- Rename data structures to hopefully be clearer
- Put platform_data definitions in their own header file
- Add U_BOOT_DEVICE to declare platform_data
- Add auto-probing feature for platform_data to avoid driver_bind() calls
- Add simple unit test functi

[PATCH v3 14/16] dm: Enable gpio command to support drivermodel

Simon Glass — 2013-06-19T03:52:38

Now that named GPIO banks are supported, along with a way of obtaining
the status of a GPIO (input or output), we can provide an enhanced
GPIO command for driver model. Where the driver provides its own operation
for obtaining the GPIO state, this is used, otherwise a generic version
is sufficient.

Signed-off-by: Simon Glass <sjg< at >chromium.org>
---
Changes in v3: None
Changes in v2: None

 common/cmd_gpio.c | 127 ++++++++++++++++++++++++++++++++++++++++++++++++------
 1 file changed, 114 insertions(+), 13 deletions(-)

diff --git a/common/cmd_gpio.c b/common/cmd_gpio.c
index 47eee89..c6758c1 100644
--- a/common/cmd_gpio.c
+++ b/common/cmd_gpio.c
< at >< at > -8,7 +8,7 < at >< at >
 
 #include <common.h>
 #include <command.h>
-
+#include <dm.h>
 #include <asm/gpio.h>
 
 #ifndef name_to_gpio
< at >< at > -22,25 +22,115 < at >< at > enum gpio_cmd {
 GPIO_TOGGLE,
 };
 
+#if defined(CONFIG_DM_GPIO) && !defined(gpio_status)
+static const char * const gpio_function[] = {
+"input",
+"output",
+"unknown",
+};
+
+static void show_gpio(struct device *dev

[PATCH v3 16/16] dm: Move old driver model documentationinto an 'old-docs' directory

Simon Glass — 2013-06-19T03:52:40

This documentation is still useful but is not fully correct with the API
changes since the original driver model implementation. So move it into
a separate directory, and create a README to describe what is going on.

This documentation pertains to the planned implementation of driver model
in U-Boot for each subsystem. It is probably better to have this
documentation in the source code for each subsystem where possible, so
that docbook will pick it up. Where this does not make sense, new
documentation can be placed in some suitable file in doc/driver-model.

Signed-off-by: Simon Glass <sjg< at >chromium.org>
---
Changes in v3:
- Add new patch to move driver model documentation

Changes in v2: None

 doc/driver-model/old-docs/README                 | 29 ++++++++++++++++++++++++
 doc/driver-model/{ => old-docs}/UDM-block.txt    |  0
 doc/driver-model/{ => old-docs}/UDM-cores.txt    |  0
 doc/driver-model/{ => old-docs}/UDM-design.txt   |  0
 doc/driver-model/{ => old-docs}/UDM-fpga.txt     |  0
 doc/driver-model/{

[PATCH v3 12/16] dm: Add GPIO support and tests

Simon Glass — 2013-06-19T03:52:36

Add driver model support for GPIOs. Since existing GPIO drivers do not use
driver model, this feature must be enabled by CONFIG_DM_GPIO. After all
GPO drivers are converted over we can perhaps remove this config.

Tests are provided for the sandbox implementation, and are a sufficient
sanity check for basic operation.

The GPIO uclass understands the concept of named banks of GPIOs, with each
GPIO device providing a single bank. Within each bank the GPIOs are numbered
using an offset from 0 to n-1. For example a bank named 'b' with 20
offsets will provide GPIOs named b0 to b19.

Anonymous GPIO banks are also supported, and are just numbered without any
prefix.

Each time a GPIO driver is added to the uclass, the GPIOs are renumbered
accordinging, so there is always a global GPIO numbering order.

Signed-off-by: Simon Glass <sjg< at >chromium.org>
Signed-off-by: Marek Vasut <marex< at >denx.de>
Signed-off-by: Pavel Herrmann <morpheus.ibis< at >gmail.com>
Signed-off-by: Viktor Křivák <viktor.krivak< at >gmail.com>
Signed-off-by

[PATCH v3 06/16] sandbox: config: Enable driver model

Simon Glass — 2013-06-19T03:52:30

Use driver model in sandbox to permit running of driver model unit test.

Signed-off-by: Simon Glass <sjg< at >chromium.org>
---
Changes in v3: None
Changes in v2: None

 include/configs/sandbox.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/configs/sandbox.h b/include/configs/sandbox.h
index 14f5f98..162c26c 100644
--- a/include/configs/sandbox.h
+++ b/include/configs/sandbox.h
< at >< at > -22,6 +22,8 < at >< at >
 #ifndef __CONFIG_H
 #define __CONFIG_H
 
+#define CONFIG_DM
+
 /* Number of bits in a C 'long' on this architecture */
 #define CONFIG_SANDBOX_BITS_PER_LONG64

[PATCH v3 05/16] Add cmd_process_error() to report andprocess errors

Simon Glass — 2013-06-19T03:52:29

U-Boot now uses errors defined in include/errno.h which are negative
integers. Commands which fail need to report the error and return 1
to indicate failure. Add this functionality in cmd_process_error().

For now this merely reports the error number. It would be possible
also to produce a helpful error message by storing the error strings
in U-Boot.

Signed-off-by: Simon Glass <sjg< at >chromium.org>
---
Changes in v3: None
Changes in v2: None

 common/command.c  | 10 ++++++++++
 include/command.h |  9 +++++++++
 2 files changed, 19 insertions(+)

diff --git a/common/command.c b/common/command.c
index 305a236..70faa60 100644
--- a/common/command.c
+++ b/common/command.c
< at >< at > -554,3 +554,13 < at >< at > enum command_ret_t cmd_process(int flag, int argc, char * const argv[],
 rc = cmd_usage(cmdtp);
 return rc;
 }
+
+int cmd_process_error(cmd_tbl_t *cmdtp, int err)
+{
+if (err) {
+printf("Command '%s' failed: Error %d\n", cmdtp->name, err);
+return 1;
+}
+
+return 0;
+}
diff --git a/include/command.h b/include/comman

[PATCH v3 09/16] dm: Add basic tests

Simon Glass — 2013-06-19T03:52:33

Add some tests of driver model functionality. Coverage includes:

- basic init
- binding of drivers to devices using platform_data
- automatic probing of devices when referenced
- availability of platform data to devices
- lifecycle from bind to probe to remove to unbind
- renumbering within a uclass when devices are probed/removed
- calling driver-defined operations
- deactivation of drivers when removed
- memory leak across creation and destruction of drivers/uclasses
- uclass init/destroy methods
- automatic probe/remove of children/parents when needed

This function is enabled for sandbox, using CONFIG_DM_TEST.

Signed-off-by: Simon Glass <sjg< at >chromium.org>
---
Changes in v3:
- Add function/struct comments to tests

Changes in v2: None

 Makefile                  |   1 +
 include/configs/sandbox.h |   1 +
 include/dm/test.h         | 180 +++++++++++++++
 include/dm/ut.h           | 108 +++++++++
 test/dm/Makefile          |  52 +++++
 test/dm/core.c            | 557 ++++++++++++++++++++++++++++++++++++++

[PATCH v3 13/16] sandbox: Convert GPIOs to use driver model

Simon Glass — 2013-06-19T03:52:37

Convert sandbox over to use driver model GPIOs.

Signed-off-by: Simon Glass <sjg< at >chromium.org>
---
Changes in v3:
- Update sandbox GPIO header file comments

Changes in v2: None

 arch/sandbox/include/asm/gpio.h |  14 +--
 board/sandbox/sandbox/sandbox.c |   7 +-
 drivers/gpio/sandbox.c          | 210 +++++++++++++++++++++++++---------------
 include/configs/sandbox.h       |   1 +
 4 files changed, 144 insertions(+), 88 deletions(-)

diff --git a/arch/sandbox/include/asm/gpio.h b/arch/sandbox/include/asm/gpio.h
index 0500c53..33a9929 100644
--- a/arch/sandbox/include/asm/gpio.h
+++ b/arch/sandbox/include/asm/gpio.h
< at >< at > -45,7 +45,7 < at >< at >
  * < at >param gpGPIO number
  * < at >return -1 on error, 0 if GPIO is low, >0 if high
  */
-int sandbox_gpio_get_value(unsigned gp);
+int sandbox_gpio_get_value(struct device *dev, unsigned int offset);
 
 /**
  * Set the simulated value of a GPIO (used only in sandbox test code)
< at >< at > -54,7 +54,7 < at >< at > int sandbox_gpio_get_value(unsigned gp);
  * < at >param valuevalue to set (0 for low, non-z