gmane.comp.boot-loaders.barebox

Re: [PATCH] read_file: Make it work on tftp servers which do not pass size

Alexander Aring — 2013-06-19T21:57:01

Hi,

On Wed, Jun 19, 2013 at 11:32:39PM +0200, Alexander Aring wrote:

ah, I see it now. The fs layer use size_t instead of loff_t. Sorry for
the noise.

Regards
Alex

Re: [PATCH] read_file: Make it work on tftp servers which do not pass size

Alexander Aring — 2013-06-19T21:32:40

Hi Sascha,

only a very small hint.

On Wed, Jun 19, 2013 at 10:58:48PM +0200, Sascha Hauer wrote:

...


The type of st_size in struct stat is loff_t. I check this and
((size_t)-1) is different than ((loff_t)-1), so I think we need to cast
to loff_t. Maybe it's better to use a define from limits.h, but we don't
have some header file like this.

[PATCH] partitions: dos: fix memory leak in nt disk signature

Sascha Hauer — 2013-06-19T21:00:29

Signed-off-by: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ< at >public.gmane.org>
---
 common/partitions/dos.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/common/partitions/dos.c b/common/partitions/dos.c
index b9f31c3..29f1375 100644
--- a/common/partitions/dos.c
+++ b/common/partitions/dos.c
< at >< at > -107,6 +107,8 < at >< at > static int dos_get_disk_signature(struct param_d *p, void *_priv)
 
 priv->signature = le32_to_cpup((__le32 *)(buf + 0x1b8));
 
+free(buf);
+
 return 0;
 }

[PATCH] read_file: Make it work on tftp servers which do not pass size

Sascha Hauer — 2013-06-19T20:58:48

Some tftp servers (for example netkit-tftp) do not pass the filesize.
Add a workaround for read_file which reads the file into a temporary
file which then is copied to a buffer.

Signed-off-by: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ< at >public.gmane.org>
---
 fs/fs.c      | 18 ++++++++++++++++++
 fs/tftp.c    |  5 ++++-
 include/fs.h |  2 ++
 3 files changed, 24 insertions(+), 1 deletion(-)

diff --git a/fs/fs.c b/fs/fs.c
index dc3a6e3..7046f2c 100644
--- a/fs/fs.c
+++ b/fs/fs.c
< at >< at > -38,10 +38,21 < at >< at > void *read_file(const char *filename, size_t *size)
 int fd;
 struct stat s;
 void *buf = NULL;
+const char *tmpfile = "/.read_file_tmp";
+int ret;
 
+again:
 if (stat(filename, &s))
 return NULL;
 
+if (s.st_size == FILESIZE_MAX) {
+ret = copy_file(filename, tmpfile, 0);
+if (ret)
+return NULL;
+filename = tmpfile;
+goto again;
+}
+
 buf = xzalloc(s.st_size + 1);
 
 fd = open(filename, O_RDONLY);
< at >< at > -56,12 +67,19 < at >< at > void *read_file(const char *filename, size_t *size)
 if (size)
 *size

[PATCH] bootm: factor out code to make it usable from C

Sascha Hauer — 2013-06-19T20:58:33

Much of the bootm code is implemented in the command itself. Move
it to a common place to be able to call it from C aswell.

Signed-off-by: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ< at >public.gmane.org>
---
 commands/Kconfig |   1 +
 commands/bootm.c | 281 +--------------------------------------------------
 common/Kconfig   |   3 +
 common/Makefile  |   1 +
 common/bootm.c   | 303 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
 include/boot.h   |   8 ++
 6 files changed, 321 insertions(+), 276 deletions(-)
 create mode 100644 common/bootm.c

diff --git a/commands/Kconfig b/commands/Kconfig
index a62ed98..384643b 100644
--- a/commands/Kconfig
+++ b/commands/Kconfig
< at >< at > -420,6 +420,7 < at >< at > menu "booting"
 config CMD_BOOTM
 tristate
 default y
+select BOOTM
 select CRC32
 select UIMAGE
 select UNCOMPRESS
diff --git a/commands/bootm.c b/commands/bootm.c
index 6ce2ca9..97a6698 100644
--- a/commands/bootm.c
+++ b/commands/bootm.c
< at >< at > -46,172 +46,11 < at >< at >
 #include <magicvar.h>
 #include <asm-generic/memory

[PATCH 3/3] menu: Make action callback optional

Sascha Hauer — 2013-06-19T20:53:42

Someone calling menu_show might only be interested in the entry the user
selected without having something in the action callback. Make it optional.

Signed-off-by: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ< at >public.gmane.org>
---
 common/menu.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/common/menu.c b/common/menu.c
index d516db4..ef56190 100644
--- a/common/menu.c
+++ b/common/menu.c
< at >< at > -361,7 +361,8 < at >< at > int menu_show(struct menu *m)
 break;
 clear();
 gotoXY(1,1);
-m->selected->action(m, m->selected);
+if (m->selected->action)
+m->selected->action(m, m->selected);
 if (m->selected->non_re_ent)
 return m->selected->num;
 else

[PATCH 1/3] menu: Align entries

Sascha Hauer — 2013-06-19T20:53:40

More than 9 menu entries in are single menu are not aligned anymore, like
this:

8 entry8
9 entry9
10 entry10

Use %2d in the printf format specifier to align more than 9 entries.

Signed-off-by: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ< at >public.gmane.org>
---
 common/menu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/menu.c b/common/menu.c
index a672e59..1f0ffec 100644
--- a/common/menu.c
+++ b/common/menu.c
< at >< at > -175,7 +175,7 < at >< at > static void print_menu_entry(struct menu *m, struct menu_entry *me,
 puts("   ");
 }
 
-printf(" %d: ", me->num);
+printf(" %2d: ", me->num);
 if (selected)
 puts("\e[7m");

[PATCH 2/3] Fix gotoXY argument order

Sascha Hauer — 2013-06-19T20:53:41

gotoXY has the argument order (y, x). Change this so that usage of this
function feels more natural.

Signed-off-by: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ< at >public.gmane.org>
---
 common/menu.c     | 10 +++++-----
 include/readkey.h |  2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/common/menu.c b/common/menu.c
index 1f0ffec..d516db4 100644
--- a/common/menu.c
+++ b/common/menu.c
< at >< at > -164,7 +164,7 < at >< at > static void __print_entry(const char *str)
 static void print_menu_entry(struct menu *m, struct menu_entry *me,
      int selected)
 {
-gotoXY(me->num + 1, 3);
+gotoXY(3, me->num + 1);
 
 if (me->type == MENU_ENTRY_BOX) {
 if (me->box_state)
< at >< at > -234,7 +234,7 < at >< at > static void print_menu(struct menu *m)
 struct menu_entry *me;
 
 clear();
-gotoXY(1, 2);
+gotoXY(2, 1);
 if(m->display) {
 __print_entry(m->display);
 } else {
< at >< at > -269,7 +269,7 < at >< at > int menu_show(struct menu *m)
 
 countdown = m->auto_select;
 if (m->auto_select >= 0) {
-gotoXY(m->nb_entries + 2, 3);
+gotoXY(

Some small menu updates

Sascha Hauer — 2013-06-19T20:53:39

Some minor fixes to the menu code.

Sascha

----------------------------------------------------------------
Sascha Hauer (3):
      menu: Align entries
      Fix gotoXY argument order
      menu: Make action callback optional

 common/menu.c     | 15 ++++++++-------
 include/readkey.h |  2 +-
 2 files changed, 9 insertions(+), 8 deletions(-)

Re: [PATCH] ARM: AM33xx: pcm051: Add network support

Sascha Hauer — 2013-06-19T19:52:20

Also applied.

Thanks
 Sascha

Re: [PATCHv3 1/4] ARM: OMAP: AM33xx: Add muxing function for spi0

Sascha Hauer — 2013-06-19T19:51:49

Applied all, 

Thanks
 Sascha

Re: Boot imx53 from spi nor flash

Sascha Hauer — 2013-06-19T12:18:18

If an image boots from SD/MMC it should also boot from SPI NOR flash.

Sascha

Boot imx53 from spi nor flash

Vanhauwaert Wouter — 2013-06-19T12:12:42

I want to be able to boot my imx53 from spi nor flash, but am a bit lost on how to accomplish this.
How do I have to configure my boot source? Do I have to add this 0x400 offset to the image? Any reference?

Grtz,
Wouter

[PATCH 2/2] ARM omap-fb: add board helper code

Christoph Fritz — 2013-06-19T09:39:41

This patch adds OMAP machine dependent framebuffer code so that
board files can make use of driver omap-fb.

Signed-off-by: Christoph Fritz <chf.fritz-gM/Ye1E23mwN+BqQ9rBEUg< at >public.gmane.org>
---
 arch/arm/mach-omap/Makefile               |    2 +-
 arch/arm/mach-omap/include/mach/omap-fb.h |   47 +++++++++++++++++++++++++++++
 arch/arm/mach-omap/omap_fb.c              |   34 +++++++++++++++++++++
 3 files changed, 82 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/mach-omap/include/mach/omap-fb.h
 create mode 100644 arch/arm/mach-omap/omap_fb.c

diff --git a/arch/arm/mach-omap/Makefile b/arch/arm/mach-omap/Makefile
index 94e42c6..bc5daab 100644
--- a/arch/arm/mach-omap/Makefile
+++ b/arch/arm/mach-omap/Makefile
< at >< at > -15,7 +15,7 < at >< at >
 # GNU General Public License for more details.
 #
 #
-obj-$(CONFIG_ARCH_OMAP) += syslib.o omap_devices.o
+obj-$(CONFIG_ARCH_OMAP) += syslib.o omap_devices.o omap_fb.o
 pbl-$(CONFIG_ARCH_OMAP) += syslib.o
 obj-$(CONFIG_OMAP_CLOCK_SOURCE_S32K) += s32k_clksource.o
 obj-$(CON

[PATCH 1/2] omap-fb: add driver

Christoph Fritz — 2013-06-19T09:33:15

This patch adds omap display controller support. Currently only
OMAP4 DSS is supported.

Signed-off-by: Christoph Fritz <chf.fritz-gM/Ye1E23mwN+BqQ9rBEUg< at >public.gmane.org>
---
 drivers/video/Kconfig  |    8 +
 drivers/video/Makefile |    1 +
 drivers/video/omap.c   |  524 ++++++++++++++++++++++++++++++++++++++++++++++++
 drivers/video/omap.h   |  187 +++++++++++++++++
 4 files changed, 720 insertions(+)
 create mode 100644 drivers/video/omap.c
 create mode 100644 drivers/video/omap.h

diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index 6d6b08f..0639d9c 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
< at >< at > -45,6 +45,14 < at >< at > config DRIVER_VIDEO_S3C24XX
 help
   Add support for the S3C244x LCD controller.
 
+config DRIVER_VIDEO_OMAP
+bool "OMAP framebuffer driver"
+depends on ARCH_OMAP4
+help
+  Add support for OMAP Display Controller. Currently this
+  driver only supports OMAP4 SoCs in DISPC parallel mode on
+  LCD2 (MIPI DPI).
+
 if DRIVER_VIDEO_S3C24XX
 
 config DRIVER_VIDEO_S

[PATCH 4/8] MIPS: mach-ar231x: add lowlevel init pbl macros

Oleksij Rempel — 2013-06-19T09:11:29

Signed-off-by: Oleksij Rempel <linux-YEK0n+YFykbzxQdaRaTXBw< at >public.gmane.org>
Signed-off-by: Antony Pavlov <antonynpavlov-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org>
---
 arch/mips/mach-ar231x/include/mach/pbl_macros.h | 177 ++++++++++++++++++++++++
 1 file changed, 177 insertions(+)
 create mode 100644 arch/mips/mach-ar231x/include/mach/pbl_macros.h

diff --git a/arch/mips/mach-ar231x/include/mach/pbl_macros.h b/arch/mips/mach-ar231x/include/mach/pbl_macros.h
new file mode 100644
index 0000000..cb72dbe
--- /dev/null
+++ b/arch/mips/mach-ar231x/include/mach/pbl_macros.h
< at >< at > -0,0 +1,177 < at >< at >
+#ifndef __ASM_MACH_AR2312_PBL_MACROS_H
+#define __ASM_MACH_AR2312_PBL_MACROS_H
+
+#include <asm/regdef.h>
+#include <mach/ar2312_regs.h>
+
+.macropbl_ar2312_pll
+.setpush
+.setnoreorder
+
+mfc0k0, CP0_STATUS
+lik1, ST0_NMI
+andk1, k1, k0
+bnezk1, pllskip
+ nop
+
+/* Clear any prior AHB errors by reading both addr registers */
+lit0, KSEG1 | AR2312_PROCADDR
+lwzero, 0(t0)
+lit0, KSEG1 | AR2312_DMAADDR
+lw

[PATCH 6/8] MIPS: netgear-wg102: add debug_ll

Oleksij Rempel — 2013-06-19T09:11:31

Signed-off-by: Oleksij Rempel <linux-YEK0n+YFykbzxQdaRaTXBw< at >public.gmane.org>
---
 .../boards/netgear-wg102/include/board/debug_ll.h  | 33 ++++++++++++++++++++++
 1 file changed, 33 insertions(+)
 create mode 100644 arch/mips/boards/netgear-wg102/include/board/debug_ll.h

diff --git a/arch/mips/boards/netgear-wg102/include/board/debug_ll.h b/arch/mips/boards/netgear-wg102/include/board/debug_ll.h
new file mode 100644
index 0000000..2725032
--- /dev/null
+++ b/arch/mips/boards/netgear-wg102/include/board/debug_ll.h
< at >< at > -0,0 +1,33 < at >< at >
+/*
+ * Copyright (C) 2013 Oleksij Rempel <linux-YEK0n+YFykbzxQdaRaTXBw< at >public.gmane.org>
+ *
+ * This file is part of barebox.
+ * See file CREDITS for list of people who contributed to this project.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2
+ * as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY

[PATCH 7/8] MIPS: mach-ar231x: enable DEBUG_LL

Oleksij Rempel — 2013-06-19T09:11:32

From: Antony Pavlov <antonynpavlov-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org>

Signed-off-by: Antony Pavlov <antonynpavlov-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org>
---
 arch/mips/Kconfig                             |  1 +
 arch/mips/mach-ar231x/include/mach/debug_ll.h | 27 +++++++++++++++++++++++++++
 2 files changed, 28 insertions(+)
 create mode 100644 arch/mips/mach-ar231x/include/mach/debug_ll.h

diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index 2e44619..6179fd8 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
< at >< at > -52,6 +52,7 < at >< at > config MACH_MIPS_AR231X
 select SYS_SUPPORTS_BIG_ENDIAN
 select CSRC_R4K_LIB
 select DRIVER_SERIAL_NS16550
+select HAS_DEBUG_LL
 
 config MACH_MIPS_BCM47XX
 bool "Broadcom BCM47xx-based boards"
diff --git a/arch/mips/mach-ar231x/include/mach/debug_ll.h b/arch/mips/mach-ar231x/include/mach/debug_ll.h
new file mode 100644
index 0000000..5ab7f9a
--- /dev/null
+++ b/arch/mips/mach-ar231x/include/mach/debug_ll.h
< at >< at > -0,0 +1,27 < at >< at >
+/*
+ * Copyright (C) 2013 Antony Pavlov

[PATCH 3/8] MIPS: pbl: add pbl_probe_mem macro

Oleksij Rempel — 2013-06-19T09:11:28

Signed-off-by: Oleksij Rempel <linux-YEK0n+YFykbzxQdaRaTXBw< at >public.gmane.org>
---
 arch/mips/include/asm/pbl_macros.h | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/mips/include/asm/pbl_macros.h b/arch/mips/include/asm/pbl_macros.h
index cfca117..22d41b8 100644
--- a/arch/mips/include/asm/pbl_macros.h
+++ b/arch/mips/include/asm/pbl_macros.h
< at >< at > -38,6 +38,18 < at >< at >
 .setpop
 .endm
 
+.macropbl_probe_mem ret1 ret2 addr
+.setpush
+.setnoreorder
+la\ret1, \addr
+swzero, 0(\ret1)
+li\ret2, 0x12345678
+sw\ret2, 0(\ret1)
+lw\ret2, 0(\ret1)
+li\ret1, 0x12345678
+.setpop
+.endm
+
 /*
  * ADR macro instruction (inspired by ARM)
  *

[PATCH 5/8] MIPS: netgear-wg102: add pbl support

Oleksij Rempel — 2013-06-19T09:11:30

Signed-off-by: Antony Pavlov <antonynpavlov-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org>
Signed-off-by: Oleksij Rempel <linux-YEK0n+YFykbzxQdaRaTXBw< at >public.gmane.org>
---
 .../netgear-wg102/include/board/board_pbl_start.h  | 69 ++++++++++++++++++++++
 arch/mips/mach-ar231x/Kconfig                      |  2 +
 2 files changed, 71 insertions(+)
 create mode 100644 arch/mips/boards/netgear-wg102/include/board/board_pbl_start.h

diff --git a/arch/mips/boards/netgear-wg102/include/board/board_pbl_start.h b/arch/mips/boards/netgear-wg102/include/board/board_pbl_start.h
new file mode 100644
index 0000000..4deae06
--- /dev/null
+++ b/arch/mips/boards/netgear-wg102/include/board/board_pbl_start.h
< at >< at > -0,0 +1,69 < at >< at >
+/*
+ * Copyright (C) 2013 Antony Pavlov <antonynpavlov-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org>
+ * Copyright (C) 2013 Oleksij Rempel <linux-YEK0n+YFykbzxQdaRaTXBw< at >public.gmane.org>
+ *
+ * This file is part of barebox.
+ * See file CREDITS for list of people who contributed to this project.
+ *
+ * This progra

[PATCH 1/8] MIPS: pbl: add mips_barebox_10h asm macro

Oleksij Rempel — 2013-06-19T09:11:26

From: Antony Pavlov <antonynpavlov-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org>

The mips_barebox_10h macro inserts at offset 0x10
of the barebox image the string 'barebox ' followed
by compile time version mark.

Signed-off-by: Antony Pavlov <antonynpavlov-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org>
---
 arch/mips/include/asm/pbl_macros.h | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/mips/include/asm/pbl_macros.h b/arch/mips/include/asm/pbl_macros.h
index 3971b61..a3f970c 100644
--- a/arch/mips/include/asm/pbl_macros.h
+++ b/arch/mips/include/asm/pbl_macros.h
< at >< at > -97,6 +97,22 < at >< at > copy_loop_exit:
 .setpop
 .endm
 
+.macromips_barebox_10h
+.setpush
+.setnoreorder
+
+b1f
+ nop
+
+.org0x10
+.ascii"barebox " UTS_RELEASE " " UTS_VERSION
+.byte0
+
+.align4
+1:
+.setpop
+.endm
+
 /*
  * Dominic Sweetman, See MIPS Run, Morgan Kaufmann, 2nd edition, 2006
  *