gmane.comp.audio.cd-paranoia.devel

Link to Asunder

Andrew Smith — 2010-12-28T07:34:59

Hi

Sorry for the spam, I don't know who to email. I just feel it's a shame 
and wanted to ask you to fix it if willing:

Would mind adding a link to Asunder ( http://littlesvr.ca/asunder/ ) on 
your Links page?

Thanks

Andrew

Re: PATCH: slight memleak in initialization

Ruben Safir — 2010-11-10T01:20:27


That is the malloc issue that we found a few years back that we thought
about fixing?  What made you finally get to that?

Ruben

PATCH: slight memleak in initialization

Billy — 2010-11-09T17:41:24

Also simplify the pattern-matching loop that generates device names.

Reported 6 years ago as Debian Bug #245167 [1] and long forgotten about.

But the bug is still in the code, so I revamped the patch.

[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=245167
_______________________________________________
Paranoia-dev mailing list
Paranoia-dev< at >xiph.org
http://lists.xiph.org/mailman/listinfo/paranoia-dev

[PATCH] add pkg-config .pc file for cdparanoia

Tim-Philipp Müller — 2010-04-13T11:38:04

Hi,

it would be nice if Cdparanoia installed a .pc file for pkg-config
alongside its headers and libs.

This makes it easier for applications and libs using cdparanoia to
correctly check for the existence of cdparanoia, query its version, or
figure out the right include paths and linker flags.

Patch attached (configure in svn will need to be recreated after
applying the patch).

 Cheers
  -Tim
_______________________________________________
Paranoia-dev mailing list
Paranoia-dev< at >xiph.org
http://lists.xiph.org/mailman/listinfo/paranoia-dev

Re: Are patches welcome?

2009-12-11T20:07:44

I strongly prefer having patches, along with descriptions of what the
patches do.  It saves me the work of filtering irrelevant
inconsistencies between the source trees, as well as forces the
submitter to do a little additional review before submission :-)

I understand patches are not of interest to the entire list; feel free
to mail them to me directly (monty< at >xiph.org or xiphmont< at >gmail.com).

Thank you!
Monty

[patch] cdparanoia sample offset inconsistency

Eric Lesage — 2009-12-11T08:31:40

Hello,

Apologies if this is a duplicate. I've sent a previous version to the list 
but it appears it did not get through. The version of the patch included 
herein is better anyway.

I've encountered a problem when using the -O (--sample-offset) option. 
Currently, the code checks whether the specified offset is more than 588 
samples, and if so biases the sectors in the (internal) TOC so that the 
offset becomes less than 588.

However, this creates an inconsistency when the span is analyzed: the span 
might both refer to (corrected) values from the TOC (e.g. end of disk) and 
uncorrected values (e.g. absolute sector positions).

E.g.: [.2000]- (read from sector 2000 to end of disk).

The included patch fixes this by adding the offset in sectors specified 
using absolute positions.

Best regards,

Re: Are patches welcome?

Rogério Brito — 2009-12-10T00:29:09

Hi, Monty.

On 12/09/2009 08:25 PM, xiphmont< at >xiph.org wrote:

Thank you so very much for your kindness to accept comments from outsiders.

I hope that you don't mind if I send you links for our tree instead of sending
some patches that may be large for e-mails. If you would prefer some other
address to send them to, please let me know.

(I'm still a rookie with git).


Thank you very much.

Rogério Brito.

Re: Are patches welcome?

2009-12-09T22:25:48

I'm happy to review all patches and there are certainly minor faults
in the current release I need to review for a new release anyway.
This is a good time to send patches in!  If I don't accept them for
one reason or another, I'll give feedback why.

I'm not fussy about indent or style in patches as I carefully review
and hand apply in any case.  Don't worry about nitpicky details, I'm
more interested in what they do and how they do it.

Monty

Are patches welcome?

Rogério Brito — 2009-12-07T14:36:24

Hi, all.

Are patches welcome in the upstream cdparanoia project?

I am part of the Optical Media tools in Debian, together with Takaki
Taniguchi, taking care of the packaging of some tools, of which
cdparanoia is part.

We have some patches in our tree and it would be desireable to have as
little difference with you as possible. Some patches seem to be quite
trivial (like spelling errors), while others are less trivial.

So, would you like to get the patches that we have? I just checked and
some of them do apply to the SVN repo as of this exact moment.


Thanks in advance, Rogério Brito.

Patch for original XBOX drives

Russell Salerno — 2009-10-03T21:02:42

Hello all,

I'm on a mission to get cdparanoia to work on original XBoxes (not
360) fitted with Philips and/or Thompson DVD drives.  In sum, the
original XBox came fitted with either a Thompson, Philips, or Samsung
DVD drive.  Cdparanoia recognizes and works with the XBox Samsung
drive, but not the Philips and/or Thompson drives because they do not
identify themselves as having CD ripping capabilities.  I tried
patching the release 10pre0 (which is the installed version on my xDSL
box) with Michael Steil's patch but it did not make any difference.
See, e.g., http://lists.xiph.org/pipermail/paranoia-dev/2003-August/000125.html

Ultimately I'd like to add an option e.g., -xbox philips or -xbox
thompson that will force cdparanoia to skip any drive capability tests
and just rip using predetermined parameters.

My question to the group is where in the code should I start poking to
implement such a patch and also, if anyone has attempted this and/or
has any other insight into this particular area.

Thanks in advan

Patch for original XBOX drives

Russell Salerno — 2009-10-03T21:02:42

Hello all,

I'm on a mission to get cdparanoia to work on original XBoxes (not
360) fitted with Philips and/or Thompson DVD drives.  In sum, the
original XBox came fitted with either a Thompson, Philips, or Samsung
DVD drive.  Cdparanoia recognizes and works with the XBox Samsung
drive, but not the Philips and/or Thompson drives because they do not
identify themselves as having CD ripping capabilities.  I tried
patching the release 10pre0 (which is the installed version on my xDSL
box) with Michael Steil's patch but it did not make any difference.
See, e.g., http://lists.xiph.org/pipermail/paranoia-dev/2003-August/000125.html

Ultimately I'd like to add an option e.g., -xbox philips or -xbox
thompson that will force cdparanoia to skip any drive capability tests
and just rip using predetermined parameters.

My question to the group is where in the code should I start poking to
implement such a patch and also, if anyone has attempted this and/or
has any other insight into this particular area.

Thanks in advan

cdparanoia hangs on the last track when using both--sample-offset and -Z

Martin Thierer — 2009-09-27T15:04:50

Hi,

I'm running cdparanoia 10.2 on gentoo linux x64.

When ripping the last track of an audio-cd and using both the options
"--sample-offset" and "-Z", cdparanoia consistently hangs at the end of
the rip. When dropping either of these options or ripping a different
track everything works fine. The actual sample-offset used doesn't seem
to have an effect.

This happens with both of my drives. I'm using the /dev/srx interfaces.

When running cdparanoia with option "-e", it keeps looping through the
message "##: 6 [skip] < at > 0".

Please tell me if there's more information I could provide to help to
debug the problem.

Thank you very much!

Martin

Re: cdparanoia and FreeBSD kernel

2009-09-09T01:20:27

Hi,

I have no way of testing it and prefer not to adopt patches I can
neither test nor maintain.  I don't mean to discourage ports, nor
would I object to a freebsd maintainer who was willing to contribute
to the project by reviewing patches on an ongoing basis, or maintain
an external port (as is down now).  But for now, any 'official'
support of other OSes would be completely blind, and likely to break
with every change I make without me even knowing :-(

Cdparanoia is very specific to a given kernel and I see no easy way of
changing that.

Monty